Re: Review Request: Updated the ScrollWidget class to use the Plasma::Animator::create

2010-02-12 Thread loureiro . andrew
> On 2010-02-12 20:56:57, Marco Martin wrote: > > it's public, so unfortunately you can't remove functions :/ bc bc bc - loureiro --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2903/#review4

Review Request: Updated the ScrollWidget class to use the Plasma::Animator::create

2010-02-12 Thread loureiro . andrew
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2903/ --- Review request for Plasma, Marco Martin, igorto, Adenilson Cavalcanti, and Bruno

Review Request: Change the all Plasma::Animator::self to Plasma::Animator::create in FlashingLable class.

2010-02-10 Thread loureiro . andrew
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2877/ --- Review request for Plasma, Aaron Seigo, Marco Martin, igorto, Adenilson Cavalcant

Re: Review Request: Fix segv in newspaper AppletTitleBar and use QParallelAnimationGroup to anime conf and close button

2010-02-09 Thread loureiro . andrew
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2862/ --- (Updated 2010-02-09 21:43:03.073993) Review request for Plasma, Aaron Seigo, Mar

Review Request: Fix segv in newspaper AppletTitleBar and use QParallelAnimationGroup to anime conf and close button

2010-02-08 Thread loureiro . andrew
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2862/ --- Review request for Plasma, Aaron Seigo, Marco Martin, igorto, Adenilson Cavalcant

Review Request: Removed reference to Plasma::Animator::self in nettoolbox class

2010-02-04 Thread loureiro . andrew
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2830/ --- Review request for Plasma, Marco Martin and igorto. Summary --- NetToolBox

Review Request: Removed Plasma::Animator::self from AppletTitleBar class

2010-02-02 Thread loureiro . andrew
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2783/ --- Review request for Plasma, Marco Martin and igorto. Summary --- Removed Pla

Re: Review Request: Fix segmentation fault at plasma_applet_animation_example

2010-01-29 Thread loureiro . andrew
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2738/ --- (Updated 2010-01-29 20:25:39.054487) Review request for Plasma, Aaron Seigo, Mar

Re: Review Request: Fix segmentation fault at plasma_applet_animation_example

2010-01-29 Thread loureiro . andrew
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2738/ --- (Updated 2010-01-29 19:32:53.244002) Review request for Plasma, Aaron Seigo, Mar

Re: Review Request: Fix segmentation fault at plasma_applet_animation_example

2010-01-28 Thread loureiro . andrew
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2738/ --- (Updated 2010-01-28 15:39:43.596354) Review request for Plasma, Aaron Seigo, Mar

Re: Review Request: Fix segmentation fault at plasma_applet_animation_example

2010-01-28 Thread loureiro . andrew
> On 2010-01-27 17:08:08, Aaron Seigo wrote: > > this will result in a leak when the layout isn't assigned. e.g.: > > > > Animation* rotStackedAnim = > > Plasma::Animator::create(Plasma::Animator::RotationStackedAnimation); > > delete rotStackedAnim; > > > > and then we have a leak. >

Review Request: Fix segmentation fault at plasma_applet_animation_example

2010-01-27 Thread loureiro . andrew
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2738/ --- Review request for Plasma, Aaron Seigo, Marco Martin, igorto, and Adenilson Caval

Review Request: update cmake geolocation

2010-01-04 Thread loureiro . andrew
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2495/ --- Review request for Plasma. Summary --- this ticket follows the previous, 24

Review Request: Update the method name in gps library

2010-01-04 Thread loureiro . andrew
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2493/ --- Review request for Plasma. Summary --- The current version of gps library i