Re: Review Request: Added bouncing effect for Rotation animation

2010-04-07 Thread igorto
> On 2010-04-07 15:16:04, Marco Martin wrote: > > don't think it's the right approach. > > we should probably have easing curve support for our animations that are > > directly qabstractanimations so you suggest create our own easing curvers for special a

Re: Review Request: Added bouncing effect for Rotation animation

2010-04-07 Thread igorto
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3513/#review4908 --- Ship it! Looks good. And i nice animation. - igorto On 2010-04-07

Re: Review Request: Rewrite kinetic scrolling on ScrollWidget

2010-03-17 Thread igorto
plasma/private/kineticscroll.* because there is the old kinetic scroll implementation and it is used by others classes(like plasma/webview) and would be difficult maintain two different kinetic scrolling implementations. - igorto On 2010-03-17 04:59:11, Zack Rusin wrote

Review Request: Plasma Netbook: Show the applet title bar when the applet has background or a hover event happens

2010-02-08 Thread igorto
/applettitlebar.cpp 1087075 Diff: http://reviewboard.kde.org/r/2861/diff Testing --- Thanks, igorto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Plasma Netbook: remove layout complexity from newspaper.cpp

2010-02-02 Thread igorto
the parentItem(), api to > > power an hack is ungood :) in fact parentWidget() probably is better :> - igorto --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2782/#review4023 --

Review Request: Plasma Netbook: remove layout complexity from newspaper.cpp

2010-02-02 Thread igorto
trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/newspaper.cpp 1084070 Diff: http://reviewboard.kde.org/r/2782/diff Testing --- Thanks, igorto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Re: Review Request: Fix segmentation fault at plasma_applet_animation_example

2010-01-29 Thread igorto
u can commit - igorto On 2010-01-29 19:32:53, loureiro wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2738/ > --

Review Request: Emit signal when launchQuery finish

2010-01-14 Thread igorto
: http://reviewboard.kde.org/r/2592/diff Testing --- Thanks, igorto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Port Kinetic Scrolling to Qt 4.6

2009-11-18 Thread igorto
://reviewboard.kde.org/r/2205/diff Testing --- Thanks, igorto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Plasma Netbook animated Version 1

2009-10-29 Thread igorto
generic code style stuff: all this block should be indented a > > level less, so public: at the level of { done - igorto --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2008/#review2856

Re: Review Request: Plasma Netbook animated Version 1

2009-10-29 Thread igorto
rote: > > trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/animatedlinearlayout.h, > > line 6 > > <http://reviewboard.kde.org/r/2008/diff/1/?file=13488#file13488line6> > > > > extra space in the end of line done - igorto -

Re: Review Request: Plasma Netbook animated Version 1

2009-10-29 Thread igorto
/netbook/containments/sal/itemcontainer.cpp 1042281 Diff: http://reviewboard.kde.org/r/2008/diff Testing --- Thanks, igorto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Plasma Netbook animated Version 1

2009-10-29 Thread igorto
/KDE/kdebase/workspace/plasma/netbook/containments/sal/itemcontainer.cpp 1042281 Diff: http://reviewboard.kde.org/r/2008/diff Testing --- Thanks, igorto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo

Review Request: Plasma Netbook animated Version 1

2009-10-29 Thread igorto
Diff: http://reviewboard.kde.org/r/2008/diff Testing --- Thanks, igorto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Animator::registerScrollingWidget()

2009-10-19 Thread igorto
good add it in a deprecated class but move it to animations directory and make it a child of AbstractAnimation it is not a good idea too. - igorto On 2009-10-19 12:59:46, Marco Martin wrote: > > --- > This is an automatically ge

Re: Review Request: Kineticscrolling: a zero api approach

2009-10-13 Thread igorto
ttp://reviewboard.kde.org/r/1840/#comment1958> Well watch should have a qgraphicsitem, QObject does not make sense here because the scrolling just happens in qgraphicsX classes :> - igorto On 2009-10-13 20:48:15, Marco Martin wrote: > > ---

Re: Review Request: kineticscrolling, with pixel based properties

2009-10-08 Thread igorto
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1799/#review2588 --- Ship it! Working fine here. - igorto On 2009-10-07 19:54:07

Review Request: WebView Kinetic Scrolling

2009-10-03 Thread igorto
--- webbrowser Thanks, igorto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel