> On 2010-02-02 18:37:25, Marco Martin wrote: > > trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/appletscontainer.cpp, > > line 233 > > <http://reviewboard.kde.org/r/2782/diff/2/?file=18236#file18236line233> > > > > not sure about putting this here > > (also because it's needed just because of suckiness of > > qgraphicslayouts, too many updates if there isn't some hardcoded sizes, > > would love to remove it some day) > > > > probablyshould just fetch it from the size of the parentItem(), api to > > power an hack is ungood :)
in fact parentWidget() probably is better :> - igorto ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2782/#review4023 ----------------------------------------------------------- On 2010-02-02 18:06:43, igorto wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2782/ > ----------------------------------------------------------- > > (Updated 2010-02-02 18:06:43) > > > Review request for Plasma, Marco Martin and Adenilson Cavalcanti. > > > Summary > ------- > > Remove the layout complexity from newspaper.cpp and create a new class to > handle it. > > > Diffs > ----- > > > trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/CMakeLists.txt > 1084070 > > trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/appletoverlay.cpp > 1084070 > > trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/appletscontainer.h > PRE-CREATION > > trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/appletscontainer.cpp > PRE-CREATION > > trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/newspaper.h > 1084070 > > trunk/KDE/kdebase/workspace/plasma/netbook/containments/newspaper/newspaper.cpp > 1084070 > > Diff: http://reviewboard.kde.org/r/2782/diff > > > Testing > ------- > > > Thanks, > > igorto > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
