Review Request 130030: taskmanager : Implement window group dragging

X11. I'm not sure it can work on Wayland as the drag handling seems to be very X11 specific. Thanks, Yoann Laissus

Re: Review Request 127710: Some cleanup in the applet and the KCM

an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127710/#review94776 --- On avr. 23, 2016, 11:04 matin, Yoann Laissus wrote: > > --- > This

Re: Review Request 127710: Some cleanup in the applet and the KCM

marked as submitted. Review request for Plasma and David Rosca. Changes --- Submitted with commit 6a96a7259a0c0a9feb69c2c30efc5dc4ca879e98 by Yoann Laissus to branch master. Repository: plasma-pa Description --- Branche "cleanup" here : git://anongit.kde.org/clones

Re: Review Request 127710: Some cleanup in the applet and the KCM

marked as submitted. Review request for Plasma and David Rosca. Changes --- Submitted with commit 6a96a7259a0c0a9feb69c2c30efc5dc4ca879e98 by Yoann Laissus to branch master. Repository: plasma-pa Description --- Branche "cleanup" here : git://anongit.kde.org/clones

Re: Review Request 127710: Some cleanup in the applet and the KCM

1fe422 src/sourceoutput.cpp 66152869618426d8fb27f60d4722816ffbe5144d src/stream.h 109997c1b3160bb1752d874db218d7f5a3e55f47 src/stream.cpp 55c0c6bf40d7b3d8ba3e97123e9f1eec4c0c9230 Diff: https://git.reviewboard.kde.org/r/127710/diff/ Testing --- Thanks, Yoann Laissus __

Re: Review Request 127710: Some cleanup in the applet and the KCM

3e55f47 src/stream.cpp 55c0c6bf40d7b3d8ba3e97123e9f1eec4c0c9230 Diff: https://git.reviewboard.kde.org/r/127710/diff/ Testing --- Thanks, Yoann Laissus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127710: Some cleanup in the applet and the KCM

a7653765b75aa099e8c1fe422 src/sourceoutput.cpp 66152869618426d8fb27f60d4722816ffbe5144d src/stream.h 109997c1b3160bb1752d874db218d7f5a3e55f47 src/stream.cpp 55c0c6bf40d7b3d8ba3e97123e9f1eec4c0c9230 Diff: https://git.reviewboard.kde.org/r/127710/diff/ Testing ---

Re: Review Request 127618: Applet : Display icons and device selection for streams

ut moving > > > sinkIndex and sourceIndex to a deviceIndex property in the Stream class ? > > It would avoid to send an hardcoded deviceType to delegates. > > > > Yes, that would indeed be much better. > > Yoann Laissus wrote: > > The device combobox for

Re: Review Request 127618: Applet : Display icons and device selection for streams

09/8adff934-e24d-4933-870e-7b23803ba5e3__Screenshot_20160409_145925.png Thanks, Yoann Laissus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127618: Applet : Display icons and device selection for streams

h better. I'll do another review for that. - Yoann --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127618/#review94457 --- O

Review Request 127618: Applet : Display icons and device selection for streams

--- Streams https://git.reviewboard.kde.org/media/uploaded/files/2016/04/09/f52f75ba-a800-4a82-8d75-08051edf7100__Screenshot_20160409_145911.png Devices https://git.reviewboard.kde.org/media/uploaded/files/2016/04/09/8adff934-e24d-4933-870e-7b23803ba5e3__Screenshot_20160409_145925.png T

Re: Review Request 127540: [plasma-pa] Don't show virtual streams which aren't displayed correctly

marked as submitted. Review request for Plasma. Changes --- Submitted with commit 38b7ef0d04844524ff24d0ed741abbf751380099 by Yoann Laissus to branch master. Repository: plasma-pa Description --- Virtual streams appear when virtual devices are defined in PulseAudio configuration

Re: Review Request 127540: [plasma-pa] Don't show virtual streams which aren't displayed correctly

3ea-032f-4246-95b8-ba9a4d228ccd__Screenshot_20160331_232502.png Applet https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/1a3d3e3a-6078-445d-84c4-8929cb6243a8__Screenshot_20160331_232444.png Thanks, Yoann Laissus ___ Plasma-devel mailing list Plasma-d

Re: Review Request 127540: [plasma-pa] Don't show virtual streams which aren't displayed correctly

> On avr. 5, 2016, 5:43 après-midi, David Rosca wrote: > > src/pulseaudio.h, line 64 > > <https://git.reviewboard.kde.org/r/127540/diff/2/?file=455590#file455590line64> > > > > I think this change (adding AbstractStreamModel) is not needed. > > Yoann

Re: Review Request 127540: [plasma-pa] Don't show virtual streams which aren't displayed correctly

viewboard.kde.org/media/uploaded/files/2016/03/31/1a3d3e3a-6078-445d-84c4-8929cb6243a8__Screenshot_20160331_232444.png Thanks, Yoann Laissus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127540: [plasma-pa] Don't show virtual streams which aren't displayed correctly

ff/2/?file=455597#file455597line38> > > > > Unrelated Right, deleted in the upcoming patch. - Yoann ----------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127540/#review94305

Re: Review Request 127540: [plasma-pa] Don't show virtual streams which aren't displayed correctly

/uploaded/files/2016/03/31/cdf983ea-032f-4246-95b8-ba9a4d228ccd__Screenshot_20160331_232502.png Applet https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/1a3d3e3a-6078-445d-84c4-8929cb6243a8__Screenshot_20160331_232444.png Thanks, Yoann Laissus

Re: Review Request 127540: [plasma-pa] Don't show virtual streams which aren't displayed correctly

d/files/2016/03/31/cdf983ea-032f-4246-95b8-ba9a4d228ccd__Screenshot_20160331_232502.png Applet https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/1a3d3e3a-6078-445d-84c4-8929cb6243a8__Screenshot_20160331_232444.png Thanks, Yoann Laissus ___ Pl

Re: Review Request 127540: [plasma-pa] Don't show virtual streams which aren't displayed correctly

the pavucontrol window screen for the same streams as comparaison. - Yoann --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127540/#review94168 -------

Re: Review Request 127540: [plasma-pa] Don't show virtual streams which aren't displayed correctly

ploaded/files/2016/03/31/44b3c277-ee01-4dbf-99f7-dc27edc592e9__Screenshot_20160331_225554.png Thanks, Yoann Laissus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127540: [plasma-pa] Don't show virtual streams which aren't displayed correctly

-45e2-88b9-6bf526f98311__Screenshot_20160331_225655.png Applet https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/44b3c277-ee01-4dbf-99f7-dc27edc592e9__Screenshot_20160331_225554.png Thanks, Yoann Laissus ___ Plasma-devel mailing list Plasma-devel@kde

Re: Review Request 123818: soliddevice: Use KDiskFreeSpaceInfo instead of solid to get disk size

marked as submitted. Review request for Plasma. Changes --- Submitted with commit 9b474a4ab01c3268048e29c336cf7b3fe9a83a47 by Yoann Laissus to branch master. Repository: plasma-workspace Description --- Currently, the size of devices is retrieved with solid. Unfortunately, it

Re: Review Request 123818: soliddevice: Use KDiskFreeSpaceInfo instead of solid to get disk size

automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123818/#review84670 --- On mai 16, 2015, 6:44 après-midi, Yoann Laissus wrote: > > --- > T

Re: Review Request 123884: Make sure the desktop folderview doesn't overlap with panels.

marked as submitted. Review request for Plasma. Changes --- Submitted with commit 1f9c20e4c4c25f5df3593792f5166af36068 by Yoann Laissus to branch Plasma/5.3. Repository: plasma-desktop Description --- Currently, when the desktop is configured with "Folder view" mode, i

Re: Review Request 123815: Fix the panel configuration width in case of long strings in buttons.

> On mai 17, 2015, 11:33 matin, David Edmundson wrote: > > Nice work, thanks. > > Yoann Laissus wrote: > A little late for the 5.3.1 but do I need to backport the patch to the > 5.3 branch ? > > David Edmundson wrote: > If you want it in 5.3.2, yes.

Re: Review Request 123815: Fix the panel configuration width in case of long strings in buttons.

ly, visit: https://git.reviewboard.kde.org/r/123815/#review80514 --- On mai 17, 2015, 1:23 après-midi, Yoann Laissus wrote: > > --- > This is an automatically generated e-mai

Re: Review Request 123817: Device notifier: Refresh the space indicator every 5 seconds.

cally generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123817/#review80566 --- On mai 17, 2015, 11:01 matin, Yoann Laissus wrote: > > --- > This is an

Re: Review Request 123884: Make sure the desktop folderview doesn't overlap with panels.

y, visit: https://git.reviewboard.kde.org/r/123884/#review80784 ------- On mai 27, 2015, 7:47 après-midi, Yoann Laissus wrote: > > --- > This is an automatically gener

Re: Review Request 123884: Make sure the desktop folderview doesn't overlap with panels.

h https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/8e137ad4-6a6d-4a9c-b9b9-3b9bd7bf05ec__without_overlap.jpg Thanks, Yoann Laissus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123884: Make sure the desktop folderview doesn't overlap with panels.

h https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/8e137ad4-6a6d-4a9c-b9b9-3b9bd7bf05ec__without_overlap.jpg Thanks, Yoann Laissus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 123884: Make sure the desktop folderview doesn't overlap with panels.

-46ab-86ad-9aa626c0dc2b__with_overlap.jpg With the patch https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/8e137ad4-6a6d-4a9c-b9b9-3b9bd7bf05ec__without_overlap.jpg Thanks, Yoann Laissus ___ Plasma-devel mailing list Plasma-devel@kde

Re: Review Request 123815: Fix the panel configuration width in case of long strings in buttons.

marked as submitted. Review request for Plasma. Changes --- Submitted with commit ad81cae37b112b67de2a515255cf73ce6df2330d by Yoann Laissus to branch master. Repository: plasma-desktop Description --- The panel configuration width is defined to a fixed value when it's vertica

Re: Review Request 123817: Device notifier: Refresh the space indicator every 5 seconds.

marked as submitted. Review request for Plasma. Changes --- Submitted with commit 44f957af3ef3d786012a70167e5cd170df0d5440 by Yoann Laissus to branch master. Repository: plasma-workspace Description --- Previously, it was set to 0 so the space indicator was never refreshed. Diffs

Re: Review Request 123817: Device notifier: Refresh the space indicator every 5 seconds.

vice notifier is visible. - Yoann --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123817/#review80492 --- On mai 17, 2015, 9:42 m

Re: Review Request 123817: Device notifier: Refresh the space indicator every 5 seconds.

1fb3d28736fc5effb7e6a6e5940a7bab28c19798 Diff: https://git.reviewboard.kde.org/r/123817/diff/ Testing --- Thanks, Yoann Laissus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123818: soliddevice: Use KDiskFreeSpaceInfo instead of solid to get disk size

r of this part. - Yoann --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123818/#review80471 --- On mai 16, 2015, 6:44 après-

Re: Review Request 123818: soliddevice: Use KDiskFreeSpaceInfo instead of solid to get disk size

dataengines/soliddevice/soliddeviceengine.cpp 94819c7405a3eb4b0ef679a55de2de20bd05fdb2 dataengines/soliddevice/soliddeviceservice.cpp f2f96ef4d63f41e3e2ea9bf31297adfcdf151a97 Diff: https://git.reviewboard.kde.org/r/123818/diff/ Testing --- Tested with local disks, USB devices, NFS shares

Review Request 123818: soliddevice: Use KDiskFreeSpaceInfo instead of solid to get disk size

ard.kde.org/r/123818/diff/ Testing --- Tested with local disks, USB devices, NFS shares Thanks, Yoann Laissus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 123817: Device notifier: Refresh the space indicator every 5 seconds.

--- Previously, it was set to 0 so the space indicator was never refreshed. Diffs - applets/devicenotifier/package/contents/ui/devicenotifier.qml 1fb3d28736fc5effb7e6a6e5940a7bab28c19798 Diff: https://git.reviewboard.kde.org/r/123817/diff/ Testing --- Thanks, Yoann Laissus

Review Request 123815: Fix the panel configuration width in case of long strings in buttons.

-5523-4682-aabb-fc0e23ac5bdc__fixed_button.jpg Thanks, Yoann Laissus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123547: Task manager : Make the middle click action on tasks configurable

marked as submitted. Review request for Plasma. Changes --- Submitted with commit ebc796a61db738a1f955d2d50a8921c7c312f1bf by Yoann Laissus to branch master. Repository: plasma-desktop Description --- Currently, only the shortcut Shift + Left click is available. In KDE4, we had both

Re: Review Request 123547: Task manager : Make the middle click action on tasks configurable

4 Diff: https://git.reviewboard.kde.org/r/123547/diff/ Testing --- Tested with classic task manager and the icon only one. Tested with all mouse button combinaisons and keyboard modifiers. Thanks, Yoann Laissus ___ Plasma-devel mailing list Plasm

Re: Review Request 123684: Device notifier : Make the "Used space" progress bar clickable

) - applets/devicenotifier/package/contents/ui/DeviceItem.qml 3078cef Diff: https://git.reviewboard.kde.org/r/123684/diff/ Testing --- Tested with mounted and umounted devices. Thanks, Yoann Laissus ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request 123684: Device notifier : Make the "Used space" progress bar clickable

l. To reply, visit: https://git.reviewboard.kde.org/r/123684/#review80104 ------- On mai 8, 2015, 4:38 après-midi, Yoann Laissus wrote: > > --- > This is an automatic

Review Request 123684: Device notifier : Make the "Used space" progress bar clickable

devices. Thanks, Yoann Laissus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123547: Task manager : Make the middle click action on tasks configurable

Diff: https://git.reviewboard.kde.org/r/123547/diff/ Testing --- Tested with classic task manager and the icon only one. Tested with all mouse button combinaisons and keyboard modifiers. Thanks, Yoann Laissus ___ Plasma-devel mailing list

Re: Review Request 123547: Task manager : New instances can now be opened by mid click.

ns and keyboard modifiers. Thanks, Yoann Laissus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123547: Task manager : New instances can now be opened by mid click.

only implements the one behavior. > > Martin Gräßlin wrote: > Even more I would expect that it copies the current copy buffer into a > running instance. Middle click is paste after all. > > Yoann Laissus wrote: > @Eike : Ok, I'll add an option in the settings to

Re: Review Request 123547: Task manager : New instances can now be opened by mid click.

not sure to understand, what do you mean by copying the copy buffer ? - Yoann --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123547/#review79649 ------

Re: Review Request 123547: Task manager : New instances can now be opened by mid click.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123547/#review79647 --- On avr. 28, 2015, 8:45 après-midi, Yoann Laissus wrote: > >

Re: Review Request 123547: Task manager : New instances can now be opened by mid click.

with classic task manager and the icon only one. Tested with all mouse button combinaisons and keyboard modifiers. Thanks, Yoann Laissus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 123547: Task manager : New instances can now be opened by mid click.

. Thanks, Yoann Laissus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel