Re: Review Request: Adjust TimeSpecs in the Calendar Dataengine to Reflect Local Time

2011-11-10 Thread Sergio Luis Martins
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103104/#review8110 --- Ship it! Ship It! - Sergio Luis Martins On Nov. 10, 2011, 5

Re: Review Request: Adjust TimeSpecs in the Calendar Dataengine to Reflect Local Time

2011-11-10 Thread Sergio Luis Martins
so, please convert it too. - Sergio Luis Martins On Nov. 10, 2011, 5:58 a.m., David Narváez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.k

Re: Review Request: Adjust KDateTimes to Current TimeSpec of the Calendar

2011-11-09 Thread Sergio Luis Martins
ted Nov. 8, 2011, 9:14 a.m.) > > > Review request for Plasma and Sergio Luis Martins. > > > Description > --- > > Adjust KDateTimes after finding out the type of incidence added. Also adjust > KDateTimes after a change in the Calendar TimeSpec. > > >

Re: Review Request: Adjust KDateTimes to Current TimeSpec of the Calendar

2011-11-09 Thread Sergio Luis Martins
> On Nov. 1, 2011, 7:39 p.m., Sergio Luis Martins wrote: > > A Calendar object is supposed to mirror what's in akonadi, so we can't > > change Incidence's timezones in there. > > > > I think this should be resolved in the presentation layer, c

Re: Review Request: Adjust KDateTimes to Current TimeSpec of the Calendar

2011-11-01 Thread Sergio Luis Martins
i, so we can't change Incidence's timezones in there. I think this should be resolved in the presentation layer, converting to the local timezone there ( KSystemTimeZones::local() ) - Sergio Luis Martins On Oct. 31, 2011, 6:57 a.m., Davi

Re: Review Request: remove Assert on collection id change

2011-02-26 Thread Sergio Luis Martins
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100523/#review1656 --- I fixed kdepim/calendarsupport/calendar.cpp. It now handles mov

Re: Review Request: remove Assert on collection id change

2011-02-16 Thread Sergio Luis Martins
> On Feb. 14, 2011, 9:37 p.m., John Layt wrote: > > This is in a file copied in from Akonadi and I would strongly prefer us not > > to patch them up in plasma. I intend to occasionally update the code from > > Akonadi until such time as the required classes become public and we can > > delete

Re: Review Request: remove Assert on collection id change

2011-02-04 Thread Sergio Luis Martins
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100523/#review1229 --- I don't know if calendar.cpp will support moves just by removing