ppalaga updated this revision to Diff 11952.
ppalaga added a comment.
> One more request, would you mind rebasing it against current master?
(Doesn't apply cleanly currently.)
I rebased and updated the diff, but I had no to time to run the rebased code.
I hope that you or somebody else w
ppalaga added a comment.
> Patch looks good.
Thanks for the review and for the assistance!
> Do you have a developer account to commit it or should I do it for you?
Yes, please do it for me.
REVISION DETAIL
https://phabricator.kde.org/D4550
EMAIL PREFERENCES
https://phabric
ppalaga added a comment.
In https://phabricator.kde.org/D4550#90464, @hein wrote:
> Looks good!
Thanks. What is the next step, actually? Is there more feedback to be
expected here or somewhere else?
REVISION DETAIL
https://phabricator.kde.org/D4550
EMAIL PREFERENCES
https://
ppalaga updated this revision to Diff 11852.
ppalaga added a comment.
> The comparisons (thanks for going to the length to make them) look OK, at
least for "let's go with this and check for feedback". Let's go ahead!
Nice to heard that :)
I am updating the diff so that the configurat
ppalaga updated this revision to Diff 11596.
ppalaga added a comment.
In https://phabricator.kde.org/D4550#88247, @hein wrote:
> I'm starting to like it, but it's a little bit scary. The thing is that we
don't want to alter behavior in existing user setups, which is mostly narrow
vertica
ppalaga retitled this revision from "Task Manager: Make maximum text lines and
minimum line length configurable for task buttons." to "Task Manager: Make the
icon size configurable for task buttons in a vertical task manager".
ppalaga edited the summary of this revision.
ppalaga edited the test p
ppalaga updated this revision to Diff 11562.
ppalaga added a comment.
New or noteworthy about the second iteration:
(1) It implements the proposal c) of Eike.
(2) There is is just one "Icon size" control in the configuration dialog,
instead of two controls in the previous iteration.
ppalaga reclaimed this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4550
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: ppalaga, davidedmundson, hein, broulik
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed,
ppalaga abandoned this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4550
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: ppalaga, davidedmundson, hein, broulik
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed,
ppalaga added a comment.
Hallo Eike,
Yes, as long as we do not (I guess we do not) have any reliable data about
user preferences, it is hard to assess the impact of any hard-coded rendering
constant change. A move either way will inevitably make somebody upset. I think
that making a set
ppalaga added a comment.
Hi Eike und Kai Uwe,
Thanks for your feedback. This is my first submission here, although I am a
loyal user of KDE since 2001. Please be patient with me. I may have fully
inappropriate expectations and I may be violating your processes and rules.
I'll be glad to
ppalaga added reviewers: broulik, davidedmundson, hein.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D4550
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: ppalaga, broulik, davidedmundson, hein
Cc: plasma-devel, lesliezhai,
ppalaga created this revision.
ppalaga set the repository for this revision to R119 Plasma Desktop.
ppalaga added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This improves the rendering when the task manager is oriented vertically.
Before this ch
13 matches
Mail list logo
