ppalaga updated this revision to Diff 11562. ppalaga added a comment.
New or noteworthy about the second iteration: (1) It implements the proposal c) of Eike. (2) There is is just one "Icon size" control in the configuration dialog, instead of two controls in the previous iteration. F2516001: pasted_file <https://phabricator.kde.org/F2516001> (2) The "Icon size" combo and its label are visible only if the task manager is positioned vertically (3) The "Icon size" preference is effective only for vertical task managers. It basically limits the size the icon is allowed to stretch to. See the changes in preferredMaxHeight() function. (4) The "5 literal" meaning the number of 'm' characters whose joint width must be available in the task button label so that the button text is rendered at all was refactored to minimumMColumns() function in layout.js. minimumMColumns() returns 5 for horizontal layouts and 3 for vertical layouts. (5) The present proposal does not change the behavior of horizontal task manager in any way. (6) The present proposal reaches the goal of making it possible to show some text in a vertical task manager through choosing a smaller icon size in the configuration. OTOH, users interested in icon-only layouts may reach their aim by selecting larger icons or narrower vertical task manager. Is the present proposal acceptable? REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4550?vs=11175&id=11562 REVISION DETAIL https://phabricator.kde.org/D4550 AFFECTED FILES applets/taskmanager/package/contents/code/layout.js applets/taskmanager/package/contents/config/main.xml applets/taskmanager/package/contents/ui/ConfigGeneral.qml applets/taskmanager/package/contents/ui/Task.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ppalaga, davidedmundson, hein, broulik Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
