ult for new users (who use either of the 'quick
config' schemes like kdesrc-build-setup or kdesrc-build
--initial-setup), but to leave the built-in default unchanged.
So in essence, existing kdesrc-build users (who had a folder-based
layout by default unless they went out of their way to find the right
option) saw no change, but new users would have that option pre-set for
them in the config.
Regards,
- Michael Pyne
as explained at
https://community.kde.org/Sysadmin/GitKdeOrgManual#Let_Git_rewrite_URL_prefixes).
kdesrc-build configures git to understand this "kde:" prefix by default.
Regards,
- Michael Pyne
1 https://gitlab.com/
344 kde:
All of the kde: repositories use the kde:foo syntax, where the 'foo'
comes from the 'repopath' parameter of the sysadmin/repo-metadata YAML
files.
We may need to do on-the-fly conversion of the kde: repo paths if they
won't be expressible as 'kde:foo' in the future, but we should have the
information needed to do this in kdesrc-build to make this happen
on-the-fly.
Regards,
- Michael Pyne
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:b23e642e5ac4: Explicitly request Qt 5.7's QtQuick to
make use of Connections.enabled (authored by mpyne).
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14984?vs=4
mpyne created this revision.
mpyne added reviewers: Frameworks, Plasma, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
mpyne requested review of this revision.
REVISION SUMMARY
I recently rebuilt my Qt, KF5, and Plasma 5 environments from scratch. I
noticed tha
I'd be very much in favor or loosening
restrictions on bug permissions to at least allow for community bug
triaging. It's the kind of task that requires community involvement
anyways (for testing in environments devs can't easily reproduce) and I
think anything we do that gives the broader user community more
'ownership' into the bug database would lead to a more accurate and
useful bug database.
Regards,
- Michael Pyne
This revision was automatically updated to reflect the committed changes.
Closed by commit R106:3588e85cd8a6: softraid: Remove dead code and associated
warning. (authored by mpyne).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6658?vs=16597&id=17265#toc
REPOSITORY
R106 KSysguard
CHA
mpyne added a comment.
If anyone has objections please let me know in the next few days.
REPOSITORY
R106 KSysguard
REVISION DETAIL
https://phabricator.kde.org/D6658
To: mpyne, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mar
mpyne added a comment.
In https://phabricator.kde.org/D6631#126937, @bcooksley wrote:
> Sorry, looks like it's still unhappy (another different error). This time
it's complaining about gettimeofday()
> According to https://github.com/kinetiknz/cubeb/issues/6 defining
XOPEN_SOURCE will
mpyne added a comment.
In https://phabricator.kde.org/D6631#126366, @bcooksley wrote:
> Thanks for the quick fix.
>
> Getting closer - got a different error this time...
> https://build.kde.org/job/Plasma%20ksysguard%20kf5-qt5%20FreeBSDQt5.7/7/
This fix wasn't as quick, I ha
mpyne added a comment.
In https://phabricator.kde.org/D6631#126101, @bcooksley wrote:
> Clang doesn't seem to like this:
https://build.kde.org/job/Plasma%20ksysguard%20kf5-qt5%20FreeBSDQt5.7/4/console
Thanks. Looks from the build log like it's not good enough to define the
`_POS
mpyne created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Something I noticed while doing the musl libc fixes:
1. A GCC warning is generated for `in_devs`. It turns out the warning was
referring t
This revision was automatically updated to reflect the committed changes.
Closed by commit R106:257591cf462d: Fix compilation with strict libc (such as
musl). (authored by mpyne).
REPOSITORY
R106 KSysguard
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6631?vs=16520&id=16590
REVISIO
mpyne edited the summary of this revision.
mpyne removed a reviewer: Frameworks.
mpyne changed the repository for this revision from R111 KSysguard Library to
R106 KSysguard.
REPOSITORY
R106 KSysguard
REVISION DETAIL
https://phabricator.kde.org/D6631
To: mpyne, #plasma
Cc: plasma-devel, Zre
mpyne created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Many of the functions we use implicitly are not part of the C standard
library so we have to specific that we're pulling from POSIX, X/Open,
mpyne accepted this revision.
mpyne added a comment.
This revision is now accepted and ready to land.
Looks good to me, and compiles/tests fine here. Though I'm not using it on
any hg repos so I can't actually test the new feature, but as long as it works
for you I'd say go ahead and commit.
mpyne accepted this revision.
mpyne added a comment.
The change is fine as far as privacy impact, it shouldn't add any issues that
aren't already present.
REPOSITORY
R105 KDE SSH Password Dialog
REVISION DETAIL
https://phabricator.kde.org/D4540
EMAIL PREFERENCES
https://phabricator.kd
estWaylandOutputDevice class does not have an initializer for
m_queue within the constructor (or in any of the other class members it looked
at). But I don't see how that would be related either.
Regards,
- Michael Pyne
___
Plasma-devel mailing list
marked as submitted.
Review request for KDE Frameworks and Plasma.
Changes
---
Submitted with commit b595f47f021cbcf1cee23cd0bee1df57a2e2f1b9 by Michael Pyne
to branch master.
Repository: oxygen
Description
---
oxygen windeco: Fix use-after-free for pixmap in QCache.
Coverity
'm sure is a local misconfiguration...
Thanks,
Michael Pyne
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
marked as submitted.
Review request for KDE Frameworks and Plasma.
Changes
---
Submitted with commit 9543cc4058b24e4e5bfe8d324de309ca7050058b by Michael Pyne
to branch master.
Repository: kwallet-pam
Description
---
Coverity strikes again, and notes in CID 1335116 that copying the
---
Code still compiles.
Thanks,
Michael Pyne
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
marked as submitted.
Review request for Plasma.
Changes
---
Submitted with commit a14a7d39c41bd3280dcc56dcd97e846e0278e812 by Michael Pyne
to branch Plasma/5.5.
Repository: plasma-workspace
Description
---
Coverity noted we were mismatching new Foo with free(foo), which is
esting
---
I've only compiled and verified no warnings at this point. I didn't see any
relevant crash bugs after a quick web search either.
Thanks,
Michael Pyne
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/
marked as submitted.
Review request for Plasma.
Changes
---
Submitted with commit 5c1d2ed01c9eb4f5c56990de8de6373f4f50c785 by Michael Pyne
to branch master.
Repository: plasma-framework
Description
---
Fixes a minor memleak in PackageUrlInterceptor (noted by Coverity, CID
#1332370
,
Michael Pyne
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
marked as submitted.
Review request for Plasma.
Changes
---
Submitted with commit 600bdda04508fab512ed97c9874353378c7cb3fa by Michael Pyne
to branch master.
Repository: plasma-framework
Description
---
Plasma framework's FrameSVG class uses cached regions for efficiency. Ho
losed years ago, at least).
Thanks,
Michael Pyne
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
bugfix was first committed.
Still, it's a good point that we have to put thought into our CHANGELOG
entries. CHANGELOG entries on every commit would be just as useless as not
having those entries on any commit.
Regards,
- Michael Pyne
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
ture" is up to date.
The kde-build-metadata module has a script to verify that you get the right
branch name so that you don't have to run kdesrc-build to validate the JSON or
ensure you got what you expected.
I might do this myself in the next day or so
e them).
[1]: http://community.kde.org/Infrastructure/Project_Metadata
[2]: http://markmail.org/message/4l3yqerga7mfiit5
Anyways, thanks for your interest and please let me know if this will work to
solve the problem at hand. If so I will start on integrating within k
ommit. It can always be reverted
later if it causes an issue, and it sounds like it fixes several other problems
that haven't become issues yet.
- Michael Pyne
On July 7, 2012, 3:07 a.m., Raphael Kubo da Costa wrote:
>
>
On Thursday, April 29, 2010 21:12:42 Michael Pyne wrote:
> Well that [changeable layout] isn't what *I* wanted, but I see your point
> given that precondition, and it occurs to me that the one having to touch
> my code afterwards may want to change the layout, so I'll move it ar
27;d
also like to get this in before 4.4 so I would appreciate a prompt review if
possible so I can contact release-team.
Thanks!
Regards,
- Michael Pyne
Index: plasma/runnercontext.cpp
===
--- plasma/runnercontext.cpp (revision 1070191
27;s some kind of public interface) is it OK to just change the name all of a
sudden? Or does this ui_calendarConfig.h file need installed at all (if not
I'd just remove it I think).
If you need any more info from me please CC me as I'm not subscribed.
Regards,
- Michael Pyne
signat
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/47/
---
(Updated 2009-02-08 18:44:31.168430)
Review request for Plasma.
Summary
---
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/47/
---
Review request for Plasma.
Summary
---
Right now the icons on some web shortc
37 matches
Mail list logo