mpyne created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY Something I noticed while doing the musl libc fixes: 1. A GCC warning is generated for `in_devs`. It turns out the warning was referring to a Coverity entry (but the ID was wrong, it's 253228, not 3228), the Coverity entry noted that the `in_devs` code is dead code. And so it is. Whatever it was supposed to do before (warn about RAID entries using another RAID device as a sub-device?), it doesn't do it now --> removed. 2. A boolean check for whether the raid array was active or not was miscoded (and therefore was always true). The compiler warning for this was actually what led to me looking through this code, but Coverity also flagged it as well. From inspection, the check actually is necessary since the "level" data we're extracting here is only present if the array is active, so I fixed by removing the errorneous condition. TEST PLAN Builds fine on glibc and musl libc. However since I don't have a RAID array I have no good way of testing the change itself, though it should at least not break anything worse than it's already broken. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D6658 AFFECTED FILES ksysguardd/Linux/softraid.c To: mpyne, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
