harmathy added inline comments.
INLINE COMMENTS
> freetype-renderer.cpp:342-345
> +int result_r = ((255 - value_r) * backgound_r + value_r * pen_r)
> / 255;
> +int result_g = ((255 - value_g) * backgound_g + value_g * pen_g)
> / 255;
> +int result_b = ((255 -
harmathy updated this revision to Diff 47361.
harmathy added a comment.
fix some rendering issues, fix logical errors
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17493?vs=47298&id=47361
REVISION DETAIL
https://phabricator.kde.org/D17493
AFFECT
harmathy added a comment.
Thanks for the help.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D17493
To: harmathy
Cc: broulik, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
harmathy added a comment.
Please consider this work in progress. There are no reviewers. Is there
another way to mark this as "not ready"?
INLINE COMMENTS
> fonts.cpp:505
> engine()->addImageProvider("preview", new
> PreviewImageProvider(generalFont()));
> +engine()->addImageProvid
harmathy created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
harmathy requested review of this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D17493
AFFECTED FILES
CMakeLists.txt
kcms/fonts/CMakeLists.txt
harmathy added inline comments.
INLINE COMMENTS
> main.qml:221
> +QtControls.ToolTip {
> +text: i18n("Type of sub-pixel rendering to use. Choose a
> style that corresponds to the order of your display's pixel grid. For
> example, choose RGB hinting if your display t
harmathy added a comment.
Just to add another fact to the discussion:
The metric pt is an absolute measure for the size. In computing we use the
desktop publishing point which is 1/72 inch (see
https://en.wikipedia.org/wiki/Typographic_unit).
Therefore ideally 10 pt sized font should
