harmathy added inline comments.

INLINE COMMENTS

> main.qml:221
> +            QtControls.ToolTip {
> +                text: i18n("Type of sub-pixel rendering to use. Choose a 
> style that corresponds to the order of your display's pixel grid. For 
> example, choose RGB hinting  if your display that has the pixels ordered red, 
> green, blue (read left to right).")
> +                visible: parent.hovered

This is wrong. The hinting style option is independent from sub-pixel rendering.

There are five hinting algorithms in freetype:

- FT_LOAD_TARGET_NORMAL
- FT_LOAD_TARGET_LIGHT
- FT_LOAD_TARGET_MONO
- FT_LOAD_TARGET_LCD
- FT_LOAD_TARGET_LCD_V

But some of them only make sense in combination with other settings, e.g. 
FT_LOAD_TARGET_MONO would only be used when anti-aliasing is turned off and 
FT_LOAD_TARGET_LCD_V would imply that sub-pixel rendering is activated and you 
display is turned vertically (vrgb or vbgr).

The hintingstyle (as in fontconfig/Xft) would then be mapped to one of these 
hinting algorithms or turn off hinting at all.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13593

To: ngraham, #plasma, #vdg
Cc: harmathy, svenmauch, colomar, mart, davidedmundson, Fuchs, abetts, 
nicolasfella, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol

Reply via email to