Re: Review Request: Plasmate: Port QDialog to KDialog

> On Nov. 7, 2012, 12:33 a.m., Aleix Pol Gonzalez wrote: > > I'm unsure what's the reasoning behind, but isn't that exactly the opposite > > direction we want to go with KF5? +1 - Luis Gabriel --- This is an automatically generated e-m

Re: Review Request: Weather Forecast QML port

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106225/#review18663 --- Any updates here? - Luis Gabriel Lima On Aug. 30, 2012, 1

Re: Review Request: Weather Forecast QML port

sma-NotificationArea=true should be back in Ok, done. - Luis Gabriel --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106225/#review18267 -------

Re: Review Request: Pager QML port

, Luis Gabriel Lima ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Weather Forecast QML port

://git.reviewboard.kde.org/r/106225/s/698/ http://git.reviewboard.kde.org/r/106225/s/699/ http://git.reviewboard.kde.org/r/106225/s/700/ Thanks, Luis Gabriel Lima ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Weather Forecast QML port

> > color: theColour > > alpha: theAlpha > > > > merging them into a string, just for QML to split it again seems odd. > > Luis Gabriel Lima wrote: > There is no 'alpha' property in the Text element. Are you suggesting to > us

Re: Review Request: LCD Weather Station QML port

> On Aug. 29, 2012, 12:22 a.m., Luis Gabriel Lima wrote: > > applets/weatherstation/package/contents/ui/LCDDisplay.qml, line 74 > > <http://git.reviewboard.kde.org/r/106226/diff/1/?file=81359#file81359line74> > > > > I still think we should keep as

Re: Review Request: Pager QML port

> On Aug. 21, 2012, 5:15 p.m., Marco Martin wrote: > > found a small issue: when there is only one desktop, the pager should show > > nothing and be only few pixels wide (effectively "hidden") > > Marco Martin wrote: > what's the status on this? c

Re: Review Request: Weather Forecast QML port

line69> > > > > You don't need this. > > > > In your QML you can call plasmoid.openUrl() What I need to do to have this plasmoid object in the qml context? - Luis Gabriel --- This

Re: Review Request: LCD Weather Station QML port

<http://git.reviewboard.kde.org/r/106226/#comment14402> I still think we should keep as it is now to make the text color consistent with the lcd display color. Even if the theme changes, the lcd display will stay with the same color because it's an image. - Luis Gabriel Lima On Au

Re: Review Request: LCD Weather Station QML port

n-grayish-LCD-like-background, which > > is missing in the new plasmoid. IMHO the background should stay to keep the > > visual parity. > > Luis Gabriel Lima wrote: > The LCD background is still there as you can see in the first screenshot. > > Martin Klapetek wrote: &

Re: Review Request: LCD Weather Station QML port

://git.reviewboard.kde.org/r/106226/s/701/ No background http://git.reviewboard.kde.org/r/106226/s/702/ Thanks, Luis Gabriel Lima ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: LCD Weather Station QML port

iewboard.kde.org/r/106226/#review18088 --- On Aug. 26, 2012, 8:06 p.m., Luis Gabriel Lima wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request: LCD Weather Station QML port

s is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106226/#review18079 ----------- On Aug. 26, 2012, 8:06 p.m., Luis Gabriel Lima wrote: > > ---

Re: Review Request: Pager QML port

it.reviewboard.kde.org/r/106112/#review17812 ------- On Aug. 21, 2012, 2:33 a.m., Luis Gabriel Lima wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request: LCD Weather Station QML port

://git.reviewboard.kde.org/r/106226/s/701/ http://git.reviewboard.kde.org/r/106226/s/702/ Thanks, Luis Gabriel Lima ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: LCD Weather Station QML port

: http://git.reviewboard.kde.org/r/106226/diff/ Testing --- - Tested inside panels and floating on desktop - Tested with various providers and locations Thanks, Luis Gabriel Lima ___ Plasma-devel mailing list Plasma-devel@kde.org https

Review Request: Weather Forecast QML port

/ http://git.reviewboard.kde.org/r/106225/s/698/ http://git.reviewboard.kde.org/r/106225/s/699/ http://git.reviewboard.kde.org/r/106225/s/700/ Thanks, Luis Gabriel Lima ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Review Request: Pager QML port

, etc) Screenshots --- http://git.reviewboard.kde.org/r/106112/s/691/ http://git.reviewboard.kde.org/r/106112/s/692/ Thanks, Luis Gabriel Lima ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo

Review Request: Adding notify signals to FrameSvgItem

Gabriel Lima ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Adding notify signals to SvgItem

signals are being added in order to keep track of property changes in the QML side. Diffs - plasma/declarativeimports/core/svgitem.h 21dac70 plasma/declarativeimports/core/svgitem.cpp bb5494b Diff: http://git.reviewboard.kde.org/r/105072/diff/ Testing --- Thanks, Luis Gabriel