D28773: feat(kded): add getAutoRotate method and rename lockAutoRotate

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R104:67980bc2728d: feat(kded): add getAutoRotate method and rename lockAutoRotate (authored by z3ntu). REPOSITORY R104 KS

D28773: feat(kded): add getAutoRotate method and rename lockAutoRotate

z3ntu updated this revision to Diff 80393. z3ntu added a comment. - const auto REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28773?vs=79997&id=80393 BRANCH autorotate REVISION DETAIL https://phabricator.kde.org/D28773 AFFECTED FILES kded/config.cp

D28773: feat(kded): add getAutoRotate method and rename lockAutoRotate

z3ntu updated this revision to Diff 79997. z3ntu added a comment. - extract m_data->outputs() into a variable REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28773?vs=79995&id=79997 BRANCH autorotate REVISION DETAIL https://phabricator.kde.org/D28773

D28773: feat(kded): add getAutoRotate method and rename lockAutoRotate

z3ntu updated this revision to Diff 79995. z3ntu added a comment. - const function, std::all_of REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28773?vs=79930&id=79995 BRANCH autorotate REVISION DETAIL https://phabricator.kde.org/D28773 AFFECTED FILES

D28773: feat(kded): add getAutoRotate method and rename lockAutoRotate

z3ntu planned changes to this revision. z3ntu added inline comments. INLINE COMMENTS > nicolasfella wrote in config.cpp:99 > That sounds like a job for std::all_of I wasn't aware that C++ had such fancy methods :) I'm using equivalent functions a lot in Kotlin but they are honestly much nicer t

D28773: feat(kded): add getAutoRotate method and rename lockAutoRotate

z3ntu created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. z3ntu requested review of this revision. REVISION SUMMARY lockAutoRotate(true) would enable the automatic rotation and lockAutoRotate(false) would disable auto rotation which is the opposite

D27383: fix: reset doctor output color before exiting

z3ntu added a comment. > Merged by Carl Schwan 3 days ago https://invent.kde.org/websites/plasma-mobile-org/merge_requests/39 No I don't. REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D27383 To: z3ntu, davidedmundson Cc: cfeck, ro

D27383: fix: reset doctor output color before exiting

z3ntu added a comment. No I don't have commit rights. Luca Weiss l...@z3ntu.xyz (but isn't this information already as commit author?) REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D27383 To: z3ntu, davidedmundson Cc: roman

D27383: kscreen-doctor: reset color before exiting

z3ntu updated this revision to Diff 75643. z3ntu added a comment. Change commit message REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27383?vs=75638&id=75643 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27383 AFFECTED FILES s

D27383: kscreen-doctor: reset color before exiting

z3ntu added a comment. Of the four scopes (api, kwayland, qscreen & randr) I have no idea where to put this in. If you have a suggestion, I can update the commit message. REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D27383 To: z3ntu, david

D27383: kscreen-doctor: reset color before exiting

z3ntu created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. z3ntu requested review of this revision. REVISION SUMMARY Without this patch the blue from the "primary" output 'leaks' into the prompt of some shells (e.g. busybox ash). TEST PLAN Run "ksc

D27193: Improve the behaviour of the power button on mobile

z3ntu added a comment. > On Mobile, if the power button is pressed for short time, suspend to Ram as requested by Bhushan. Regarding this behavior, it will not always be desirable to do that, especially if user interaction is still happening, e.g. listening to music, having an active US

Re: Long press global shortcuts

On Freitag, 24. Jänner 2020 19:07:25 CET Aleix Pol wrote: > On Sun, Jan 12, 2020 at 6:11 PM Aleix Pol wrote: > > Hi, > > In a discussion some weeks ago, we came to the conclusion that it > > would make sense to support long press global shortcuts. > > > > The use-case we discussed back then was t

D10605: Fix location of Firefox dbCacheFile

z3ntu added a comment. No (this is one of my first patches 😄) REPOSITORY R120 Plasma Workspace BRANCH D10605 REVISION DETAIL https://phabricator.kde.org/D10605 To: z3ntu, mlaurent Cc: mlaurent, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10610: Fix favicons in firefox bookmarks runner

z3ntu marked 2 inline comments as done. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10610 To: z3ntu, #plasma, broulik Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10610: Fix favicons in firefox bookmarks runner

z3ntu marked an inline comment as done. z3ntu added a comment. Thanks :) > Presumably this means it'll break on < Firefox 58? It should work FF37+ where they switched to the new database schema. > It's weird that it crashes on a table missing. Is that a Qt bug we can file? I

D10610: Fix favicons in firefox bookmarks runner

z3ntu updated this revision to Diff 27421. z3ntu added a comment. - Add m_fetchsqlite_fav to teardown REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10610?vs=27415&id=27421 BRANCH D10610 REVISION DETAIL https://phabricator.kde.org/D10610 AFF

D10610: Fix favicons in firefox bookmarks runner

z3ntu updated this revision to Diff 27415. z3ntu added a comment. Do the same change as in D10605 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10610?vs=27409&id=27415 BRANCH D10610 REVISION DETAIL https:

D10605: Fix location of Firefox dbCacheFile

z3ntu marked an inline comment as done. z3ntu added a comment. @mlaurent Updated the patch. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10605 To: z3ntu, mlaurent Cc: mlaurent, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

D10605: Fix location of Firefox dbCacheFile

z3ntu updated this revision to Diff 27414. z3ntu added a comment. Put slash directly into the QStringLiteral REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10605?vs=27403&id=27414 BRANCH D10605 REVISION DETAIL https://phabricator.kde.org/D106

D10610: Fix favicons in firefox bookmarks runner

z3ntu added a comment. Two more notes: The logic for the path of the cache file (bookmarkrunnerfirefoxfavdbfile.sqlite) is like in D10605 . If this patch doesn't get merged into the next Plasma bugfix release, then `QList faviconFound = m_fetchsqlit

D10610: Fix favicons in firefox bookmarks runner

z3ntu created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. z3ntu requested review of this revision. REVISION SUMMARY The favicons are located in the file favicons.sqlite file since FF 37 and the old table was removed in

D10610: Fix favicons in firefox bookmarks runner

z3ntu edited the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10610 To: z3ntu Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10605: Fix location of Firefox dbCacheFile

z3ntu added a comment. I researched a bit more. The commit af0a29a185f190088af4a3a9d0d5bfb28a8feae3 caused this behaviour. A small test app results in: > Before: "/home/luca/.cache/bookmarkrunnerfirefoxdbfile.sql

D10605: Fix location of Firefox dbCacheFile

z3ntu created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. z3ntu requested review of this revision. REVISION SUMMARY Before: ~/.cache/krunnerbookmarkrunnerfirefoxdbfile.sqlite After: ~/.cache/krunner/bookmarkrunnerfiref

D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.

z3ntu added a comment. This patch works for me :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3829 To: xuetianweng, davidedmundson Cc: z3ntu, ngraham, knambiar, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

[kio-extras] [Bug 375249] "File not found" when trying to open file from nfs

https://bugs.kde.org/show_bug.cgi?id=375249 --- Comment #4 from Luca Weiss --- Created attachment 104327 --> https://bugs.kde.org/attachment.cgi?id=104327&action=edit Workaround patch, not a proposed patch! -- You are receiving this mail because: You are the assignee for the bug.

[kio-extras] [Bug 375249] "File not found" when trying to open file from nfs

https://bugs.kde.org/show_bug.cgi?id=375249 --- Comment #3 from Luca Weiss --- So after quite a bit of debugging I have found out that apparently the problem is that my NFS server has a share that's not available for my IP address (only for another one) and fhStatus.fhs_status (in nfsv