z3ntu created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. z3ntu requested review of this revision.
REVISION SUMMARY The favicons are located in the file favicons.sqlite file since FF 37 and the old table was removed in FF 41 resulting in crashes because the table wasn't found. - Update SQL to match the tables in FF 58 - query.bindValue() needs a double colon in the string, see https://doc.qt.io/qt-5/qsqlquery.html#prepare - Fix intendation (tab->spaces) in one line BUG: 363136 TEST PLAN Firefox bookmark favicons now work and don't crash Krunner and Kickoff REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D10610 AFFECTED FILES runners/bookmarks/browsers/firefox.cpp runners/bookmarks/browsers/firefox.h runners/bookmarks/faviconfromblob.cpp To: z3ntu Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
