D17016: Show menu bar, how to re-enable, common shortcut dialog

2018-11-19 Thread Luca Sartorelli
lsartorelli created this revision. lsartorelli added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. lsartorelli requested review of this revision. REVISION SUMMARY Usage example for D17013 and D17014

D15644: Provide option to hide menu bar for Ksysguard

2018-09-26 Thread Luca Sartorelli
lsartorelli updated this revision to Diff 42368. lsartorelli added a comment. little clean up CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15644?vs=42350&id=42368 REVISION DETAIL https://phabricator.kde.org/D15644 AFFECTED FILES gui/ksysguard.cpp gui/ksysguard.h To: lsarto

D15644: Provide option to hide menu bar for Ksysguard

2018-09-26 Thread Luca Sartorelli
lsartorelli updated this revision to Diff 42350. lsartorelli added a comment. Removed unused parameter in toggleShowMenuBar() CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15644?vs=42298&id=42350 REVISION DETAIL https://phabricator.kde.org/D15644 AFFECTED FILES gui/ksysguard.c

D15644: Provide option to hide menu bar for Ksysguard

2018-09-25 Thread Luca Sartorelli
lsartorelli added a comment. Thank you very much, I am so happy and proud for my first patch. Here my details: Name: Luca Surname: Sartorelli Mail: dj3...@gmail.com And here is the patch for gwenview: https://phabricator.kde.org/D15747 Just added you as reviewer 2 se

D15644: Provide option to hide menu bar for Ksysguard

2018-09-25 Thread Luca Sartorelli
lsartorelli updated this revision to Diff 42298. lsartorelli added a comment. Added remainder message box with keyboard shortcut, to have back the menu bar. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15644?vs=42101&id=42298 REVISION DETAIL https://phabricator.kde.org/D15644 A

D15644: Provide option to hide menu bar for Ksysguard

2018-09-22 Thread Luca Sartorelli
lsartorelli added a comment. Hi Nathaniel, thanks for all the support. I can understand and agree with your concerns. Not sure but maybe an option could be to add the hide menu bar entry in the setting menu via kxmlguiwindow and another entry to unhide it maybe can be putted in the contex

D15644: Provide option to hide menu bar for Ksysguard - Bug 395349

2018-09-21 Thread Luca Sartorelli
lsartorelli updated this revision to Diff 42101. lsartorelli retitled this revision from "Bug 395349" to "Provide option to hide menu bar for Ksysguard - Bug 395349". lsartorelli edited the summary of this revision. lsartorelli added a comment. Thank you, for all the feedback. Yes, I have

D15644: Bug 395349

2018-09-21 Thread Luca Sartorelli
lsartorelli updated this revision to Diff 42048. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15644?vs=42047&id=42048 REVISION DETAIL https://phabricator.kde.org/D15644 AFFECTED FILES gui/ksysguard.cpp To: lsartorelli Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mo

D15644: Bug 395349

2018-09-21 Thread Luca Sartorelli
lsartorelli created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. lsartorelli requested review of this revision. REVISION SUMMARY Provide option to hide menu bar for Ksysguard REPOSITORY R106 KSysguard BRANCH master REVISION DETAIL https://phabr

Re: Review Request 124647: Cmake fail to parse proper taglib version

2015-08-13 Thread Luca Sartorelli
Diff: https://git.reviewboard.kde.org/r/124647/diff/ Testing --- Run cmake with kdesrc-build on debian strecth taglib version correctly found and parsed and plasma-mediacenter succesfully build Thanks, Luca Sartorelli ___ Plasma-devel mailing list

Re: Review Request 124647: Cmake fail to parse proper taglib version

2015-08-13 Thread Luca Sartorelli
ted e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124647/#review83759 --- On Aug. 7, 2015, 9:01 a.m., Luca Sartorelli wrote: > > --- > This is an automatically gen

Re: Review Request 124684: Cmake fail to parse proper taglib version - kdelibs4support

2015-08-10 Thread Luca Sartorelli
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124684/#review83646 --- On Aug. 10, 2015, 9:39 a.m., Luca Sartorelli wrote: > > ---

Re: Review Request 124682: Cmake fail to parse proper taglib version - extra-cmake-modules

2015-08-10 Thread Luca Sartorelli
found and parsed Thanks, Luca Sartorelli ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 124684: Cmake fail to parse proper taglib version - kdelibs4support

2015-08-10 Thread Luca Sartorelli
--- Wrong string comparison of taglib version Diffs - cmake/modules/FindTaglib.cmake 5bbb8ee Diff: https://git.reviewboard.kde.org/r/124684/diff/ Testing --- Run cmake with kdesrc-build on debian strecth taglib version correctly found and parsed Thanks, Luca Sartorelli

Review Request 124682: Cmake fail to parse proper taglib version - extra-cmake-modules

2015-08-10 Thread Luca Sartorelli
--- Wrong string compare of taglib version Diffs - attic/modules/FindTaglib.cmake 5bbb8ee Diff: https://git.reviewboard.kde.org/r/124682/diff/ Testing --- Run cmake with kdesrc-build on debian strecth taglib version correctly found and parsed Thanks, Luca Sartorelli

Re: Review Request 124647: Cmake fail to parse proper taglib version

2015-08-07 Thread Luca Sartorelli
/FindTaglib.cmake c23d582 Diff: https://git.reviewboard.kde.org/r/124647/diff/ Testing --- Run cmake with kdesrc-build on debian strecth taglib version correctly found and parsed and plasma-mediacenter succesfully build Thanks, Luca Sartorelli ___ Plasma

Re: Review Request 124647: Cmake fail to parse proper taglib version

2015-08-07 Thread Luca Sartorelli
n't know about it - Luca --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124647/#review83511 --- On Aug. 6, 2015

Review Request 124647: Cmake fail to parse proper taglib version

2015-08-06 Thread Luca Sartorelli
Thanks, Luca Sartorelli ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel