> On Aug. 6, 2015, 8:29 p.m., Rex Dieter wrote: > > Wouldn't it be better to use VERSION_GREATER > > (http://www.cmake.org/cmake/help/v3.0/command/if.html) rather than a string > > compare?
That is great!, thank you for the smart suggestion, I didn't know about it - Luca ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124647/#review83511 ----------------------------------------------------------- On Aug. 6, 2015, 4 p.m., Luca Sartorelli wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124647/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2015, 4 p.m.) > > > Review request for Plasma. > > > Repository: plasma-mediacenter > > > Description > ------- > > taglib 1.4 is requested to build plasma-mediacenter > but taglib 1.10.0 shipped by kde git was parsed as version 1.1 causing the > test failure > > > Diffs > ----- > > cmake/FindTaglib.cmake c23d582 > > Diff: https://git.reviewboard.kde.org/r/124647/diff/ > > > Testing > ------- > > Run cmake with kdesrc-build on debian strecth > taglib version correctly found and parsed > and plasma-mediacenter succesfully build > > > File Attachments > ---------------- > > MacroEnsureVersion.cmake > > https://git.reviewboard.kde.org/media/uploaded/files/2015/08/06/3d08277e-1803-4922-a61d-1c072beb7e35__MacroEnsureVersion.cmake > > > Thanks, > > Luca Sartorelli > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
