This revision was automatically updated to reflect the committed changes.
Closed by commit R102:e38d60fb23f7: kcm_opengl: Fix retrieval of DRI
information (authored by roberts).
REPOSITORY
R102 KInfoCenter
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D12476?vs=33565&id=33701
REVISI
roberts added a comment.
It will fail gracefully, it checks for the presence of these /proc or /sys
files and only acts if they exist. This code is only called if an EGL context
is successfully created in any case, and in fact on Wayland rendering _is_
always direct.
REPOSITORY
R102 KInfo
roberts updated this revision to Diff 33565.
roberts added a comment.
Update to set IsDirect under Wayland.
Managed to run kwin_wayland embedded in an X11 session to confirm.
REPOSITORY
R102 KInfoCenter
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D12476?vs=32999&id=33565
B
roberts marked an inline comment as done.
roberts added a comment.
Alexey: That sounds great, but unfortunately I can't get a wayland session to
log in no matter how hard I try, so I can't confirm your changes. I'd suggest
creating a separate review with your additions if you want to pursue t
roberts marked an inline comment as done.
roberts added inline comments.
INLINE COMMENTS
> wbauer wrote in opengl.cpp:211
> Using just "/driver" (instead of "/driver/module") makes it display "radeon"
> instead of "drm" here as I would expect.
>
> OTOH, as it already runs lspci to get the other
roberts updated this revision to Diff 32999.
roberts added a comment.
Update to use /driver over /driver/module per review.
REPOSITORY
R102 KInfoCenter
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D12476?vs=32904&id=32999
BRANCH
kcm_opengl_fix_dri_info
REVISION DETAIL
https
roberts created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
roberts requested review of this revision.
REPOSITORY
R102 KInfoCenter
BRANCH
kcm_opengl_fix_dri_info
REVISION DETAIL
https://phabricator.kde.org/D12499
roberts created this revision.
roberts added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
roberts requested review of this revision.
REVISION SUMMARY
Currently DRI information retrieval is attempted via /proc/dri, wh
This revision was automatically updated to reflect the committed changes.
Closed by commit R102:f4af6581d03e: kcm_opengl: Fix EGL info retrieval.
(authored by roberts).
REPOSITORY
R102 KInfoCenter
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D12455?vs=32837&id=32903
REVISION DETAIL
roberts created this revision.
roberts added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
roberts requested review of this revision.
REVISION SUMMARY
Under certain contexts (tested with Mesa 18.0.1 + AMDGPU) eglMakeC
On 30 December 2016 at 15:26, Marco Martin wrote:
> the patch you mean is https://phabricator.kde.org/D2986 ?
>
> I think it makes sense to backpport..
> also, to me backporting to 5.8 is kindof special, becuase of its lts status.
> maybe something i would not consider fto backport for a normal r
Have been in discussion about backporting a bug fix -
https://bugs.kde.org/show_bug.cgi?id=356479 to 5.8.
The only documentation I could find on backport policy was
https://community.kde.org/Policies/Commit_Policy#Backport_bugfixes - which
is roughly as the URI implies: "backport bugfixes."
This
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE8dbda77a3b8a: systemmonitor: Optimise source
updates. (authored by roberts).
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3141?vs=
roberts added reviewers: Plasma, apol.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D3141
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: roberts, #plasma, apol
Cc: plasma-devel, lesliezhai, ali-mohamed, jensre
roberts created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Profiling indicates the highest CPU usage process during idle is the
system monitor engine. This attempts to get rid of the most obvious
us
roberts accepted this revision.
roberts added a reviewer: roberts.
roberts added a comment.
This revision is now accepted and ready to land.
Looks good to me now.
REPOSITORY
rKWAYLAND KWayland
BRANCH
plasma-window-icon
REVISION DETAIL
https://phabricator.kde.org/D3049
EMAIL PREFERENCE
roberts added inline comments.
INLINE COMMENTS
> plasmawindowmanagement.cpp:489
> +n = QT_READ(fd, buf, sizeof buf);
> +if (n == -1 && (errno == EAGAIN) && ++retryCount < 1000) {
> +usleep(1000);
EAGAIN comes from reads of O_NONBLOCK fd's, but this seems to be a block
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE749f60b89f4a: Systray: Move all icon
resolution to dataengine (authored by roberts).
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D
roberts updated this revision to Diff 7230.
roberts added a comment.
Recreated diff with arc.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2986?vs=7215&id=7230
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D2986
AFF
roberts updated this revision to Diff 7215.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2986?vs=7214&id=7215
REVISION DETAIL
https://phabricator.kde.org/D2986
AFFECTED FILES
applets/systemtray/package/contents/ui/ConfigEntries.qml
roberts created this revision.
roberts added reviewers: mart, Plasma.
roberts set the repository for this revision to rPLASMAWORKSPACE Plasma
Workspace.
roberts added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Changes triggered by investigation
https://bugs.kde.org/show_bug.cgi?id=348082
Lindsay Roberts changed:
What|Removed |Added
CC||lind...@gmail.com
--- Comment #3 from
> On 2010-11-09 18:37:25, Aaron Seigo wrote:
> >
>
> Lindsay Roberts wrote:
> If there are no objections could I request that someone check this in?
>
> Markus Slopianka wrote:
> Does it change the behavior described in
> https://bugs.kde.org/show_bug.c
rg/r/5805/#review8589
---
On 2010-11-09 11:50:55, Lindsay Roberts wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://svn.revie
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5805/
---
Review request for Plasma.
Summary
---
The folder view employs a 'press
25 matches
Mail list logo
