Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

2017-07-29 Thread Jiri Bohac
marked as submitted. Review request for Plasma and Albert Astals Cid. Changes --- Submitted with commit 5668ff05ad8cfc027bbd9fe7692fc2be518649c6 by Albert Astals Cid on behalf of Jiri Bohac to branch master. Repository: plasma-workspace Description --- Update the list of country

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

2016-12-27 Thread Jiri Bohac
sed here, not the > > Portuguese (?) one. > > Jiri Bohac wrote: > Frankly, I don't understand what all the discussion here is about. > I noticed the list of countries, obviously taken from iso-codes some day > in the past, was out of date. > The co

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

2016-12-27 Thread Jiri Bohac
29691/diff/ Testing --- Thanks, Jiri Bohac

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

2016-12-27 Thread Jiri Bohac
use any subset of my changes, feel free to do that. I totally don't understand any reasoning behind that, though. - Jiri --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r

Re: Review Request 129691: digital-clock: Update iso-3166 codes in timezones

2016-12-20 Thread Jiri Bohac
o it should be used just as the others'. - Jiri --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129691/#review101522 ----

Review Request 129691: digital-clock: Update iso-3166 codes in timezones

2016-12-20 Thread Jiri Bohac
enough: country names are hardcoded in many places and they need to be fixed separately. Diffs - applets/digital-clock/plugin/timezonesi18n.cpp 10650f8 Diff: https://git.reviewboard.kde.org/r/129691/diff/ Testing --- Thanks, Jiri Bohac