Re: Review Request 119799: New activities linking file item plugin

2014-08-15 Thread Frank Reininghaus
after the menu is hovered" approach is good, and the implementation looks fine to me. I went through the code and have not found any possible problems so far. So unless anyone else sees a problem, I would say go ahead and ship it! Thanks for your work on this. - Frank Reininghaus On Aug

Re: Review Request 118840: kde-baseapps frameworks dolphin with snapshot frameworks branch baloo/baloo-widgets path fixes.

2014-06-19 Thread Frank Reininghaus
x27; group, which you should use for future review requests. This is much better than adding myself to the 'People' field because more people will notice your patches then and may be able to provide useful feedback. - Frank Reininghaus On June 19, 2014, 3:26 p.m.,

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-07 Thread Frank Reininghaus
> On March 7, 2014, 3:23 p.m., Frank Reininghaus wrote: > > We have had a complaint from a Dolphin user who uses the Oxygen font some > > time ago because it uses different widths for the digits 0-9, which makes > > the "Date" column in file managers/dialogs rath

Re: Review Request 116633: Change default font settings to Oxygen font

2014-03-07 Thread Frank Reininghaus
e the same width for all ten digits to prevent this effect. I can't say much about this issue myself because I'm not familiar with font design, but maybe this problem should be taken into account. - Frank Reininghaus On March 6, 2014, 4:36 p.m., Se

Unintended changes at community.kde.org?

2013-08-05 Thread Frank Reininghaus
Hi everyone, (please CC me in any replies, I'm not subscribed) I recently had a look at the Dolphin pages at community.kde.org. We don't actually use them much - Peter and I mostly used http://community.kde.org/Dolphin/Dolphin-2.0-Status to list the things that still needed to be done for the new

Re: Review Request 110684: Do not show the "File to activity linking plugin" in context menus by default

2013-05-28 Thread Frank Reininghaus
rg/show_bug.cgi?id=314575 Diffs - src/workspace/fileitemplugin/FileItemLinkingPlugin.cpp 82cb8db Diff: http://git.reviewboard.kde.org/r/110684/diff/ Testing --- Thanks, Frank Reininghaus ___ Plasma-devel mailing list Plasma-devel@kde

Review Request 110684: Do not show the "File to activity linking plugin" in context menus by default

2013-05-27 Thread Frank Reininghaus
ngPlugin.cpp 82cb8db Diff: http://git.reviewboard.kde.org/r/110684/diff/ Testing --- Thanks, Frank Reininghaus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 109995: Tint selected icons in Folder View by highlight color (as Dolphin 2.0)

2013-04-15 Thread Frank Reininghaus
> On April 15, 2013, 7:32 a.m., Aaron J. Seigo wrote: > > Ship It! > > Frank Reininghaus wrote: > Just for the record, there is another request about this issue: > https://git.reviewboard.kde.org/r/109997/. See the discussion there for more > info. > >

Re: Review Request 109995: Tint selected icons in Folder View by highlight color (as Dolphin 2.0)

2013-04-15 Thread Frank Reininghaus
> On April 15, 2013, 7:32 a.m., Aaron J. Seigo wrote: > > Ship It! Just for the record, there is another request about this issue: https://git.reviewboard.kde.org/r/109997/. See the discussion there for more info. I think that the tinting is a very bad solution to highlight files, and I think

Re: Git policy for kde-baseapps?

2012-09-27 Thread Frank Reininghaus
Hi Ben, 2012/9/27 Ben Cooksley: [...] >>> Well, I found an answer to my own question at [1]. Basically, it says doing >>> a rebase of the branch with the master and merging afterwards will prevent >>> the duplicate log message: >>> >>> $ git co -b 4.9 origin/KDE/4.9 >>> $ git co -b master origin/m

Re: Git policy for kde-baseapps?

2012-09-27 Thread Frank Reininghaus
Hi, 2012/9/26 Dawit A: [...] >> > How can that be resolved or do we live with the duplicate log entries ? >> >> I don't know how to avoid a duplicate entry in that case. But given >> the big mess of duplicate entries that we had in the past every time >> someone decided to merge, I think that a si

Re: Git policy for kde-baseapps?

2012-09-26 Thread Frank Reininghaus
Hi Dawit, 2012/9/26 Dawit A: > I still do not see how this can work cleanly. People commit changes in > master and then backport them to the 4.9 branch. Which BTW was by far the > most common workflow before the switch over to git. As an example if you > attempt to 'merge' kde-baseapps 4.9 branch

Re: Git policy for kde-baseapps?

2012-09-25 Thread Frank Reininghaus
Hi, 2012/9/20 Luca Beltrame: > In data giovedì 20 settembre 2012 09:53:53, Daniel Kreuter ha scritto: > >> is already in the KDE 4.9 branch. Maybe we can regularly merge the >> latest stable branch into the master or next version branch, f.e. once >> a week? I'm not sure merging if once a week is

Git policy for kde-baseapps?

2012-09-13 Thread Frank Reininghaus
Hi everyone, (sending to kfm-devel and plasma-devel because I think that the vast majority of bug fix commits in kde-baseapps is due to FolderView, Konqueror, and Dolphin) as far as I know, we never discussed (or even agreed on) a common policy for the usage of git in kde-baseapps, in particular

Re: Review Request: Dolphin reports open locations to the activity manager

2012-08-14 Thread Frank Reininghaus
> > (Updated Aug. 11, 2012, 10:27 a.m.) > > > Review request for Dolphin, KDE Base Apps, Plasma, and Frank Reininghaus. > > > Description > --- > > Dolphin reports open locations to the activity manager (KAMD). > > Reasoning behind

Re: Review Request: Dolphin reports open locations to the activity manager

2012-08-12 Thread Frank Reininghaus
istent history of visited folders. But maybe I'm too conservative here, I don't know. Can you provide some information about other info that the activity manager stores without the user's knowledge? Is there a way to disable the logging, and can the user clear the collected dat