----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119799/#review64589 -----------------------------------------------------------
Ship it! Thanks Ivan! The "load actions asynchronously after the menu is hovered" approach is good, and the implementation looks fine to me. I went through the code and have not found any possible problems so far. So unless anyone else sees a problem, I would say go ahead and ship it! Thanks for your work on this. - Frank Reininghaus On Aug. 15, 2014, 8:42 a.m., Ivan Čukić wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119799/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2014, 8:42 a.m.) > > > Review request for Dolphin, Plasma and Frank Reininghaus. > > > Repository: kactivities > > > Description > ------- > > New version of the file item plugin for the post nepomuk era and kf5. > > The behaviour is changed compared to the previous one: > - At first, it shows a submenu (named 'Activities') that contains the > 'Loading...' text > - When the popup is requested to be shown (hovered signal of the root action) > it asynchronously loads the sub-actions. > > It is much faster than the nepomuk-based one, and it does not display the > 'Loading...' item to the user at all. > > > Diffs > ----- > > src/workspace/CMakeLists.txt bd4e636 > src/workspace/fileitemplugin/CMakeLists.txt d835aec > src/workspace/fileitemplugin/FileItemLinkingPlugin.h ef7ad3b > src/workspace/fileitemplugin/FileItemLinkingPlugin.cpp 5bcc141 > src/workspace/fileitemplugin/FileItemLinkingPlugin_p.h 6fb9b13 > > Diff: https://git.reviewboard.kde.org/r/119799/diff/ > > > Testing > ------- > > Tested also with artificial slowing down with sleeps. > Tested also when the activity manager is not running. > > > Thanks, > > Ivan Čukić > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
