Re: Review Request 122392: Fix Klipper Performance issues

2017-02-08 Thread Filip Wieladek
ing --- File Attachments A screencast with foreground processing vs background processing https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/1d998fd9-57fd-4997-92f8-11b8e038e795__screencast.mp4 Thanks, Filip Wieladek

Re: Review Request 122382: [klipper] Sync history to disk after each change

2015-02-16 Thread Filip Wieladek
to the X11 > Display and just do a passive keyboard grab. So caring about that probably > doesn't matter (on Wayland this might get more important - maybe we can skip > passwords). But setting the file to 600 is certainly a good idea. > > Martin Gräßlin wrote: > >

Re: Review Request 122392: Fix Klipper Performance issues

2015-02-09 Thread Filip Wieladek
y, while the threaded > > filtering is the part which needs most thought, so having that in a > > dedicated review would certainly help :-) > > Filip Wieladek wrote: > Yes, I can do that once I get home. If you really believe that the popup > is going away anyway, then I wo

Re: Review Request 122382: [klipper] Sync history to disk after each change

2015-02-09 Thread Filip Wieladek
> On Feb. 3, 2015, 7:36 a.m., Martin Gräßlin wrote: > > David E. just pointed out that this could become quite heavy for the system > > as the history size can be large (up to 2048 items). > > Martin Gräßlin wrote: > Unfortunately I couldn't find out why we support up to 2048 items. Commit

Re: Review Request 122392: Fix Klipper Performance issues

2015-02-08 Thread Filip Wieladek
y, while the threaded > > filtering is the part which needs most thought, so having that in a > > dedicated review would certainly help :-) > > Filip Wieladek wrote: > Yes, I can do that once I get home. If you really believe that the popup > is going away anyway, then I wo

Re: Review Request 122392: Fix Klipper Performance issues

2015-02-08 Thread Filip Wieladek
--- A screencast with foreground processing vs background processing https://git.reviewboard.kde.org/media/uploaded/files/2015/02/08/1d998fd9-57fd-4997-92f8-11b8e038e795__screencast.mp4 Thanks, Filip Wieladek ___ Plasma-devel mailing l

Re: Review Request 122392: Fix Klipper Performance issues

2015-02-02 Thread Filip Wieladek
so that the "legacy" way can be removed. - Filip --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122392/#review75260 -------

Re: Review Request 122392: Fix Klipper Performance issues

2015-02-02 Thread Filip Wieladek
antly (I need to focus my eyes somewhere else, making a "context switch") - Filip --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122392/#review75255 ---

Re: Review Request 122392: Fix Klipper Performance issues

2015-02-02 Thread Filip Wieladek
sit: https://git.reviewboard.kde.org/r/122392/#review75255 --- On Feb. 3, 2015, 6:27 a.m., Filip Wieladek wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 122392: Fix Klipper Performance issues

2015-02-02 Thread Filip Wieladek
lter.h PRE-CREATION klipper/historyfilter.cpp PRE-CREATION klipper/klipperpopup.h 6f7b30747562b5e7227504b8c53be2863686072b klipper/klipperpopup.cpp 0b2f11d6d6d95e96ece0ac7b386fae2492ad0efd Diff: https://git.reviewboard.kde.org/r/122392/diff/ Testing ---

Review Request 122392: Fix the infinite event recursion in the klipper popup. See Bug 342947

2015-02-02 Thread Filip Wieladek
06dd0135ca573aea0819e2788b852 klipper/historyfilter.h PRE-CREATION klipper/historyfilter.cpp PRE-CREATION klipper/klipperpopup.h 6f7b30747562b5e7227504b8c53be2863686072b klipper/klipperpopup.cpp 0b2f11d6d6d95e96ece0ac7b386fae2492ad0efd Diff: https://git.reviewboard.kde.org/r/122392/diff/ T

Re: Review Request 122392: Fix Klipper Performance issues

2015-02-02 Thread Filip Wieladek
ewboard.kde.org/r/122392/diff/ Testing --- Thanks, Filip Wieladek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122106: Fix the infinite event recursion in the klipper popup. See Bug 342947

2015-01-17 Thread Filip Wieladek
klipper/klipperpopup.cpp 56c6421b33dd5a28b3a5b5eef54147acaee6dfbc Diff: https://git.reviewboard.kde.org/r/122106/diff/ Testing --- Thanks, Filip Wieladek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 122106: Fix the infinite event recursion in the klipper popup. See Bug 342947

2015-01-17 Thread Filip Wieladek
56c6421b33dd5a28b3a5b5eef54147acaee6dfbc Diff: https://git.reviewboard.kde.org/r/122106/diff/ Testing --- Thanks, Filip Wieladek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122106: Fix the infinite event recursion in the klipper popup. See Bug 342947

2015-01-17 Thread Filip Wieladek
56c6421b33dd5a28b3a5b5eef54147acaee6dfbc Diff: https://git.reviewboard.kde.org/r/122106/diff/ Testing --- Thanks, Filip Wieladek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122106: Fix the infinite event recursion in the klipper popup. See Bug 342947

2015-01-17 Thread Filip Wieladek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122106/#review74174 --- On Jan. 17, 2015, noon, Filip Wieladek wrote: > > --

Review Request 122106: Fix the infinite event recursion in the klipper popup. See Bug 342947

2015-01-17 Thread Filip Wieladek
--- Thanks, Filip Wieladek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel