----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122106/ -----------------------------------------------------------
(Updated Jan. 17, 2015, 1:29 p.m.) Review request for Plasma. Repository: plasma-workspace Description (updated) ------- Fix the infinite event recursion in the klipper popup. See Bug 342947 Klipper crashes when any modifier key (with the exception of ALT) is pressed. This is because it enters into an infinite recursion. This happens because Klipper popup delegates all events to its input field. The input field does not consume the event, so it is propagated to the parent widget, which is the popup. The popup tries to send the event to the input field again. Reproducible: Always Steps to Reproduce: 1. Open the Klipper popup (Using the shortcut) 2. Press Shift Actual Results: Klipper crashes Expected Results: Klipper does not crash. Since klipper is now part of plasma, this bug kills the entire shell Diffs ----- klipper/klipperpopup.h 4e03714fba1e7f16868a6d3c40f43528e055f860 klipper/klipperpopup.cpp 56c6421b33dd5a28b3a5b5eef54147acaee6dfbc Diff: https://git.reviewboard.kde.org/r/122106/diff/ Testing ------- Thanks, Filip Wieladek
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
