D23257: Allow for easier syncing of Plasma font

filipf added inline comments. INLINE COMMENTS > davidre wrote in sddmkcm.cpp:243 > Should I remove this then? Unfortunately not yet because we still need the `kdeglobals` file for color schemes. From my previous testing it's not enough to just copy some line `colorScheme=Adwaita`, we actually

D23257: Allow for easier syncing of Plasma font

filipf added a comment. In D23257#677396 , @davidre wrote: > I rebased it because of the rewrite that happened, can you check if everything is still ok @filipf LGTM. Instead of copying the user's entire `kdeglobals` file (which could als

D23257: Allow for easier syncing of Plasma font

filipf added a comment. I think it should work same as when I submitted the patch. It would be good to add a comment though that this feature is only supported for for SDDM 0.19 and above. In D23257#514708 , @filipf wrote: > In D23257#51461

D29741: [Logout] Port to QQC2 and PC3

filipf abandoned this revision. filipf added a comment. https://invent.kde.org/plasma/plasma-workspace/commit/21bdc2a89d123932af2a1b04bd8e98ff868bf3eb REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29741 To: filipf, #plasma, davidedmundson, ngraham Cc: pla

Re: Sprint notes: how to improve getting new contributors

One thing I think is worth mentioning is that the KDE Store is not utilized at all as a hub for recruiting new contributors. There's some talented and competent people there but I haven't really seen the community reach out to them. On Mon, Jun 15, 2020 at 10:02 AM Bhushan Shah wrote: > Note th

D28154: Add users KCM

filipf added a comment. In D28154#672453 , @ngraham wrote: > Now that D29394 has landed, you can add those images here! . REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.or

D29765: Add a blurless SDDM theme

filipf abandoned this revision. filipf added a comment. Yeah on second thought this is ugly from a maintenance POV. We'd need a GUI sheet that exposes theme.conf and then blur would be one option. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29765 To: fi

D29765: Add a blurless SDDM theme

filipf added a comment. In D29765#671401 , @broulik wrote: > Can we perhaps add infrastructure so that a theme can provide options? > For instance, the look and feel package can add options to the lock screen KCM which we use for e.g. "always

D29765: Add a blurless SDDM theme

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This patch adds a blurless SDDM Breeze theme. The non-default theme is added in order to accomodate users who wish to have their

D29741: [Logout] Port to QQC2 and PC3

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY The logout screen is ported to QtQuick Controls 2 and Plasma Components 3. See D29740 for a

D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout

This revision was automatically updated to reflect the committed changes. Closed by commit R120:68601675d13b: [sddm-theme] Prevent the logo from leaking in after a fadeout (authored by filipf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29351?vs=8

D29394: Add photographic user avatars

This revision was automatically updated to reflect the committed changes. Closed by commit R128:13e73011b1ac: Add photographic user avatars (authored by filipf). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29394?vs=82748&id=82762 REVISION DETAIL htt

D29394: Add photographic user avatars

filipf updated this revision to Diff 82748. filipf added a comment. don't delete user_manager.kdev4 REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29394?vs=82746&id=82748 BRANCH add-photo-avatars (branched from master) REVISION DETAIL https://pha

D29394: Add photographic user avatars

filipf updated this revision to Diff 82746. filipf added a comment. Make as REUSE compliant as possible REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29394?vs=82732&id=82746 BRANCH add-photo-avatars (branched from master) REVISION DETAIL https:/

D29394: Add photographic user avatars

filipf added a comment. In D29394#670076 , @ngraham wrote: > The .license files could live in another folder. Maybe `src/pics_sources`? Yeah I can do that as well REPOSITORY R128 User Manager BRANCH add-photo-avatars (branched from m

D29394: Add photographic user avatars

filipf added a comment. In D29394#670030 , @jriddell wrote: > Looks good for licence freedom > > Could you make the licence info in format specified at https://reuse.software/tutorial/ ? It's what we want to use from now on in KDE. > > S

D29394: Add photographic user avatars

filipf updated this revision to Diff 82732. filipf added a comment. rework licensing stucture due to a flaw in user_manager (it shows every single file in the avatar gallery and the .license files break it) REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.or

D29394: Add photographic user avatars

filipf updated this revision to Diff 82697. filipf added a comment. Use this format https://reuse.software/tutorial/ making a LICENCE/ directory with the licence text in it and cat.jpg.license with the SPDX header REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator

D29394: Add photographic user avatars

filipf updated this revision to Diff 82694. filipf added a comment. actually remove Chip and Gecko(due to rename) REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29394?vs=82693&id=82694 BRANCH add-photo-avatars (branched from master) REVISION DETAIL

D29394: Add photographic user avatars

filipf updated this revision to Diff 82693. filipf added a comment. - rename Gecko to Chameleon because that wasn't a gecko - remove Chip - add Air Balloon, Dog, Fish, Owl, Pencils, Sushi - WIP: licence files REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator

D29689: Port "sorry, nothing found" message to Kirigami.PlaceholderMessage

filipf accepted this revision. filipf added a comment. Works well and looks good. REPOSITORY R134 Discover Software Store BRANCH port-to-placeholdermessage (branched from master) REVISION DETAIL https://phabricator.kde.org/D29689 To: ngraham, apol, #discover_software_store, #vdg, fili

D29689: Port "sorry, nothing found" message to Kirigami.PlaceholderMessage

filipf accepted this revision. filipf added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ApplicationsListPage.qml:152 > + > +visible: opacity != 0 > +opacity: apps.count == 0 && !appsModel.isBusy ? 1 : 0 Should work without this, no?

D29394: Add photographic user avatars

filipf added a comment. Some pictures I didn't include in case people like them: F8313250: image.png F8313256: image.png (yes the Leopard is nice but the circular cropping eats too much into it) With the

D29394: Add photographic user avatars

filipf updated this revision to Diff 82662. filipf added a comment. - Remove all Unsplash and Pexels licensed photos to avoid complications. - Use CC0 pictures from Pexels instead - Licence files to be added REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kd

D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout

filipf added a comment. Is this okay now @mart and okay to land on 5.18? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29351 To: filipf, ngraham, cblack, #plasma, mart Cc: mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, f

D29394: Add photographic user avatars

filipf added a comment. IANAL but the Pexels and Unsplash licence look the same to me: free to distribute, free to modify, no attribution needed, but don't use it to make a Pexels/Unsplash clone. Someone once noted that neither exists in some FOSS licence database. I'll just ask everyone to

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

filipf added a comment. If user data would show low vertical panel usage, what are we really fixing and for who? Extrapolating from that and presuming that a fair share of them are content with the current default, why do we go against that? And if it's just a matter of not touching defaults

D29394: Add photographic user avatars

filipf added a comment. After additional consideration, I'm not too happy with the car avatar but I did find this: F8292121: Screenshot_20200507_090804.png Speaking of licences, I assume I can leave the CC0 ones at CC0, while the rest should b

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

filipf added a comment. I'd also be interested if #kde_promo has any insights here. It doesn't seem (?) like we advertise it too much, but I know reviews often praise Plasma for its familiarity for Windows users. Given our major competitor does th

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

filipf requested changes to this revision. filipf added a comment. This revision now requires changes to proceed. This is a major identity change better suited for Plasma 6. We've never had a vertical panel and are moreover defined by offering a layout familiar to Windows users. Switchin

D29448: Add "Volna" wallpaper

filipf requested changes to this revision. filipf added a comment. This revision now requires changes to proceed. We only use the biggest size in this repo. REPOSITORY R131 Plasma Wallpapers REVISION DETAIL https://phabricator.kde.org/D29448 To: ngraham, #vdg, #plasma, filipf Cc: filipf,

D29366: [Wallpaper Configuration] Reword inline message concerning widget locking

This revision was automatically updated to reflect the committed changes. Closed by commit R119:52d3389f7495: [Wallpaper Configuration] Reword inline message concerning widget locking (authored by filipf). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout

filipf added a comment. Should I also land this for 5.18 (do I have to create a bug report first)? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29351 To: filipf, ngraham, cblack, #plasma, mart Cc: mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cb

D29394: Add photographic user avatars

filipf updated this revision to Diff 81955. filipf added a comment. Drop: - Air Balloon - Gamepad Add: - Architecture - Food - Chalk Change: - Embiggen the leopard REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29394?vs=8

D29394: Add photographic user avatars

filipf added a comment. In D29394#663012 , @ngraham wrote: > Great, that works. I suppose there's no point in fixing that bug since this KCM is being re-done anyway in D28154 . Once this lands, @cblack can gra

D29366: [Wallpaper Configuration] Remove obsolete inline message concerning widget locking

filipf updated this revision to Diff 81911. filipf added a comment. restore the inline message but change its text to note that layout changes have been restricted by the sysadmin REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29366?vs=81756&id=8191

D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout

filipf updated this revision to Diff 81910. filipf marked an inline comment as done. filipf added a comment. Replace PropertyAnimation with NumberAnimation REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29351?vs=81709&id=81910 BRANCH no-logo-lea

D29394: Add photographic user avatars

filipf added a comment. In D29394#662776 , @ognarb wrote: > Photo using the Unsplash license can't be included in our repositories. The license is not considered open-source :( We should contact the artists if they are willing to license their p

D29394: Add photographic user avatars

filipf updated this revision to Diff 81839. filipf added a comment. probably don't want to include the .directory file REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29394?vs=81838&id=81839 BRANCH add-photo-avatars (branched from master) REVISION D

D29394: Add photographic user avatars

filipf updated this revision to Diff 81838. filipf added a comment. Better file naming REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29394?vs=81829&id=81838 BRANCH add-photo-avatars (branched from master) REVISION DETAIL https://phabricator.kde.

D29394: Add photographic user avatars

filipf added a comment. Alright, I believe the issue is with the fact that the avatar gallery is coded to always look for avatars in the system `/usr/share` dir as opposed to adjusting to testing conditions and using the local `/usr/share` dir. `sudo cp -r kde/usr/share/user-manager/avat

D29394: Add photographic user avatars

filipf added a comment. The permissions are wrong if we do `sudo make install` (the photos folder ends up being root owned). But it doesn't show up with `make install` either. Will investigate more in the morning. REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/

D29394: Add photographic user avatars

filipf created this revision. filipf added reviewers: VDG, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This patch adds 12 photographic avatars in order to finish work on T9910

D29394: Add photographic user avatars

filipf added a comment. Sources: Basketball: https://www.pexels.com/photo/basketball-net-2169302/ (Pexels licence) Brushes: https://www.pexels.com/photo/abstract-art-artist-artistic-262034/ (CC0 licence) Car: https://www.pexels.com/photo/action-asphalt-auto-racing-automobile-274974

D22700: Sync scaling DPI from Plasma to SDDM

filipf added a comment. In D22700#662134 , @guoyunhe wrote: > When I press the synchronize button, it looks like the `-dpi 144` (scale x1.5) option makes the UI elements huge (feel like x2 scale or more): > > F8280985: IMG_20200503_152810.jpg

D29380: [System Tray] Always draw the highlight behind the icon

This revision was automatically updated to reflect the committed changes. Closed by commit R120:3f06349549c1: [System Tray] Always draw the highlight behind the icon (authored by filipf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29380?vs=81796&i

D29380: [System Tray] Always draw the highlight behind the icon

filipf updated this revision to Diff 81796. filipf added a comment. move the code change to CurrentItemHighlight.qml REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29380?vs=81785&id=81796 BRANCH draw-behind-icons (branched from master) REVISION

D29380: [System Tray] Always draw the highlight behind the icon

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY There was a slight issue introduced with D28109 : the systray highlight can now cover up the ico

D29366: [Wallpaper Configuration] Remove obsolete inline message concerning widget locking

filipf added a comment. Ok, so the message can indeed still be turned on. Setting: `~/.config/plasmarc [General] immutability=2 (or 4)` ... does not work, however the following does: `~/.config/kdeglobals [KDE Action Restrictions][$i] plasma/plasmashell/unlockedDesktop=false`

D29366: [Wallpaper Configuration] Remove obsolete inline message concerning widget locking

filipf added a comment. In D29366#661834 , @ngraham wrote: > Technically it still does exist, it's just hidden. If a person does enable this, perhaps the message is still nice to have? Or maybe we should not show it because the expectation would

D29366: [Wallpaper Configuration] Remove obsolete inline message concerning widget locking

filipf created this revision. filipf added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Widget locking no longer exists so we can remove the inline message that warned of locked widgets.

D29111: [applet] Port to Kirigami.PlaceholderMessage

filipf added a comment. Yeah we shouldn't be mixing Kirigami with Plasma. REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D29111 To: ngraham, #vdg, #plasma, drosca, niccolove Cc: filipf, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, za

D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout

filipf updated this revision to Diff 81709. filipf added a comment. Ditch OpacityAnimator and use PropertyAnimation REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29351?vs=81707&id=81709 BRANCH no-logo-leak (branched from master) REVISION DETAI

D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout

filipf added a comment. This kills the animation though... I found this comment in other code: "//OpacityAnimator when starting from 0 is buggy (it shows one frame with opacity 1)" I'm able to get this opacity fading effect though without the bug if I switch from using OpacityAnimator

D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Even when the vendor logo is turned off it can be briefly seen when the login screen changes from the fadeout state back into normal.

D29333: Don't show an empty error dialog when canceling the sync password prompt

filipf added a comment. Yeah, this is also an issue when clicking cancel on a password prompt in sddm-kcm's GHNS and when clicking Reset in the Advanced tab. And when canceling theme deletion an empty inline message pops up :/ We could work around all four though. I'm of the opinion that

D29307: Implement smallFont in Kirigami plugin

filipf added a comment. How does this relate to D14562 REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D29307 To: cblack, #kirigami Cc: filipf, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, c

D26636: [Widget Explorer] Work around bad kerning

filipf abandoned this revision. filipf added a comment. Should be fixed upstream https://bugreports.qt.io/browse/QTBUG-49646 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26636 To: filipf, #plasma, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev

D26646: [Applet Configuration] Work around bad kerning in sidebar labels

filipf abandoned this revision. filipf added a comment. Should be fixed upstream https://bugreports.qt.io/browse/QTBUG-49646 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26646 To: filipf, #plasma, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev

D29264: New tabs for Breeze

filipf added a comment. I think we still want to have the edges rounded if it's possible? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D29264 To: abstractdevelop, #vdg, #breeze Cc: filipf, ngraham, cblack, plasma-devel, dmenig, manueljlin, Orage, LeGast00n, The-Fere

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

filipf updated this revision to Diff 80582. filipf added a comment. remove the separator instead of just shortening it REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25728?vs=70873&id=80582 BRANCH no-unwanted-titlebar-separator (branched from mast

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

filipf added a comment. I guess the top separator should be removed altogether then? (As opposed to just shortening it) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25728 To: filipf, #plasma, #vdg Cc: cblack, Codezela, manueljlin, anthonyfieroni, broulik,

D20569: RFC: Use more compact OSD

filipf added a comment. I still like osds as notifications but I agree with @alexde, a vertical osd in the corner opposite (?) to where notifications spawn would be visually more pleasing than what is proposed in this patch and should even get in the way less. REPOSITORY R120 Plasma Works

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

filipf added a comment. In D25728#576703 , @ngraham wrote: > Maybe what we should do is change the titlebar separator color in Breeze to be a pleasant dark gray like in the screenshot in @flipwise's latest comment instead of a garish blue, turn

D28461: In sidebar mode show if a module is in default state or not

filipf added a comment. Can you explain why we want this? It's going to be visually prominent so we need a good reason. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D28461 To: bport, #plasma, ervin, meven, crossi, hchain, #vdg Cc: filipf, The-Feren-OS-Dev,

D28154: Add users KCM

filipf added a comment. I'm strongly in favor of removing the autologin option from this KCM. The option only applies to SDDM so it should be in SDDM's settings. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28154 To: cblack, #plasma, #vdg, ngraham Cc: fili

D28054: Made window backgroun color lighter

filipf added a comment. I already prepared this sort of a patch while ago because I believe the Breeze color schemes should have more contrast in order to look more modern. I chose 243, 244, 245 as the new color though since I still wanted to keep it different from the view color. T

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

filipf added inline comments. INLINE COMMENTS > layout.js:28 > +// For an Icons-Only Task Manager on the bottom, *3 is too much, *2 is too > little > +panel.height = Math.round(gridUnit * 2.5) > can we do `Math.round(gridUnit * 2.25)` or at least `Math.round(gridUnit * 2.33)` ? That's about

D27870: [applets/systemtray] Right align popup heading when in RTL mode

filipf added a comment. In D27870#622843 , @ngraham wrote: > Feels like this should be set by default in the `Heading` item, or else we'll be doing this everywhere, no? Sounds like a better solution. I'm not sure if it would interfere wit

D27870: [applets/systemtray] Right align popup heading when in RTL mode

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY In RTL modes headings should be on the right, not on the left as is currently the case. Filling the layout's width is not enough

D27608: Fixes for applet configuration layout.

filipf accepted this revision. filipf added a comment. Good stuff REPOSITORY R119 Plasma Desktop BRANCH configscollcat (branched from master) REVISION DETAIL https://phabricator.kde.org/D27608 To: gvgeo, #plasma, #vdg, filipf, ngraham Cc: ngraham, filipf, plasma-devel, Orage, LeGast00

D27608: Fixes for applet configuration layout.

filipf added a comment. In D27608#621705 , @gvgeo wrote: > Strange, I don't get the resizing problem as it is now, or in master. Only managed to get this space by changing the theme, and was immediately fixed with resize. > > Thanks Filip fo

D27608: Fixes for applet configuration layout.

filipf accepted this revision. filipf added a comment. Fixes the regression. It's still possible to get this when resizing, but it was actually already like that before this patch. F8149023: image.png REPOSITORY R119 Plasma Desktop BRANCH confi

D27608: Fixes for applet configuration layout.

filipf added a comment. Seems to run pretty well, but there is a tiny padding regression introduced. Using `plasmashell --reverse --replace` to test a right to left layout we see that there is excessive padding between the content and the sidebar. F8148094: image.png

D27679: [emojier] Set minimum window height and width

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d0247bf56954: [emojier] Set minimum window height and width (authored by filipf). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27679?vs=76468&id=76541 REV

D27679: [emojier] Set minimum window height and width

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY There are two problems right now with the emojier's window: - when shrinking the window a scrollbar is drawn *over* the category

D27667: Align wallpaper dialog button to bottom

This revision was automatically updated to reflect the committed changes. Closed by commit R123:541d8adc5f14: Align wallpaper dialog button to bottom (authored by filipf). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27667?vs=76431&id=

D27667: Align wallpaper dialog to bottom

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Align wallpaper dialog to bottom instead of vertically centering it between the theme info and the bottom of the frame. BUG: 418

D27608: Fixes for applet configuration layout.

filipf added a comment. Looks good to me and solves 3 of the 4 binding loops, although this one still remains: `file:///usr/share/plasma/shells/org.kde.plasma.desktop/contents/configuration/AppletConfiguration.qml:296:25: QML StackView: Binding loop detected for property "height"` INLI

D26813: Have user-manager write to SDDM's new config file

This revision was automatically updated to reflect the committed changes. Closed by commit R128:b2d0e463a490: Have user-manager write to SDDM's new config file (authored by filipf). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26813?vs=75007&id=75861 R

D27461: Sync Plasma theme settings instead of copying the plasmarc file

filipf added inline comments. INLINE COMMENTS > sddmauthhelper.cpp:138 > +QSharedPointer themeConfig = > openConfig(themeConfigLocation); > + > themeConfig->group(QStringLiteral("Theme")).writeEntry(QStringLiteral("name"), > args[QStringLiteral("plasmaTheme")].toString()); > +

D27461: Sync Plasma theme settings instead of copying the plasmarc file

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY The first and the easiest part of finishing T12710 . Instead of copying the user's plasmarc

D26813: Have user-manager write to SDDM's new config file

filipf added a comment. For 5.18.1 though maybe we could just roll this version out? REPOSITORY R128 User Manager BRANCH write-autologin-right (branched from master) REVISION DETAIL https://phabricator.kde.org/D26813 To: filipf, #plasma, davidedmundson, ngraham Cc: plasma-devel, Orage

D27438: Increase System Tray Plasmoid spacing value slightly

filipf added a comment. copy paste from Telegram > fwiw I like units.smallSpacing / 2 more but it's not that big of a difference REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg Cc: filipf, ndavis, anthonyfieroni, davidr

D27388: Fix being unable to set the right permissions for kde_settings.conf

This revision was automatically updated to reflect the committed changes. Closed by commit R123:cc33ec575c5e: Fix being unable to set the right permissions for kde_settings.conf (authored by filipf). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator

D27418: Don't let the Advanced tab's spacers expand all they want

This revision was automatically updated to reflect the committed changes. Closed by commit R123:26022caf9a2a: Don't let the Advanced tab's spacers expand all they want (authored by filipf). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D27418: Don't let the Advanced tab's spacers expand all they want

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY We have 3 vertical spacers in the Advanced tab and their defined as Expanding. So that means they become quite the gaps if the wi

D27388: Fix being unable to set the right permissions for kde_settings.conf

filipf updated this revision to Diff 75653. filipf added a comment. Fix the permissions for people who have already had the file created with the wrong permissions REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27388?vs=75651&id=7565

D27360: Go back to saving to sddm.conf

filipf abandoned this revision. filipf added a comment. Thanks to @davidedmundson's input we found out the cause, so fixed in: D27388 REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D27360 To: filipf, davide

D27388: Fix being unable to set the right permissions for kde_settings.conf

filipf created this revision. filipf added a reviewer: davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY If we are creating a config file and its directory doesn't exist, we fail to set the right p

D27360: Go back to saving to sddm.conf

filipf added a comment. In D27360#611155 , @davidedmundson wrote: > > The SDDM KCM is broken right now because the kde_settings.conf file is never created with the right permissions. This means that the KCM can't read the settings file. > >

D27360: Go back to saving to sddm.conf

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY The SDDM KCM is broken right now because the kde_settings.conf file is never created with the right permissions. This means that the

D27329: Make Taskmanager's tooltip a fixed ratio rectangle

filipf added a comment. In D27329#609851 , @ngraham wrote: > That's better, though I dunno, I can't shake the feeling that the album art is still too compressed. Me too. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabric

D27303: [applets/taskmanager] Add a bit more padding around album/artist info in tooltip

filipf added a comment. The added vertical padding looks good to me, but I don't like how the horizontal paddding now makes these labels no longer aligned with the tooltip heading. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27303 To: ngraham, #vdg, manu

D27273: [applets/taskmanager] Don't show tooltip subtitle that's identical to the main text

filipf accepted this revision. filipf added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ToolTipInstance.qml:123 > opacity: 0.75 > -visible: !hasPlayer && text.length !== 0 > +visible: !hasPlayer && text.lengt

D27142: Have authhelper define config file paths on its own

This revision was automatically updated to reflect the committed changes. Closed by commit R123:c4b41ffe6660: Have authhelper define config file paths on its own (authored by filipf). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27142?

D27142: Have authhelper define config file paths on its own

filipf added a comment. 5.18 then, right? REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH decoupled-config-path (branched from master) REVISION DETAIL https://phabricator.kde.org/D27142 To: filipf, #plasma, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cbl

D26813: Have user-manager write to SDDM's new config file

filipf added inline comments. INLINE COMMENTS > davidedmundson wrote in accountmodel.cpp:45 > ideally we want the exact same code as the other place > > load /etc/sddm.conf > loop through /etc/sddm.conf.d > add all those files as config sources Seems doable, just not sure what to have this conf

D27144: Moved toggles to the bottom according to T10470

filipf added a comment. In D27144#605649 , @ngraham wrote: > Now when Bluetooth is on but there are no devices, the applet looks like this: > > F8083748: Screenshot_20200203_150046.png > > This popu

D27143: moved do not disturb to the bottom

filipf added a comment. just a minor thing I noticed, rest looks good INLINE COMMENTS > FullRepresentation.qml:422 > } > + > +PlasmaCore.SvgItem { added row is fine but there are 4 spaces added here REPOSITORY R120 Plasma Workspace BRANCH bottom_notification_options (branc

  1   2   3   4   5   6   7   8   9   10   >