filipf accepted this revision. filipf added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > ApplicationsListPage.qml:152 > + > + visible: opacity != 0 > + opacity: apps.count == 0 && !appsModel.isBusy ? 1 : 0 Should work without this, no? > ApplicationsListPage.qml:154 > + opacity: apps.count == 0 && !appsModel.isBusy ? 1 : 0 > Behavior on opacity { PropertyAnimation { duration: > Kirigami.Units.longDuration; easing.type: Easing.InOutQuad } } > + Probably worth it to port this to NumberAnimation at a different time since Marco said it's more efficient. REPOSITORY R134 Discover Software Store BRANCH port-to-placeholdermessage (branched from master) REVISION DETAIL https://phabricator.kde.org/D29689 To: ngraham, apol, #discover_software_store, #vdg, filipf Cc: filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart