D14238: Polish Notifier Plasmoid's UI

2018-07-20 Thread Emil Sedgh
esedgh added a comment. Just a quick question. Why does it have to be so big and waste so much space? It still feels kind of weird. Thank you Nate, btw. You are doing amazing work everywhere. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D14238

D13141: Touchpad KCM Redesign Using Kirigami

2018-05-27 Thread Emil Sedgh
esedgh added a comment. Sorry guys I'm not sure if this is the appropriate place to report this as I'm not involved in the development. But now that you're at it, I may give you a bit of feedback in here. Touchpad settings has "Two Finger Scrolling" and "Edge Scrolling" as a radio b

Re: Review Request 108316: Show album art in krunner results.

2013-01-12 Thread Emil Sedgh
ph. It's not throwing warnings anymore. - Emil --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108316/#review25270 --- On Jan. 12, 2

Re: Review Request 108316: Show album art in krunner results.

2013-01-12 Thread Emil Sedgh
o-x-generic icon if no arturl is defined. Screenshots --- http://git.reviewboard.kde.org/r/108316/s/1013/ Thanks, Emil Sedgh ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Show album art in krunner results.

2013-01-12 Thread Emil Sedgh
e that triggers these errors? or are they there even > > with that? > > Emil Sedgh wrote: > Those warnings go away if I checkout my changes. So yeah, I'm pretty sure > using QIcon causes them. > However, it seems that they are quite harmless. The runner works fa

Re: Review Request: Show album art in krunner results.

2013-01-11 Thread Emil Sedgh
-------- On Jan. 10, 2013, 5:35 a.m., Emil Sedgh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108316/ > -

Re: Review Request: Show album art in krunner results.

2013-01-11 Thread Emil Sedgh
Screenshots --- http://git.reviewboard.kde.org/r/108316/s/1013/ Thanks, Emil Sedgh ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Show album art in krunner results.

2013-01-11 Thread Emil Sedgh
t and fine. Do you think I should do the same as places runner? - Emil --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108316/#review25195 ------

Review Request: Show album art in krunner results.

2013-01-10 Thread Emil Sedgh
unner.cpp 75afb75 Diff: http://git.reviewboard.kde.org/r/108316/diff/ Testing --- Works fine if there's some album art. Reverts to audio-x-generic icon if no arturl is defined. Screenshots --- http://git.reviewboard.kde.org/r/108316/s/1013/ Thanks, Emil Sedgh _