> On Jan. 10, 2013, 10:12 p.m., Vishesh Handa wrote: > > runners/audioplayercontrol/audioplayercontrolrunner.cpp, line 510 > > <http://git.reviewboard.kde.org/r/108316/diff/1/?file=106229#file106229line510> > > > > How about using 'toUrl().toLocalFile()' instead? That will remove the > > file prefix.
Done, thank you. - Emil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108316/#review25196 ----------------------------------------------------------- On Jan. 10, 2013, 5:35 a.m., Emil Sedgh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108316/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2013, 5:35 a.m.) > > > Review request for Plasma. > > > Description > ------- > > Audio player controller has the ability to search through Amarok's collection. > This patch uses 'arturl' property of Amarok's reply to show album art in > KRunner results. > > Some considerations: > arturl sent by Amarok has file:// prefix which QIcon does not understand. I > used QString::remove(0,7) to remove the prefix but it seems hackish. Are > there better ways of fixing this issue? > I get many warnings when I run krunner: "QPixmap: It is not safe to use > pixmaps outside the GUI thread". How should I fix it? > > > Diffs > ----- > > runners/audioplayercontrol/audioplayercontrolrunner.cpp 75afb75 > > Diff: http://git.reviewboard.kde.org/r/108316/diff/ > > > Testing > ------- > > Works fine if there's some album art. > Reverts to audio-x-generic icon if no arturl is defined. > > > Screenshots > ----------- > > > http://git.reviewboard.kde.org/r/108316/s/1013/ > > > Thanks, > > Emil Sedgh > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
