Fwd: It's a bliss working with Dolphin

2020-10-15 Thread Elvis Angelaccio
Forwarding also to Plasma devs as requested :) Forwarded Message Subject:It's a bliss working with Dolphin Date: Thu, 1 Oct 2020 21:13:59 +0200 From: Joe Schroecker To: elvis.angelac...@kde.org Hi, I switched from windows to Manjaro+KDE Plasma + bswpm recently

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

2019-04-06 Thread Elvis Angelaccio
elvisangelaccio added a comment. Is it really necessary to copy `urlinfo.h` here? Wouldn't be enough to just create a static function and put the URL parsing logic there? INLINE COMMENTS > urlinfo.h:45-52 > +if (QFile::exists(path)) { > +/** > + * create absol

[kio-extras] [Bug 363593] In dolphin-16.04.1-1.fc25.x86_64, Unknown error code 150 when copying from phone to computer

2018-11-02 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=363593 Elvis Angelaccio changed: What|Removed |Added Status|REPORTED|RESOLVED Resolution

[frameworks-kio] [Bug 368008] Using a DAV filesystem, Dolphin fails to delete a file containing a µ

2018-10-27 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=368008 Elvis Angelaccio changed: What|Removed |Added CC||elvis.angelac...@kde.org

[kio-extras] [Bug 375840] MTP connection crashes after few minutes on several phones

2018-08-16 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=375840 Elvis Angelaccio changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution

Re: Closing old Plasma 4 bugs

2018-05-27 Thread Elvis Angelaccio
On Fri, May 11, 2018 at 11:06 PM Christoph Feck wrote: > On 11.02.2018 20:52, Nate Graham wrote: > > All right, so let's give it a shot. How about we make it so that normal > > users have full privilages except the following: > > > > - Can't bulk change > > - Can't change Importance field > We n

D12240: Save the dialog view settings when closing the dialog without hitting the cancel button

2018-04-16 Thread Elvis Angelaccio
elvisangelaccio added inline comments. INLINE COMMENTS > kdeplatformfiledialoghelper.cpp:240 > +// Save the view settings before closing the dialog when the Escape key > +// is presed or the close button in the titlebar is clicked > +void KDEPlatformFileDialog::reject() typo: pressed REPOSITORY

D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

2018-04-08 Thread Elvis Angelaccio
elvisangelaccio added a comment. Go for it! REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D4193 To: arichardson, #plasma, elvisangelaccio Cc: fvogt, ngraham, krzyc, anthonyfieroni, elvisangelaccio, graesslin, plasma-devel, ragreen,

D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

2018-03-31 Thread Elvis Angelaccio
elvisangelaccio added a comment. I'd just remove the code and explain why in the commit message. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D4193 To: arichardson, #plasma, elvisangelaccio Cc: ngraham, krzyc, anthonyfieroni, elvis

D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

2018-03-30 Thread Elvis Angelaccio
elvisangelaccio requested changes to this revision. elvisangelaccio added a comment. This revision now requires changes to proceed. Qt minimum version for plasma-integration is 5.9 these days, so this patch should be updated. REPOSITORY R135 Integration for Qt applications in Plasma REVISI

D10362: Swap reveal password button logic

2018-02-07 Thread Elvis Angelaccio
elvisangelaccio added a comment. Hmm I don't know, that's a button and a button should tell me what happens when I click it (Dolphin is also wrong imho). Would it be possible to implement this feature like in the Windows 10 lock screen? (i.e. don't toggle the state; reveal the password o

D8759: Implement SH_Widget_Animation_Duration style hint

2017-11-12 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R31:41c24a337c56: Implement SH_Widget_Animation_Duration style hint (authored by elvisangelaccio). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8759?vs=22193&id=22238#toc REPOSITORY R31 Breeze

D8759: Implement SH_Widget_Animation_Duration style hint

2017-11-12 Thread Elvis Angelaccio
elvisangelaccio marked an inline comment as done. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D8759 To: elvisangelaccio, hpereiradacosta, apol Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D8759: Implement SH_Widget_Animation_Duration style hint

2017-11-11 Thread Elvis Angelaccio
elvisangelaccio updated this revision to Diff 22193. elvisangelaccio added a comment. - Don't use QT_VERSION_CHECK since it's not used anywhere in breeze REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8759?vs=22192&id=22193 BRANCH master REVISION DETAIL

D8759: Implement SH_Widget_Animation_Duration style hint

2017-11-11 Thread Elvis Angelaccio
elvisangelaccio created this revision. elvisangelaccio added a reviewer: hpereiradacosta. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Qt 5.10 deprecates the SH_Widget_Animate style hint in favor of a new SH_Widget_An

D8481: Adjusted scrollbars to fit the Qt theme

2017-10-26 Thread Elvis Angelaccio
elvisangelaccio added a comment. We recently adjusted the gtk3 scrollbars (see https://phabricator.kde.org/D6688), I'm not sure why your Qt scrollbars are so tiny... (maybe hi-DPI related?) REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D8481 To: dos, #breeze

Re: What's a robust way to to read default applications?

2017-09-24 Thread Elvis Angelaccio
On domenica 24 settembre 2017 15:49:04 CEST, Nate Graham wrote: Hello all, I'm working on some code that needs to get the default file manager application. I'm currently using KSharedConfig::openConfig to read mimeapps.list, which works as long as mimeapps.list exists. But I'm noticing that on

D7835: Don't show scrollbar steppers

2017-09-23 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R98:f0ac1407a95c: Don't show scrollbar steppers (authored by elvisangelaccio). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7835?vs=19555&id=19823 REVISION DETA

D7836: Fix background-image warning

2017-09-23 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R98:0ef85af524bb: Fix background-image warning (authored by elvisangelaccio). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7836?vs=19556&id=19824 REVISION DETAI

D7835: Don't show scrollbar steppers

2017-09-23 Thread Elvis Angelaccio
elvisangelaccio added a comment. Ping? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D7835 To: elvisangelaccio, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7836: Fix background-image warning

2017-09-15 Thread Elvis Angelaccio
elvisangelaccio created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This fixes the following warning: Gtk-WARNING **: Theme parsing error: gtk.css:3139:22: Not a valid image It was changed by

D7835: Don't show scrollbar steppers

2017-09-15 Thread Elvis Angelaccio
elvisangelaccio added a comment. Before: F3911870: Before.png After: F3911872: After.png REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D7835 To: elvisangelaccio, #plas

D7835: Don't show scrollbar steppers

2017-09-15 Thread Elvis Angelaccio
elvisangelaccio created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY They were re-added in commit https://phabricator.kde.org/R98:01a86601804222929441c0c1c8bb0db6d4ee2769 without explaining why (we don'

Re: kwin_wayland and setWindowIcon()

2017-09-13 Thread Elvis Angelaccio
On martedì 12 settembre 2017 23:50:57 CEST, David Edmundson wrote: you'll be getting wl_shell_surface@N.set_class("qtcreator") on current kwin. It's a wl_shell vs xdgv6 difference, but they're both getting the same data from the QtWayland code. It's just different implementations of mShellSurf

Re: kwin_wayland and setWindowIcon()

2017-09-12 Thread Elvis Angelaccio
On lunedì 11 settembre 2017 22:15:20 CEST, David Edmundson wrote: From a KDE side we can't use that as we don't have it. There is no icon name part of the specification in either of the shell protocols. The only relevant event is AppId. Qt could base the appId off the window icon but it would

kwin_wayland and setWindowIcon()

2017-09-11 Thread Elvis Angelaccio
Hi, kwin_wayland currently sets the application icon only if it can retrieve the .desktop filename of the application. Is there a reason why it doesn't use the icon passed to setWindowIcon() as fallback? This seems to work with weston, so I guess it should be possible with kwin as well? I'm

D7587: kfileaudiopreview: don't autoplay media files by default

2017-08-29 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R320:c1a7f07d4629: kfileaudiopreview: don't autoplay media files by default (authored by elvisangelaccio). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7587?vs=1889

D7587: kfileaudiopreview: don't autoplay media files by default

2017-08-28 Thread Elvis Angelaccio
elvisangelaccio created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Not only it's annoying, but it's also a potential security risk (basically, a variant of [1]). [1]: https://scarybeastsecurity.b

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

2017-08-03 Thread Elvis Angelaccio
elvisangelaccio added a comment. In https://phabricator.kde.org/D7087#131719, @gregormi wrote: > In https://phabricator.kde.org/D7087#131708, @elvisangelaccio wrote: > > > Why not just a "Copy to clipboard" button (without a menu)? > > > I thought that might look too obstrusive f

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

2017-08-03 Thread Elvis Angelaccio
elvisangelaccio added a comment. Why not just a "Copy to clipboard" button (without a menu)? I see that you are adding also the "About KDE" action in the menu, but that action is already in the Help menu from the toolbar. What's the point of adding it twice? REPOSITORY R102 KInfoCenter RE

Re: Review Request 130208: Add menu with "Copy to Clipboard" to the About System module

2017-07-31 Thread Elvis Angelaccio
> On July 30, 2017, 3:44 p.m., Gregor Mi wrote: > > Ideally, I would like to add a second action to the menu: "About KDE", > > which should show the default "About KDE" dialog. But I don't know how to > > access this default action. > But I don't know how to access this default action. Use `K

D6642: Use version of the Applications product

2017-07-13 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R320:395500244021: Use version of the Applications product (authored by elvisangelaccio). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6642?vs=16557&id=16627#toc REPOSITORY R320 KIO Extras CHA

D6642: Use version of the Applications product

2017-07-12 Thread Elvis Angelaccio
elvisangelaccio created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY kio-extras nowadays is shipped as part of KDE Applications rather than Plasma, so use the correct version. REPOSITORY R320 KIO Ext

D6344: [platforms/x11] Add support for GLX_NV_robustness_video_memory_purge

2017-06-26 Thread Elvis Angelaccio
elvisangelaccio accepted this revision. elvisangelaccio added a comment. This revision is now accepted and ready to land. Tested, works fine. I get the "Desktop effects were restarted due to a graphic reset" notification every time I switch from any tty back to tty1. REPOSITORY R108 KWin B

[kio-extras] [Bug 371278] Dolphin crashed when opening smb location

2017-06-16 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=371278 Elvis Angelaccio changed: What|Removed |Added CC||thomasma...@gmail.com --- Comment #5 from

Re: Transient parent for QtWidgets popup menus

2017-06-07 Thread Elvis Angelaccio
On mercoledì 7 giugno 2017 19:56:59 CEST, Elvis Angelaccio wrote: On domenica 28 maggio 2017 10:37:40 CEST, Marco Martin wrote: On Sunday 28 May 2017 10:12:53 Elvis Angelaccio wrote: ... Any idea about drop menus? (i.e. QMenus usually created in some dropEvent() function). Even if they have

Re: Transient parent for QtWidgets popup menus

2017-06-07 Thread Elvis Angelaccio
On domenica 28 maggio 2017 10:37:40 CEST, Marco Martin wrote: On Sunday 28 May 2017 10:12:53 Elvis Angelaccio wrote: createWinId(); windowHandle()->setTransientParent(parent()->nativeParentWidget()->windowHan dle()); Does it makes sense? Would it work? As far i know, if a qmenu

D5957: Don't ignore initially selected mime type filter

2017-06-05 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R135:267e7c635733: Don't ignore initially selected mime type filter (authored by elvisangelaccio). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5957?vs=14797&id=15183#toc REPOSITORY R135 Integr

D5957: Don't ignore initially selected mime type filter

2017-06-04 Thread Elvis Angelaccio
elvisangelaccio added a comment. Ping? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D5957 To: elvisangelaccio, #plasma, dfaure Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

[kio-extras] [Bug 380417] fish doesn't use User from .ssh/config

2017-06-01 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=380417 Elvis Angelaccio changed: What|Removed |Added Version|17.04.1 |unspecified Assignee|dolphin-bugs

D5883: Revert "Increase smooth scrolling animation duration from 100 to 300 ms and set easing curve to InOutQuart"

2017-05-31 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R318:883b908b4b26: Revert "Increase smooth scrolling animation duration from 100 to 300 ms and set… (authored by elvisangelaccio). REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.

D5883: Revert "Increase smooth scrolling animation duration from 100 to 300 ms and set easing curve to InOutQuart"

2017-05-31 Thread Elvis Angelaccio
elvisangelaccio added a comment. Ping? I'm going to push before the 17.04.2 tag, unless there are objections. (for the record, https://codereview.qt-project.org/#/c/195712/ will make this feature configurable). REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D5

Re: Transient parent for QtWidgets popup menus

2017-05-28 Thread Elvis Angelaccio
On domenica 28 maggio 2017 10:37:40 CEST, Marco Martin wrote: On Sunday 28 May 2017 10:12:53 Elvis Angelaccio wrote: createWinId(); windowHandle()->setTransientParent(parent()->nativeParentWidget()->windowHan dle()); Does it makes sense? Would it work? As far i know, if a qmenu

Transient parent for QtWidgets popup menus

2017-05-28 Thread Elvis Angelaccio
Hi all, as you may know in Wayland popup menus are wrongly positioned if they don't have a transient parent set on their window. For QtWidget applications the fix itself is rather easy (at least in the simplest case): someMenu->createWinId(); // someMenu is a QMenu someMenu->windowHand

D5956: Make sure we always set a default mime filter in save mode

2017-05-27 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R135:0dafb9403266: Make sure we always set a default mime filter in save mode (authored by elvisangelaccio). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://

D5973: Always add data sources in SystemMonitorEngine::sourceRequestEvent()

2017-05-26 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R120:f060ad5f1ad0: Always add data sources in SystemMonitorEngine::sourceRequestEvent() (authored by elvisangelaccio). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde

D5973: Always add data sources in SystemMonitorEngine::sourceRequestEvent()

2017-05-26 Thread Elvis Angelaccio
elvisangelaccio edited the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D5973 To: elvisangelaccio, #plasma, jgrulich Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D5973: Always add data sources in SystemMonitorEngine::sourceRequestEvent()

2017-05-26 Thread Elvis Angelaccio
elvisangelaccio created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Otherwise if we show the plasma-nm applet twice, m_sensors won't be empty and we won't be able to fect the connection speed data.

D5957: Don't ignore initially selected mime type filter

2017-05-24 Thread Elvis Angelaccio
elvisangelaccio created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Otherwise QFileDialog::selectMimeTypeFilter() has no effect if called before show()/initializeDialog() (because the mime filters ar

D5956: Make sure we always set a default mime filter in save mode

2017-05-24 Thread Elvis Angelaccio
elvisangelaccio created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY KFileWidget::setMimeFilter() documentation says a default mime filter should be set if the dialog is being open in save mode. Wi

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-24 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=376344 --- Comment #46 from Elvis Angelaccio --- @madcatz: it's unlikely that the bug is in Dolphin, as other kioslaves work just fine. Dolphin enables/disables the "Create New" menu depending on KFileItem::isWritable(). You may want to put so

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-05-23 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=376344 --- Comment #35 from Elvis Angelaccio --- (In reply to madcatx from comment #27) > Created attachment 105682 [details] > Allow write access to root samba share > > The code still does not work entirely as expected - I am allowed to try to

[kio-extras] [Bug 371278] Dolphin crashed when opening smb location

2017-05-18 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=371278 Elvis Angelaccio changed: What|Removed |Added CC||elvis.angelac...@kde.org Component

[kio-extras] [Bug 379902] Samba shares no longer work

2017-05-16 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=379902 Elvis Angelaccio changed: What|Removed |Added Assignee|dolphin-bugs-n...@kde.org |plasma-devel@kde.org Component

D5883: Revert "Increase smooth scrolling animation duration from 100 to 300 ms and set easing curve to InOutQuart"

2017-05-16 Thread Elvis Angelaccio
elvisangelaccio created this revision. Restricted Application added a project: Plasma. Restricted Application added subscribers: Dolphin, Konqueror, plasma-devel. REVISION SUMMARY This reverts commit https://phabricator.kde.org/R318:58c5eae1953bbdcf6d4150b21cb7ffdad07a5257. Reasons against

[kio-extras] [Bug 379680] MTP protocol died unexpectedly

2017-05-13 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=379680 Elvis Angelaccio changed: What|Removed |Added Resolution|--- |WAITINGFORINFO Assignee|dolphin

D5779: Make sure the new avatar is always saved

2017-05-09 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R128:826e41429917: Make sure the new avatar is always saved (authored by elvisangelaccio). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5779?vs=14318&id=14348 RE

D5779: Make sure the new avatar is always saved

2017-05-08 Thread Elvis Angelaccio
elvisangelaccio created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The KIO job needs to be run synchronously, otherwise the KCM might be deleted before the job finished. This happens when closing the

D5538: Implement QPlatformTheme::fileIconPixmap()

2017-05-07 Thread Elvis Angelaccio
elvisangelaccio added a comment. Does this patch fix https://bugs.kde.org/show_bug.cgi?id=362135 ? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D5538 To: eshalygin, #plasma, markg, graesslin Cc: elvisangelaccio, graesslin, ltoscano

[kio-extras] [Bug 379602] Using Dolphin and Okular is not possible to open some PDF files on Samba or in some archives

2017-05-07 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=379602 Elvis Angelaccio changed: What|Removed |Added Product|dolphin |kio-extras CC

[kio-extras] [Bug 339456] Thumbnailers in kio-extras needs porting to KF5

2017-05-07 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=339456 Elvis Angelaccio changed: What|Removed |Added Resolution|--- |FIXED CC

Re: Next Gen CI Will Be Moving to Production Shortly: Upcoming Changes

2017-05-06 Thread Elvis Angelaccio
On sabato 6 maggio 2017 11:37:51 CEST, Ben Cooksley wrote: Hi everyone, This is going to be quite a long email, my apologies in advance for that. If you use the CI system regularly as part of your development flow it is important you read this email in it's entirety as your action will probably

[kio-extras] [Bug 379550] XCF preview thumbnails in dolphin, new format not recognized

2017-05-05 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=379550 Elvis Angelaccio changed: What|Removed |Added Component|view-engine: icons mode |default Assignee|dolphin-bugs-n

D5446: Implement support for selected mime type filters

2017-04-30 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R135:0a6be721e4e3: Implement support for selected mime type filters (authored by elvisangelaccio). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricato

D5446: Implement support for selected mime type filters

2017-04-22 Thread Elvis Angelaccio
elvisangelaccio updated this revision to Diff 13692. elvisangelaccio added a comment. Properly implement selectedMimeTypeFilter(). KFileFilterCombo::currentFilter() might return invalid mimetypes, so fall back on QMimeDatabase() if necessary. REPOSITORY R135 Integration for Qt application

[kio-extras] [Bug 363593] In dolphin-16.04.1-1.fc25.x86_64, Unknown error code 150 when copying from phone to computer

2017-04-21 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=363593 Elvis Angelaccio changed: What|Removed |Added Version|16.12.2 |unspecified CC

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-04-18 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=376344 --- Comment #12 from Elvis Angelaccio --- (In reply to fbr from comment #11) > (In reply to mathojojo from comment #10) > > Hello, > > > > Just wondering... Why is this bug still in "UNCONFIRMED" Status ?? The bug > &

D5446: Implement support for selected mime type filters

2017-04-15 Thread Elvis Angelaccio
elvisangelaccio added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kdeplatformfiledialoghelper.h:64-67 > Better overrites them, then ifdef in implementation Not possible, only QPlatformFileDialogHelper >= 5.9 has those methods. REPOSITORY R135 Integration for Qt applications in

D5446: Implement support for selected mime type filters

2017-04-15 Thread Elvis Angelaccio
elvisangelaccio edited the summary of this revision. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D5446 To: elvisangelaccio, #plasma, dfaure Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D5446: Implement support for selected mime type filters

2017-04-15 Thread Elvis Angelaccio
elvisangelaccio marked 3 inline comments as done. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D5446 To: elvisangelaccio, #plasma, dfaure Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ap

D5446: Implement support for selected mime type filters

2017-04-15 Thread Elvis Angelaccio
elvisangelaccio updated this revision to Diff 13457. elvisangelaccio added a comment. - Removed pointless QMimeDatabase usage in the test - Only run unit test when building against 5.9 REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricato

D5446: Implement support for selected mime type filters

2017-04-15 Thread Elvis Angelaccio
elvisangelaccio added inline comments. INLINE COMMENTS > elvisangelaccio wrote in qfiledialogtest.cpp:116 > ...or maybe we can turn the assert in a qWarning()? Otherwise if > isMimeFilter() is false we get a name filter instead of a mimetype, a bit > misleading? The problem is that if `isMimeF

D5446: Implement support for selected mime type filters

2017-04-15 Thread Elvis Angelaccio
elvisangelaccio added inline comments. INLINE COMMENTS > dfaure wrote in kfiledialog_unittest.cpp:84 > Why use QMimeDatabase, just to then use name()? You could just put > "text/x-chdr" in the data row, no? Leftover from the previous patch, yes doesn't make sense now. > dfaure wrote in kfiledi

D2365: Add failing test case for selected filter from mimetype

2017-04-14 Thread Elvis Angelaccio
elvisangelaccio abandoned this revision. elvisangelaccio added a comment. Superseded by https://phabricator.kde.org/D5446. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D2365 To: elvisangelaccio, graesslin, dfaure Cc: plasma-devel,

D1813: Fix selected name filter with multiple mimetypes

2017-04-14 Thread Elvis Angelaccio
elvisangelaccio abandoned this revision. elvisangelaccio added a comment. Superseded by https://phabricator.kde.org/D5446. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D1813 To: elvisangelaccio, #plasma Cc: dfaure, graesslin, mart,

D5446: Implement support for selected mime type filters

2017-04-14 Thread Elvis Angelaccio
elvisangelaccio created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY QFileDialog in Qt 5.9 has better support for mimetype filters and introduces the QFileDialog::selectedMimeTypeFilter() method [1].

D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

2017-04-13 Thread Elvis Angelaccio
elvisangelaccio added inline comments. INLINE COMMENTS > elvisangelaccio wrote in kdeplatformfiledialoghelper.cpp:365-370 > What about `if (qVersion() < QStringLiteral("5.7.1")) {}`? It doesn't work in > the general case but it should work for this specific check. Sorry but I didn't think about

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-04-09 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=376344 Elvis Angelaccio changed: What|Removed |Added CC||markusmitsc...@gmail.com --- Comment #9

D3531: Drop remote ioslave, which is now in KIO 5.32

2017-03-29 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R120:f81c73b8e25b: Drop remote ioslave, which is now in KIO 5.32 (authored by elvisangelaccio). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3531?vs=11556&id=

D3531: Drop remote ioslave, which is now in KIO 5.32

2017-03-28 Thread Elvis Angelaccio
elvisangelaccio added a comment. I'm going to push this by tomorrow unless someone has objections. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3531 To: elvisangelaccio, #plasma, davidedmundson Cc: bshah, lbeltrame, davidedmundson, plasma-devel, progwolff

[kio-extras] [Bug 378217] Use user defined in .ssh/config for fish

2017-03-28 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=378217 Elvis Angelaccio changed: What|Removed |Added Component|general |default CC

D5128: Set no stepper button for GTK3 scrollbars on gtk >=3.20

2017-03-28 Thread Elvis Angelaccio
elvisangelaccio added a comment. It seems the upstream firefox bug has been fixed, can you update to commit message? Anyway +1 for removing the stepper buttons, currently there is an annoying difference between breeze and breeze-gtk3 scrollbars. REPOSITORY R98 Breeze for Gtk REVISION DE

D3531: Drop remote ioslave, which is now in KIO 5.32

2017-03-20 Thread Elvis Angelaccio
elvisangelaccio added a comment. Ping? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3531 To: elvisangelaccio, #plasma, davidedmundson Cc: bshah, lbeltrame, davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, a

D3531: Drop remote ioslave, which is now in KIO 5.32

2017-03-12 Thread Elvis Angelaccio
elvisangelaccio retitled this revision from "Drop remote ioslave, will be in KIO 5.32" to "Drop remote ioslave, which is now in KIO 5.32". elvisangelaccio edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3531 To: elvisangelac

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-03-10 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=376344 --- Comment #6 from Elvis Angelaccio --- *** Bug 377198 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.

[kio-extras] [Bug 375333] Folders thumbnails : custom folder icon overridden by default folder icon

2017-03-10 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=375333 --- Comment #16 from Elvis Angelaccio --- Ah right, it seems the fix was committed on master only. -- You are receiving this mail because: You are the assignee for the bug.

[kio-extras] [Bug 375333] Folders thumbnails : custom folder icon overridden by default folder icon

2017-03-10 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=375333 --- Comment #14 from Elvis Angelaccio --- @Mahendra: you may want to delete your thumbnail cache folders: ~/.cache/thumbnails/large and ~/.cache/thumbnails/normal -- You are receiving this mail because: You are the assignee for the bug.

D4979: Add places:/ KIO slave

2017-03-08 Thread Elvis Angelaccio
elvisangelaccio added a comment. Nice! But I don't see anything plasma-specific in this slave. It would be better to put it in kio or kio-extras, imho. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4979 To: broulik, #plasma, hein, dfaure Cc: elvisangel

[kio-extras] [Bug 359278] Crash when opening smb:// folders

2017-03-06 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=359278 Elvis Angelaccio changed: What|Removed |Added CC||hi...@tahiti-ingenierie.pf --- Comment #6

D4839: kio_mtp: add write permissions to root storage folder

2017-03-05 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R320:6a828b172937: kio_mtp: add write permissions to root storage folder (authored by elvisangelaccio). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4839?vs=11940&i

[kio-extras] [Bug 366795] Paste action disabled when copying a local file to smb:// or mtp://

2017-03-05 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=366795 --- Comment #27 from Elvis Angelaccio --- (In reply to vlaomao from comment #25) > (In reply to Elvis Angelaccio from comment #24) > > @vlaomao: you need kio 5.26 or later > > I have installed kde-frameworks/kio-5.27.0 Should be fixed

[kio-extras] [Bug 366795] Paste action disabled when copying a local file to smb:// or mtp://

2017-03-05 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=366795 --- Comment #26 from Elvis Angelaccio --- Git commit 6a828b172937a17f56d90a23daf2c7ed77d8ebc7 by Elvis Angelaccio. Committed on 05/03/2017 at 21:26. Pushed by elvisangelaccio into branch 'Applications/16.12'. kio_mtp: add write permissio

D4839: kio_mtp: add write permissions to root storage folder

2017-03-05 Thread Elvis Angelaccio
elvisangelaccio added a comment. Ping? 16.12.3 tag is due tomorrow, would be nice to get this in. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D4839 To: elvisangelaccio, #plasma, dfaure Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abet

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-03-03 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=376344 Elvis Angelaccio changed: What|Removed |Added CC||fre...@protonmail.com --- Comment #4 from

[kio-extras] [Bug 377057] KIO MTP : Download all file before play it

2017-03-01 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=377057 Elvis Angelaccio changed: What|Removed |Added CC||elvis.angelac...@kde.org Resolution

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-02-28 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=376344 --- Comment #3 from Elvis Angelaccio --- It looks like samba doesn't set write permission to the root folder: kio-extras/smb/kio_smb_browser.cpp has two occurrences of: udsentry.insert(KIO::UDSEntry::UDS_ACCESS, (S_IRUSR | S_IRGRP | S_IROTH | S_

[Differential] [Request, 2 lines] D4839: kio_mtp: add write permissions to root storage folder

2017-02-28 Thread Elvis Angelaccio
elvisangelaccio created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Otherwise it's impossible to paste files there. CCBUG: 366795 TEST PLAN I can now paste files to the root folder of my phone's

[kio-extras] [Bug 376830] smb share in dolphin is very broken

2017-02-23 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=376830 Elvis Angelaccio changed: What|Removed |Added Version|16.12.0 |unspecified Product|dolphin

[Differential] [Closed] D4563: Replace warps-slider checkbox with radio buttons

2017-02-23 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R99:57403a78afa2: Replace warps-slider checkbox with radio buttons (authored by elvisangelaccio). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4563?v

[Differential] [Closed] D4705: Don't assume initialized if there are pending dbus replies

2017-02-22 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R116:2c70ac2a6edd: Don't assume initialized if there are pending dbus replies (authored by elvisangelaccio). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricat

  1   2   3   >