Review Request: Move IconItem into MouseArea

2012-12-23 Thread Dmitry Ashkadov
gs.kde.org/show_bug.cgi?id=311961 Diffs - plasma/generic/applets/systemtray/package/contents/ui/StatusNotifierItem.qml 8c1af92 Diff: http://git.reviewboard.kde.org/r/107886/diff/ Testing --- Thanks, Dmitry Ashkadov ___ Plasma-devel mailing l

Review Request: SystemTray: alignment of popup dialog

2012-11-19 Thread Dmitry Ashkadov
dialog of system tray has been fixed and set to Qt.AlignCenter Diffs - plasma/generic/applets/systemtray/package/contents/ui/ArrowArea.qml 336f052 Diff: http://git.reviewboard.kde.org/r/107378/diff/ Testing --- Thanks, Dmitry Ashkadov

Re: Review Request: Class Plasmoid is merged to SystemTray::Applet

2012-11-09 Thread Dmitry Ashkadov
stdout. - Dmitry --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107262/#review21689 --- On Nov. 9, 2012, 9:59 a.m., Dm

Review Request: Class Plasmoid is merged to SystemTray::Applet

2012-11-09 Thread Dmitry Ashkadov
/107262/diff/ Testing --- Thanks, Dmitry Ashkadov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-07 Thread Dmitry Ashkadov
lasma, and once one gets used to it > > things become easier :) > > > > anyways.. this one small change of moving the hiding status from Task to > > WidgetItem and this can be pushed into master :) > > > > thanks ... > > Dmitry Ashkadov wrote: > M

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-07 Thread Dmitry Ashkadov
lasma, and once one gets used to it > > things become easier :) > > > > anyways.. this one small change of moving the hiding status from Task to > > WidgetItem and this can be pushed into master :) > > > > thanks ... > > Dmitry Ashkadov wrote: > M

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-07 Thread Dmitry Ashkadov
Diff: http://git.reviewboard.kde.org/r/107160/diff/ Testing --- Thanks, Dmitry Ashkadov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-07 Thread Dmitry Ashkadov
lasma, and once one gets used to it > > things become easier :) > > > > anyways.. this one small change of moving the hiding status from Task to > > WidgetItem and this can be pushed into master :) > > > > thanks ... > > Dmitry Ashkadov wrote: > M

Review Request: SystemTray: Removing IconWidget for an arrow

2012-11-07 Thread Dmitry Ashkadov
--- IconWidget should be removed from QML. It may be replaced with SvgItem for an arrow. Diffs - plasma/generic/applets/systemtray/package/contents/ui/ArrowArea.qml a3d7f39 Diff: http://git.reviewboard.kde.org/r/107239/diff/ Testing --- Thanks, Dmitry Ashkadov

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-06 Thread Dmitry Ashkadov
lasma, and once one gets used to it > > things become easier :) > > > > anyways.. this one small change of moving the hiding status from Task to > > WidgetItem and this can be pushed into master :) > > > > thanks ... > > Dmitry Ashkadov wrote: > M

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-06 Thread Dmitry Ashkadov
g/r/107160/#review21486 --- On Nov. 2, 2012, 12:40 p.m., Dmitry Ashkadov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-02 Thread Dmitry Ashkadov
temtray/ui/widgetitem.h 40aa92d plasma/generic/applets/systemtray/ui/widgetitem.cpp 9d2c622 Diff: http://git.reviewboard.kde.org/r/107160/diff/ Testing --- Thanks, Dmitry Ashkadov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.o

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-01 Thread Dmitry Ashkadov
tem tray plasmoid. > > (look for s_manager) this keeps memory usage and dbus activity down. so > > this approach can not work. > > Dmitry Ashkadov wrote: > So, task will have no widget property and WidgetItem will know about Task > (not only QGraphicsWidget). And doe

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-01 Thread Dmitry Ashkadov
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107160/#review21280 ------- On Oct. 31, 2012, 7 p.m., Dmitry Ashkadov wrote: > > ---

Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-10-31 Thread Dmitry Ashkadov
hanks, Dmitry Ashkadov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: QML style guide

2012-10-30 Thread Dmitry Ashkadov
30.10.2012 21:33, Martin Gräßlin пишет: On Tuesday 30 October 2012 18:16:26 Aurélien Gâteau wrote: The only part I don't really like is putting left curly brace on its own line for functions because: - having different conventions for event-handlers and function code blocks look inconsistent -

Re: QML style guide

2012-10-30 Thread Dmitry Ashkadov
30.10.2012 17:20, Marco Martin пишет: On Tuesday 30 October 2012, Dmitry Ashkadov wrote: 30.10.2012 16:01, Sebastian Kügler пишет: There, the JS code should probably be in the QML file itself, as that's the only place where it's used. For the shared code, you'd import: import

Re: QML style guide

2012-10-30 Thread Dmitry Ashkadov
30.10.2012 16:01, Sebastian Kügler пишет: There, the JS code should probably be in the QML file itself, as that's the only place where it's used. For the shared code, you'd import: import "plasmapackage:/code/statelesslib.js" as StatelessLib There is page in documentation http://qt-project.o

Re: QML style guide

2012-10-30 Thread Dmitry Ashkadov
30.10.2012 14:35, Aaron J. Seigo пишет: 5. Vim: The {{{ and }}} are just for the sakes of vim's automatic folding. Do we all use vim? I think no. So, we must never force developers use vim. i mostly agree :) i don't think this forces anyone to use vim, but i would like to see a solution that

Re: QML style guide

2012-10-30 Thread Dmitry Ashkadov
30.10.2012 13:15, Aaron J. Seigo пишет: On Tuesday, October 30, 2012 12:25:14 Dmitry Ashkadov wrote: First of all, it a good idea! :) 1. I think you should explain why you have chosen such style instead of another one. Your decision should be justified. this is the death of style guides

Re: QML style guide

2012-10-30 Thread Dmitry Ashkadov
Hello! First of all, it a good idea! 1. I think you should explain why you have chosen such style instead of another one. Your decision should be justified. For example: I don't understand why you put brace on new line in case of function. As for me it's terrible because I need always rememb

Re: qml systemtray: small refactorings

2012-10-26 Thread Dmitry Ashkadov
26.10.2012 12:38, Aaron J. Seigo пишет: On Friday, October 26, 2012 11:35:57 Dmitry Ashkadov wrote: Thank you! Is somebody who periodically merges KDE 4.X to master or it must be made by who fixes bug? the bug fixer; kdelibs is different -> it is merged periodically by someone (usually dfa

Re: qml systemtray: small refactorings

2012-10-26 Thread Dmitry Ashkadov
26.10.2012 10:50, Aaron J. Seigo пишет: On Friday, October 26, 2012 10:04:24 Dmitry Ashkadov wrote: Thank you for your answer. What workflow does KDE team use to bring changes from master branch to KDE4.X branch? For example, some fixes should be applied to master and KDE4.X branches at the

Re: qml systemtray: small refactorings

2012-10-25 Thread Dmitry Ashkadov
26.10.2012 09:51, Luca Beltrame пишет: In data venerdì 26 ottobre 2012 09:40:25, Dmitry Ashkadov ha scritto: branch should I use to make some refactoring/changes? As I know today 4.10 branch must be created. Today marks the *soft* feature freeze: in other words, not yet frozen for new

Re: qml systemtray: small refactorings

2012-10-25 Thread Dmitry Ashkadov
26.10.2012 00:43, Aaron J. Seigo пишет: hi... i suppose this is mostly for Dmitry, but its nice to have these discussions here :) so .. system tray plasmoid. works pretty well it seems. :) Hello! Thank you for your questions! But first of all, I'd like to know what branch should I use to ma

Re: Review Request: Possibility to change an element ID of svg image in IconWidget

2012-10-25 Thread Dmitry Ashkadov
lly generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107017/#review20863 --- On Oct. 24, 2012, 1:02 p.m., Dmitry Ashkadov wrote: > > --- > This is an aut

Re: Review Request: Possibility to change an element ID of svg image in IconWidget

2012-10-24 Thread Dmitry Ashkadov
et.h 78f392e plasma/widgets/iconwidget.cpp a2092a4 Diff: http://git.reviewboard.kde.org/r/107017/diff/ Testing --- Thanks, Dmitry Ashkadov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Possibility to change an element ID of svg image in IconWidget

2012-10-24 Thread Dmitry Ashkadov
sting --- Thanks, Dmitry Ashkadov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Possibility to change an element ID of svg image in IconWidget

2012-10-24 Thread Dmitry Ashkadov
use I will can eliminate usage of Svg QML items for arrow and Dbus tasks in system tray. Diffs - plasma/widgets/iconwidget.h 78f392e plasma/widgets/iconwidget.cpp a2092a4 Diff: http://git.reviewboard.kde.org/r/107017/diff/ Testing --- Thanks, Dmitry Ash

Review Request: Possibility to set QIcon to PlasmaCore.Tooltip

2012-10-23 Thread Dmitry Ashkadov
: http://git.reviewboard.kde.org/r/107013/diff/ Testing --- Thanks, Dmitry Ashkadov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: SystemTray: QML version #3

2012-10-23 Thread Dmitry Ashkadov
23.10.2012 12:51, Marco Martin пишет: On Tuesday 23 October 2012, Dmitry Ashkadov wrote: 23.10.2012 12:44, Marco Martin пишет: On Tuesday 23 October 2012, Luca Beltrame wrote: In data martedì 23 ottobre 2012 12:28:44, Dmitry Ashkadov ha scritto: it shows only dark blue circle. I've

Re: SystemTray: QML version #3

2012-10-23 Thread Dmitry Ashkadov
23.10.2012 12:44, Marco Martin пишет: On Tuesday 23 October 2012, Luca Beltrame wrote: In data martedì 23 ottobre 2012 12:28:44, Dmitry Ashkadov ha scritto: it shows only dark blue circle. I've fixed this blue circle. Now blue circle of kmail works for me. Could you try choqok& km

Re: SystemTray: QML version #3

2012-10-23 Thread Dmitry Ashkadov
22.10.2012 19:17, Luca Beltrame пишет: In data giovedì 18 ottobre 2012 09:50:49, Dmitry Ashkadov ha scritto: Hello, I've made several changes to system tray with interface in QML (plasma/dmitrya/systemtray-qml branch of kde-workspace): I've been playing with this for a bit and I

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Dmitry Ashkadov
/systemtray/ui/widgetitem.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/106965/diff/ Testing --- Screenshots --- Example http://git.reviewboard.kde.org/r/106965/s/788/ Thanks, Dmitry Ashkadov ___ Plasma-devel mailing list

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Dmitry Ashkadov
org.kde.core.Dialog to hide dialog from taskbar. So, custom implementation of dialog may be removed. - Dmitry Ashkadov On Oct. 22, 2012, 9:19 a.m., Dmitry Ashkadov wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Dmitry Ashkadov
which cannot be scaled(?) since they are not > > actual icons, but I think they should be shown centered inside the bigger > > cell then. (and the only app I regularly use that still uses XEmbed is > > Skype) > > Dmitry Ashkadov wrote: > I can try do this, But how can

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Dmitry Ashkadov
which cannot be scaled(?) since they are not > > actual icons, but I think they should be shown centered inside the bigger > > cell then. (and the only app I regularly use that still uses XEmbed is > > Skype) > > Dmitry Ashkadov wrote: > I can try do this, But how can

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Dmitry Ashkadov
essary, a wheelevent was added in > > org.kde.qtextracomponents in MouseEventListener > > > > the TODO of replacing this in qt5 stays, but is a c++ file less > > > > see > > http://api.kde.org/4.x-api/kde-runtime-apidocs/plasma/html/classMouseEventListener.html > >

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Dmitry Ashkadov
ption now. I need to know how can I get size from KDE settings. - Dmitry --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106965/#review20608 -----

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Dmitry Ashkadov
-- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106965/#review20597 --- On Oct. 22, 2012, 9:19 a.m., Dmitry Ashkadov wrote: > > ---

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Dmitry Ashkadov
--- Example http://git.reviewboard.kde.org/r/106965/s/788/ Thanks, Dmitry Ashkadov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Dmitry Ashkadov
- Example http://git.reviewboard.kde.org/r/106965/s/788/ Thanks, Dmitry Ashkadov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: SystemTray: QML version #2

2012-10-19 Thread Dmitry Ashkadov
19.10.2012 11:59, Marco Martin пишет: On Friday 19 October 2012, Dmitry Ashkadov wrote: we should get this merged into master sooner rather than later. if it has all the features of the C++ one, i'd like to see that happen, well, tomorrow :) Hello! QML tray have all features of C++

Where should QML stuff be placed to?

2012-10-19 Thread Dmitry Ashkadov
Hello! I'm working on QML implementation of system tray for desktop. But I don't know where the QML stuff (files *.qml & *.js) should be placed to. I have found out that there are 3 places. Let be share directory for applications (usually it /usr/share/apps ) and be a name of application/p

Re: SystemTray: QML version #2

2012-10-18 Thread Dmitry Ashkadov
18.10.2012 22:29, Aaron J. Seigo пишет: On Wednesday, October 17, 2012 17:52:58 Dmitry Ashkadov wrote: 15.10.2012 20:20, Aaron J. Seigo ?: i do notice some small visual issues in the screenshots (thanks for providing those, btw!), mostly to do with spacing and margins in the popup. as you

SystemTray: QML version #3

2012-10-17 Thread Dmitry Ashkadov
Hello! I've made several changes to system tray with interface in QML (plasma/dmitrya/systemtray-qml branch of kde-workspace): * Now the arrow will hide if popup dialog contains no items * Some distances between items in popup dialog have been increased * A new approach to the problem of co

Re: SystemTray: QML version #2

2012-10-17 Thread Dmitry Ashkadov
Hello! 15.10.2012 21:36, Marco Martin пишет: as aaron also noted, if the text is very large seems it can go out of boundaries (seen in http://wstaw.org/m/2012/10/15/plasma-desktopO28633.png), probably the popup should expand until a certain width in characters, and then elide the entries text if

Re: SystemTray: QML version #2

2012-10-15 Thread Dmitry Ashkadov
15.10.2012 20:20, Aaron J. Seigo ?: On Monday, October 15, 2012 19:20:13 Dmitry Ashkadov wrote: i do notice some small visual issues in the screenshots (thanks for providing those, btw!), mostly to do with spacing and margins in the popup. as you can see in image 05, there is not enough

Re: Plasma applets inside QML applet

2012-06-25 Thread Dmitry Ashkadov
Djuro Drljaca написал(а): Hello, it would probably useful if you also provided an example where you want to use this. I don't know enough about what this, but you will probably get better information or even another way to do what you want to achieve if there is more information on the backgr