Review Request 119990: Fix libraries and includes to follow the KF5 naming scheme

31eee10 processui/CMakeLists.txt 150e198 signalplotter/CMakeLists.txt 67aa8bb Diff: https://git.reviewboard.kde.org/r/119990/diff/ Testing --- Builds, installs, libraries are called libKF5*.so, includes in /usr/include/KF5/KSysGuard/ Thanks, Dan Vrátil

Re: Review Request 119794: Add button to change keyboard layout in the lockscreen

tents/lockscreen/LockScreen.qml ba95cb9 Diff: https://git.reviewboard.kde.org/r/119794/diff/ Testing --- File Attachments https://git.reviewboard.kde.org/media/uploaded/files/2014/08/14/a96e6542-b7c8-4945-ada4-e97873e9b9b0__scrlocker.png Thanks, Dan V

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

/contents/components/UserSelect.qml 7b605b1 lookandfeel/contents/lockscreen/LockScreen.qml ba95cb9 ksmserver/screenlocker/greeter/greeterapp.h f88d4d2 Diff: https://git.reviewboard.kde.org/r/119797/diff/ Testing --- Thanks, Dan Vrátil

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

To reply, visit: https://git.reviewboard.kde.org/r/119797/#review65213 ------- On Aug. 25, 2014, 4:11 p.m., Dan Vrátil wrote: > > --- > This is an automatical

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

/contents/lockscreen/LockScreen.qml ba95cb9 ksmserver/screenlocker/greeter/greeterapp.h f88d4d2 Diff: https://git.reviewboard.kde.org/r/119797/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request 119794: Add button to change keyboard layout in the lockscreen

https://git.reviewboard.kde.org/r/119794/diff/ Testing --- File Attachments https://git.reviewboard.kde.org/media/uploaded/files/2014/08/14/a96e6542-b7c8-4945-ada4-e97873e9b9b0__scrlocker.png Thanks, Dan Vrátil ___ Plasma-devel ma

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

/greeter/greeterapp.h f88d4d2 Diff: https://git.reviewboard.kde.org/r/119797/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119885: Use CMAKE_INSTALL_FULL_BINDIR in plasma.desktop

ooops, fixed now. Thanks! - Dan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119885/#review65163 --- On Aug. 21,

Re: Review Request 119885: Use CMAKE_INSTALL_FULL_BINDIR in plasma.desktop

Diffs - plasma.desktop.cmake 81ca9a7 Diff: https://git.reviewboard.kde.org/r/119885/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 119885: Use CMAKE_INSTALL_FULL_BINDIR in plasma.desktop

sting --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

t: https://git.reviewboard.kde.org/r/119797/#review64758 ----------- On Aug. 18, 2014, 4:21 p.m., Dan Vrátil wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119797/ > --

Re: Review Request 119794: Add button to change keyboard layout in the lockscreen

794/#review64630 ----------- On Aug. 14, 2014, 11:40 p.m., Dan Vrátil wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

://git.reviewboard.kde.org/r/119797/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

Nonetheless, that looks wrong to me, don't we have gridUnit for stuff > > like that? > > Dan Vrátil wrote: > This actually represents the height of the actual content block - I'm not > sure we can/want to use some generic value for that. > > I thin

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

/UserSelect.qml 7b605b1 Diff: https://git.reviewboard.kde.org/r/119797/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

the height of the element should be based on total height of the elements it contains - I'm not sure why this is not the case but I'll try to do it that way first. - Dan --- This is an automatically generated e-mail. To reply, vis

Re: Review Request 119797: Show warning in lockscreen when capslock is enabled

://git.reviewboard.kde.org/r/119797/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 119797: Show warning in lockscreen when capslock is enabled

--- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119794: Add button to change keyboard layout in the lockscreen

https://git.reviewboard.kde.org/r/119794/diff/ Testing --- File Attachments (updated) https://git.reviewboard.kde.org/media/uploaded/files/2014/08/14/a96e6542-b7c8-4945-ada4-e97873e9b9b0__scrlocker.png Thanks, Dan Vrátil ___ Plasma-

Review Request 119794: Add button to change keyboard layout in the lockscreen

sting --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119758: Add option to DigitalClock applet to show date

://git.reviewboard.kde.org/media/uploaded/files/2014/08/13/b55b1ab2-98fc-4ab8-a64e-c4635574d3e1__clock3.png Settings dialog https://git.reviewboard.kde.org/media/uploaded/files/2014/08/13/7c309d90-6b4b-42a2-907e-98c0b47389e8__clock2.png Thanks, Dan Vrátil

Re: Review Request 119758: Add option to DigitalClock applet to show date

/7c309d90-6b4b-42a2-907e-98c0b47389e8__clock2.png Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119748: Properly align KickoffButtons to center

/3676134b-051f-4d19-93b7-d699ffa91288__kickoff-after2.png Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119758: Add option to DigitalClock applet to show date

should be in different font? And why? Yeah, why not? :) - Dan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119758/#review64449 ------- On Aug. 13, 2014, 12:51 p.m., Dan Vrátil wrote: > > --

Re: Review Request 119758: Add option to DigitalClock applet to show date

/b55b1ab2-98fc-4ab8-a64e-c4635574d3e1__clock3.png Settings dialog https://git.reviewboard.kde.org/media/uploaded/files/2014/08/13/7c309d90-6b4b-42a2-907e-98c0b47389e8__clock2.png Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request 119758: Add option to DigitalClock applet to show date

ak just when a day changes. - Dan ------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119758/#review64446 --- On Aug

Re: Review Request 119748: Properly align KickoffButtons to center

Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119758: Add option to DigitalClock applet to show date

/119758/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 119758: Add option to DigitalClock applet to show date

74ac640 applets/digital-clock/package/contents/ui/DigitalClock.qml 20babc3 applets/digital-clock/package/contents/ui/configAppearance.qml ab67e14 Diff: https://git.reviewboard.kde.org/r/119758/diff/ Testing --- Thanks, Dan Vrátil

Re: Review Request 119748: Properly align KickoffButtons to center

://git.reviewboard.kde.org/media/uploaded/files/2014/08/12/cc2752ee-9684-42e4-b146-d918351951f8__kickoff-before.png After 2 https://git.reviewboard.kde.org/media/uploaded/files/2014/08/13/3676134b-051f-4d19-93b7-d699ffa91288__kickoff-after2.png Thanks, Dan Vrátil

Re: Review Request 119748: Properly align KickoffButtons to center

https://git.reviewboard.kde.org/media/uploaded/files/2014/08/12/cc2752ee-9684-42e4-b146-d918351951f8__kickoff-before.png After 2 https://git.reviewboard.kde.org/media/uploaded/files/2014/08/13/3676134b-051f-4d19-93b7-d699ffa91288__kickoff-after2.png Thanks, Dan Vrátil

Re: Review Request 119748: Properly align KickoffButtons to center

r https://git.reviewboard.kde.org/media/uploaded/files/2014/08/12/dd8b7151-2ab1-43de-acaf-b010d57e3efb__kickoff-after.png After 2 https://git.reviewboard.kde.org/media/uploaded/files/2014/08/13/3676134b-051f-4d19-93b7-d699ffa91288__kickoff-after2.png Thanks, Dan Vrátil

Re: Review Request 119748: Properly align KickoffButtons to center

2014/08/12/cc2752ee-9684-42e4-b146-d918351951f8__kickoff-before.png After https://git.reviewboard.kde.org/media/uploaded/files/2014/08/12/dd8b7151-2ab1-43de-acaf-b010d57e3efb__kickoff-after.png Thanks, Dan Vrátil ___ Plasma-devel mailing list Pl

Review Request 119748: Properly align KickoffButtons to center when in vertical mode

After https://git.reviewboard.kde.org/media/uploaded/files/2014/08/12/dd8b7151-2ab1-43de-acaf-b010d57e3efb__kickoff-after.png Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119575: Fix krunner contacts pllugin

ntactsrunner.cpp <https://git.reviewboard.kde.org/r/119575/#comment44807> This will always be "true" (since the list is already filtered), so you can remove the condition and unindent the block runners/contacts/contactsrunner.cpp <https://git.reviewboard.kde.org/r/119575/#commen

Re: Review Request 119575: Fix krunner contacts pllugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119575/#review64153 --- Ship it! Looks OK now, thanks for the fix! - Dan Vrátil

Re: Review Request 119575: Fix krunner contacts pllugin

can remove the slot completely. - Dan Vrátil On Aug. 4, 2014, 12:40 a.m., Marc Deop wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.re

Re: Review Request 119575: Fix krunner contacts pllugin

> On Aug. 4, 2014, 8:24 a.m., Christian Mollekopf wrote: > > runners/contacts/contactsrunner.cpp, line 80 > > > > > > Calling exec is generally a bad idea, but I'm not sure wether you have > > another option with

Re: Review Request 119358: Fix position of ToolBox on second screen

;s on the left or on the top. Diffs - shell/shellcorona.cpp 60de8ff Diff: https://git.reviewboard.kde.org/r/119358/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/lis

Review Request 119358: Fix position of ToolBox on second screen

https://git.reviewboard.kde.org/r/119358/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110476: Call KNotification::close() when notification is closed in the applet

Diff: http://git.reviewboard.kde.org/r/110476/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Plasmate release plans?

Heya, since for KDE 4.10 all the Plasma development tools were moved to Plasmate, I wonder whether there are any plans to make an official release of Plasmate together with KDE 4.10. I believe that distributions will be interested in shipping Plasmate, so that KDE developers can keep using too

Review Request: Fix orientation of the arrow indicating grouped tasks

edf4be7 Diff: http://git.reviewboard.kde.org/r/107608/diff/ Testing --- Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Save and restore position of widgets in vertically-oriented FlowGroup

/ Testing --- Created a vertical Grouping Panel, placed a widget into middle, restarted plasma, widget position is correctly restored. Thanks, Dan Vrátil ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Display Configuration KCM design review

On Tuesday 02 of October 2012 16:23:02 Aaron J. Seigo wrote: > On Tuesday, October 2, 2012 14:29:24 Dan Vrátil wrote: > > I'm now working on new KCM. > > code > -- > where is the code currently? i find it is often a lot easier to comment (and > help out) when

Re: Display Configuration KCM design review

On Tuesday 02 of October 2012 15:17:20 Marco Martin wrote: > On Tuesday 02 October 2012, Dan Vrátil wrote: > > On Tuesday 02 of October 2012 14:52:50 Marco Martin wrote: > > > On Tuesday 02 October 2012, Marco Martin wrote: > > > > * no underline below the resolution

Re: Display Configuration KCM design review

On Tuesday 02 of October 2012 14:52:50 Marco Martin wrote: > On Tuesday 02 October 2012, Marco Martin wrote: > > * no underline below the resolution > > * could them be a bit spaced? now they are touching and looks quite > > cramped > > * green rounded rectanlgles doesn't look that good > > ah, an

Re: Display Configuration KCM design review

On Tuesday 02 of October 2012 14:50:01 Marco Martin wrote: > On Tuesday 02 October 2012, Dan Vrátil wrote: > > Hi! > > > > As some might notice [0], we are working with Alex Fiestas on new display > > management for KDE. I'm now working on new KCM. Aaron suggest

Re: Display Configuration KCM design review

On Tuesday 02 of October 2012 14:48:25 Sebastian Kügler wrote: > On Tuesday, October 02, 2012 14:29:24 Dan Vrátil wrote: > > As some might notice [0], we are working with Alex Fiestas on new display > > management for KDE. I'm now working on new KCM. Aaron suggested in > &

Display Configuration KCM design review

Hi! As some might notice [0], we are working with Alex Fiestas on new display management for KDE. I'm now working on new KCM. Aaron suggested in comments below the blog post that it would be nice to discuss design of the KCM with you, Plasma guys. As d_ed and few others suggested, I have rewr