Re: Review Request 119772: Simplify Klipper plasmoid and implement keyboard navigation

2014-08-13 Thread Daker Pinheiro
tps://git.reviewboard.kde.org/r/119772/#comment45050> Why not adding the case Qt.Key_Backspace on Switch? - Daker Pinheiro On Ago. 13, 2014, 6:55 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request: Port the Calculator applet to QML

2012-11-06 Thread Daker Pinheiro
Javascript file. It would keep the plasmoid modularized. A repeater could be used for creating the digits button. - Daker Pinheiro On Nov. 6, 2012, 2:54 a.m., Romário Rios wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request: Plasmate: Fix the coding style of the MetaData Editor

2012-11-05 Thread Daker Pinheiro
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107210/#review21443 --- Ship it! Ship It! - Daker Pinheiro On Nov. 5, 2012, 2:36

Re: Review Request: fix the binding loop issue

2012-10-17 Thread Daker Pinheiro
ssible using a Connections element instead of imperativey adding an event listener? I think it is cleaner. - Daker Pinheiro On Oct. 17, 2012, 7:29 a.m., Giorgos Tsiapaliokas wrote: > > --- > This is an automatically gener

Re: Review Request: Fix PlasmaExtras.DisappearAnimation

2012-10-15 Thread Daker Pinheiro
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106818/#review20421 --- Ship it! Ship It! - Daker Pinheiro On Oct. 13, 2012, 12:49

Re: Review Request: missing initializations in plasma

2012-10-10 Thread Daker Pinheiro
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106781/#review20155 --- Ship it! Ship It! - Daker Pinheiro On Oct. 10, 2012, 3:42

Re: Review Request: missing initializations in plasma

2012-10-10 Thread Daker Pinheiro
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106781/#review20154 --- Looks good. :-) - Daker Pinheiro On Oct. 10, 2012, 3:42

Re: Review Request: Add minimumWidth and minimumHeight properties to Plasma Button

2012-10-05 Thread Daker Pinheiro
<http://git.reviewboard.kde.org/r/106717/#comment15828> You could wrap lines here to improve readibility. - Daker Pinheiro On Oct. 3, 2012, 10:01 p.m., David Edmundson wrote: > > --- > This is an automatically gener

Re: Review Request: Weather Forecast QML port

2012-08-27 Thread Daker Pinheiro
ttp://git.reviewboard.kde.org/r/106225/#comment14339> +1 - Daker Pinheiro On Aug. 26, 2012, 7:59 p.m., Luis Gabriel Lima wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboar

Re: Review Request: Adding notify signals to FrameSvgItem

2012-08-13 Thread Daker Pinheiro
() - Daker Pinheiro On Aug. 11, 2012, 10:39 p.m., Luis Gabriel Lima wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: Mouse hover effect on ListItem

2012-08-09 Thread Daker Pinheiro
should aprove it. Exporting the containsMouse property as well as the background is another solution that doesn't breaks existing code. - Daker Pinheiro On Aug. 9, 2012, 12:08 a.m., Aleix Pol Gonzalez wrote: > > --- > This is an

Review Request: ScrollBar: fix update timer condition

2012-08-01 Thread Daker Pinheiro
condition for timer updates. Currently it triggers the action if the it's Diffs - plasma/declarativeimports/plasmacomponents/qml/ScrollBar.qml a5c338d Diff: http://git.reviewboard.kde.org/r/105817/diff/ Testing --- Thanks, Daker Pin