----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106924/#review20498 -----------------------------------------------------------
applet/contents/ui/Icon.qml <http://git.reviewboard.kde.org/r/106924/#comment16216> You should put parenthesis around complex expression in ternary operator. Like this: main.vertical ? (main.width * 1.4) : main.height applet/contents/ui/sharelikeconnect.qml <http://git.reviewboard.kde.org/r/106924/#comment16217> Is not possible using a Connections element instead of imperativey adding an event listener? I think it is cleaner. - Daker Pinheiro On Oct. 17, 2012, 7:29 a.m., Giorgos Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106924/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2012, 7:29 a.m.) > > > Review request for Plasma. > > > Description > ------- > > this patch fixes the binding loop issue. > > This patch has been made for the branch terietor/moveOfFallbackComponent > because master is frozen > > > Diffs > ----- > > applet/contents/ui/Icon.qml 04eaca6 > applet/contents/ui/sharelikeconnect.qml 882fa20 > > Diff: http://git.reviewboard.kde.org/r/106924/diff/ > > > Testing > ------- > > it works > > > Thanks, > > Giorgos Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
