D28662: KCM LookAndFeel check widgetStyle availability before applying it

crossi added a comment. In D28662#664211 , @heikobecker wrote: > This breaks the lookandfeel-kcm test. I saw this with 5.18.5 but it also fails on build.kde.org for a while, e.g.: > > 14:11:19 FAIL! : KcmTest::testKCMSave() Compared valu

D29402: KCM Fonts .fonts.conf was not updated and enforce consistency through UI

crossi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29402 AFFECTED FILES kcms/fonts/fontsaasettings.cpp kcms/fonts/font

D29285: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader()

This revision was automatically updated to reflect the committed changes. Closed by commit R119:9bbd2645626e: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader() (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde

D29285: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader()

crossi updated this revision to Diff 81567. crossi added a comment. consider Kai's comments REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29285?vs=81536&id=81567 REVISION DETAIL https://phabricator.kde.org/D29285 AFFECTED FILES kcms/icons/icon

D29285: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader()

crossi added a comment. In D29285#660158 , @broulik wrote: > Can this go into 5.18? Sure. INLINE COMMENTS > broulik wrote in main.cpp:307 > Isn't this redundant? i.e. doesn't `emitChange` emit do exactly this? This one sends a `notifyCh

D29285: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader()

crossi created this revision. crossi added reviewers: Plasma, bport. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY Changing the icon size should emits `iconLoaderSettingsChanged` as well REPOSITORY R119 Plas

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6d12d2d62607: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

crossi updated this revision to Diff 81014. crossi added a comment. clear the nitpicks REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27188?vs=81009&id=81014 REVISION DETAIL https://phabricator.kde.org/D27188 AFFECTED FILES kcms/notifications/k

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

crossi updated this revision to Diff 81009. crossi added a comment. This revision is now accepted and ready to land. Consider Kai's comments REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27188?vs=80894&id=81009 REVISION DETAIL https://phabricator

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

crossi planned changes to this revision. crossi added inline comments. INLINE COMMENTS > broulik wrote in ApplicationConfiguration.qml:45 > I've seen duplicate apps in this list, e.g. snap vs properly installed, so I > don't think you can rely on this. I guess I could use `rootIndex` instead, a

D29120: KCM Fonts disable AA items if they are immutable

crossi created this revision. crossi added reviewers: Plasma, ervin, bport, meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY If Anti Aliasing configuration is set to immutable, disable items in the KCM Si

D28662: KCM LookAndFeel check widgetStyle availability before applying it

This revision was automatically updated to reflect the committed changes. Closed by commit R119:17ef374a8cc4: KCM LookAndFeel check widgetStyle availability before applying it (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28662?vs

D28656: KCM LookAndFeel check if splash screen is provided before applying it.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:dacb3a8bdd20: KCM LookAndFeel check if splash screen is provided before applying it. (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D286

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

crossi updated this revision to Diff 80894. crossi added a comment. use qAsConst, indent REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27188?vs=80864&id=80894 REVISION DETAIL https://phabricator.kde.org/D27188 AFFECTED FILES kcms/notifications

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

crossi updated this revision to Diff 80864. crossi added a comment. maange reset to default application notification REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27188?vs=76004&id=80864 REVISION DETAIL https://phabricator.kde.org/D27188 AFFECTE

D27155: libnotificationmanager : add app-specific kconfig settings

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c56e12cc540d: libnotificationmanager : add app-specific kconfig settings (authored by crossi). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27155?vs=7706

D28629: [WIP] Port KCM to SettingStateBinding

crossi updated this revision to Diff 80611. crossi added a comment. Work on fonts and style REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28629?vs=79508&id=80611 REVISION DETAIL https://phabricator.kde.org/D28629 AFFECTED FILES kcms/baloo/pack

D27271: [kcms/colors] RFC: Accent Colours

crossi added a comment. These new properties can be managed by KConfig. It will automatically handle the read/write process and isSaveNeeded/isDefault status. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27271 To: cblack, #plasma, #vdg Cc: crossi, ngraha

D28662: KCM LookAndFeel check widgetStyle availability before applying it

crossi updated this revision to Diff 80067. crossi added a comment. Fix comments REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28662?vs=79597&id=80067 REVISION DETAIL https://phabricator.kde.org/D28662 AFFECTED FILES kcms/lookandfeel/kcm.cpp

D28744: Rewrite of the global shortcuts kcm

crossi added inline comments. INLINE COMMENTS > shortcutsmodel.h:83 > +void save(); > +bool needsSave(); > +bool isDefault(); should be const > shortcutsmodel.h:84 > +bool needsSave(); > +bool isDefault(); > + should be const REPOSITORY R119 Plasma Desktop REVISION DETA

D28662: KCM LookAndFeel check widgetStyle availability before applying it

crossi created this revision. crossi added reviewers: Plasma, ervin, bport, meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY BUG: 419552 - Some Global Theme may refer to breeze widget style with a lowe

D28656: KCM LookAndFeel check if splash screen is provided before applying it.

crossi created this revision. crossi added reviewers: Plasma, ervin, bport, meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY BUG: 414417 - While saving a new global theme, don't set splash screen if no

D28629: [WIP] Port KCM to SettingStateBinding

crossi updated this revision to Diff 79508. crossi added a comment. port KCM cursor theme REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28629?vs=79507&id=79508 REVISION DETAIL https://phabricator.kde.org/D28629 AFFECTED FILES kcms/baloo/packag

D28629: [WIP] Port KCM to SettingStateBinding

crossi updated this revision to Diff 79507. crossi added a comment. fix import REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28629?vs=79506&id=79507 REVISION DETAIL https://phabricator.kde.org/D28629 AFFECTED FILES kcms/baloo/package/contents/

D28629: [WIP] Port KCM to SettingStateBinding

crossi created this revision. crossi added reviewers: ervin, bport, meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY same as D27841 , depends on D27840

D28154: Add users KCM

crossi added inline comments. INLINE COMMENTS > kcm.cpp:73 > + > +void KCMUser::defaults() > +{ Not necessary to override if you don't add your specific implementatioin. > kcm.cpp:78 > + > +void KCMUser::load() > +{ same here > user.cpp:53 > +mName = value; > +nameChanged(value); > +}

D27482: Update kdeglobals config file for Breeze widgetStyle

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b37bac64f0f0: Update kdeglobals config file for Breeze widgetStyle (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27482?vs=75931&id=779

D27944: KCM Colors fix apply button always disabled

This revision was automatically updated to reflect the committed changes. Closed by commit R119:4d33b8276e00: KCM Colors fix apply button always disabled (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27944?vs=77282&id=77980 REVIS

D27944: KCM Colors fix apply button always disabled

crossi created this revision. crossi added reviewers: Plasma, ervin, bport, meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY BUG: 418604 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabrica

D27155: libnotificationmanager : add app-specific kconfig settings

crossi updated this revision to Diff 77068. crossi added a comment. rename group attribute to parentGroupName REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27155?vs=76834&id=77068 REVISION DETAIL https://phabricator.kde.org/D27155 AFFECTED FIL

D27155: libnotificationmanager : add app-specific kconfig settings

crossi updated this revision to Diff 76834. crossi added a comment. use parentGroup attribute REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27155?vs=75090&id=76834 REVISION DETAIL https://phabricator.kde.org/D27155 AFFECTED FILES libnotifica

D26834: libnotificationmanager : deprecate Settings ctor that takes a config

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ea08681efe5e: libnotificationmanager : deprecate Settings ctor that takes a config (authored by crossi). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D268

D26834: libnotificationmanager : deprecate Settings ctor that takes a config

crossi updated this revision to Diff 76380. crossi added a comment. constexpr REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26834?vs=76379&id=76380 REVISION DETAIL https://phabricator.kde.org/D26834 AFFECTED FILES libnotificationmanager/sett

D26834: libnotificationmanager : deprecate Settings ctor that takes a config

crossi updated this revision to Diff 76379. crossi added a comment. constexpr instead of static REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26834?vs=74116&id=76379 REVISION DETAIL https://phabricator.kde.org/D26834 AFFECTED FILES libnotifi

D26834: libnotificationmanager : deprecate Settings ctor that takes a config

crossi added a comment. @broulik any thoughts on this ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26834 To: crossi, ervin, broulik Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ng

D27482: Update kdeglobals config file for Breeze widgetStyle

crossi added inline comments. INLINE COMMENTS > bport wrote in style_widgetstyle_default_breeze.pl:8 > This will fix only for Breeze theme > This will fix existing case but we also need to fix the root cause (i.e. how > we end up with a lowercase name). Root cause was fixed by D27407

D27482: Update kdeglobals config file for Breeze widgetStyle

crossi added a comment. @ngraham do you confirm it is not working ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27482 To: crossi, ngraham, ervin, bport, meven, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampal

D27483: KCM look and feel : set proper default values for kwin kdecoration when applying global style

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6d3d3ffa76a5: KCM look and feel : set proper default values for kwin kdecoration when… (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

crossi updated this revision to Diff 76004. crossi marked 6 inline comments as done. crossi added a comment. Consider Kevin's comments REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27188?vs=75360&id=76004 REVISION DETAIL https://phabricator.kde.o

D27482: Update kdeglobals config file for Breeze widgetStyle

crossi added a comment. In D27482#614006 , @meven wrote: > Works : replace widgetStyle in group KDE and selects the application style in systemsettings; Does not edit widgetStyle in group General Thanks for the confirmation. > +1 on

D27482: Update kdeglobals config file for Breeze widgetStyle

crossi added a comment. Weird, I've tested again, and works like expected on my machine. Is it the `widgetStyle` entry from `KDE` group ? I have also an entry named `widgetStyle` in group `General` but we are not interested in that one. REPOSITORY R119 Plasma Desktop REVISION DET

D27482: Update kdeglobals config file for Breeze widgetStyle

crossi added a comment. This fix the issue for Breeze theme, but according to bug description (https://bugs.kde.org/show_bug.cgi?id=417515) some configuration file may also have `oxygen` instead of `Oxygen` REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2748

D27482: Update kdeglobals config file for Breeze widgetStyle

crossi added a comment. In D27482#613699 , @ngraham wrote: > How do I trigger this to get run? Restarting plasmashell or opening the Style KCM didn't seem to do it. To run the update script, just apply the patch and rebuild plasma-desktop

D27483: KCM look and feel : set proper default values for kwin kdecoration when applying global style

crossi updated this revision to Diff 75933. crossi added a comment. restore blank line REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27483?vs=75932&id=75933 REVISION DETAIL https://phabricator.kde.org/D27483 AFFECTED FILES kcms/lookandfeel/kcm

D27483: KCM look and feel : set proper default values for kwin kdecoration when applying global style

crossi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY BUG 397595 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27483 AFFECTED FILES kcms/lookandfeel/

D27482: Update kdeglobals config file for Breeze widgetStyle

crossi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY Following D27407 provide kconf update script to fix user configuration for widgetStyle when Bree

D27407: Breeze widgetStyle value is Breeze

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c7c190488e46: Breeze widgetStyle value is Breeze (authored by crossi). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27407?vs=75699&id=75909 REVISION DET

D27407: Breeze widgetStyle value is Breeze

crossi added a comment. Will do in a separate commit. I guess it's more or less related to the KCM Style. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27407 To: crossi, ervin, bport, meven, mart, davidedmundson, ngraham Cc: ngraham, plasma-devel, Orage,

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

crossi added inline comments. INLINE COMMENTS > fontsaasettings.cpp:305 > +{ > +if(dpi() == newDPI) { > +return; add space between `if` and `(` please REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27156 To: bport, #plasma, ervin, crossi, meven Cc:

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

crossi added a comment. looks ok to me REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27395 To: meven, bport, ervin, crossi Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeym

D27407: Breeze widgetStyle value is Breeze

crossi added a comment. Sounds like it will provide a complete fix, the update script will fix the issue without requiring the user to reset its application style, and this patch will ensure it won't come back. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org

D27407: Breeze widgetStyle value is Breeze

crossi added a comment. In D27407#611723 , @ngraham wrote: > This doesn't fix the problem for me until I actually apply a Global Theme. Until I do that, the current widget style remaing un-highlighted in the Style KCM. It does fix the issue for

D27407: Breeze widgetStyle value is Breeze

crossi added a subscriber: ngraham. crossi added a comment. @ngraham my bad, didn't see your edit ^^ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27407 To: crossi, ervin, bport, meven, mart, davidedmundson Cc: ngraham, plasma-devel, Orage, LeGast00n, The-

D27407: Breeze widgetStyle value is Breeze

crossi created this revision. crossi added reviewers: ervin, bport, meven, mart, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY BUG: 414885 REPOSITORY R120 Plasma Workspace REVISION DETAIL

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

crossi added inline comments. INLINE COMMENTS > componentchooseremail.cpp:154 > } else { > pSettings->setSetting(KEMailSettings::ClientProgram, > emailClientService->storageId()); > pSettings->setSetting(KEMailSettings::ClientTerminal, > emailClientService->terminal() ? Q

D27384: [KCM Fonts] force need save to false during load to avoid state to be true too early

crossi accepted this revision. crossi added a comment. I can confirm this fix the issue here. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27384 To: bport, #plasma, broulik, ervin, crossi, meven, ngraham, davidedmundson, The-Feren-OS-Dev Cc: The-Feren-OS-D

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

crossi updated this revision to Diff 75360. crossi added a comment. Check before assign and emit changed REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27188?vs=75093&id=75360 REVISION DETAIL https://phabricator.kde.org/D27188 AFFECTED FILES kc

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

crossi created this revision. crossi added reviewers: Plasma, ervin, broulik, bport, meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY App-specific notifications' behavior are now managed with KConfigXT. The

D27155: libnotificationmanager : add app-specific kconfig settings

crossi updated this revision to Diff 75090. crossi added a comment. Remove specific default values, will rely on shipped settings. Fix comment at EOL that makes the entry not read. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27155?vs=74997&id=7

D27155: libnotificationmanager : add app-specific kconfig settings

crossi planned changes to this revision. crossi added a comment. Will remove the defaults and rely on the rules file. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27155 To: crossi, ervin, broulik, bport, meven Cc: plasma-devel, Orage, LeGast00n, The-Feren

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

crossi added inline comments. INLINE COMMENTS > fonts.cpp:201 > +Q_ASSERT(dpiItem && dpiWaylandItem && antiAliasingItem); > +if (dpiItem->isSaveNeeded() || dpiWaylandItem->isSaveNeeded() || > antiAliasingItem) { > +emit aliasingChangeApplied(); antiAliasingItem->isSaveNeeded() ?

D27155: libnotificationmanager : add app-specific kconfig settings

crossi created this revision. crossi added reviewers: ervin, broulik, bport, meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY Provide a kcfg for app-specific notifications with kconfig. Require D27059

D27073: [Colors KCM] Consider settings dirty if currently active scheme is edited

crossi accepted this revision. crossi added a comment. This revision is now accepted and ready to land. Both patch applied and tested, it works for me. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27073 To: broulik, #plasma, crossi, ervin Cc: plasma-devel,

D26834: libnotificationmanager : deprecate Settings ctor that takes a config

crossi updated this revision to Diff 74116. crossi added a comment. Use config param in ctor. Avoid global static object as per library code policy. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26834?vs=74096&id=74116 REVISION DETAIL https://

D26834: libnotificationmanager : deprecate Settings ctor that takes a config

crossi created this revision. crossi added reviewers: ervin, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY Unused REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D268

D26653: KCM Joystick : restore Default button to allow reset calibration.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:05d380ace439: KCM Joystick : restore Default button to allow reset calibration. (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26653?vs

D26083: KCM Notifications : disable settings that are immutable

crossi abandoned this revision. crossi added a comment. done in D26048 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26083 To: crossi, #plasma, ervin, mart, davidedmundson, broulik Cc: meven, bport, plasma-devel, Orage, L

D26048: KCM Notification port to ManagedConfigModule

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5a1d74059c09: KCM Notification port to ManagedConfigModule (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26048?vs=74037&id=74081 REVI

D26047: Expose KConfig settings to allow registration in KCM Notification

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ee3176ce5641: Expose KConfig settings to allow registration in KCM Notification (authored by crossi). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26047?

D26048: KCM Notification port to ManagedConfigModule

crossi updated this revision to Diff 74037. crossi added a comment. Not necessary anymore REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26048?vs=74028&id=74037 REVISION DETAIL https://phabricator.kde.org/D26048 AFFECTED FILES kcms/notification

D26048: KCM Notification port to ManagedConfigModule

crossi added a comment. In D26048#598157 , @ervin wrote: > Wondering, do we still need "settings"? I guess it's for the per-app settings? Yes, for app specific settings. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabric

D26048: KCM Notification port to ManagedConfigModule

crossi updated this revision to Diff 74028. crossi added a comment. Following new approach in D26047 , also taking into immutability is much more straightforward. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D260

D26047: Expose KConfig settings to allow registration in KCM Notification

crossi updated this revision to Diff 74023. crossi added a comment. Remove unneeded forward declaration REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26047?vs=74021&id=74023 REVISION DETAIL https://phabricator.kde.org/D26047 AFFECTED FILES l

D26047: Expose KConfig settings to allow registration in KCM Notification

crossi updated this revision to Diff 74021. crossi added a comment. Following discussion with @ervin and @broulik, export generated KConfig settings, remove singleton option. The KCM will have its own KConfig settings' instance like other KCMs. REPOSITORY R120 Plasma Workspace CHANGES SIN

D26683: KCM Notifications : fix applications behavior not properly updated in KCM

This revision was automatically updated to reflect the committed changes. Closed by commit R119:e236b520a720: KCM Notifications : fix applications behavior not properly updated in KCM (authored by crossi). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26683?vs=73596&id=73609#toc REPOSIT

D26683: KCM Notifications : fix applications behavior not properly updated in KCM

crossi created this revision. crossi added reviewers: Plasma, ervin, bport, meven, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26683 AFF

D26653: KCM Joystick : restore Default button to allow reset calibration.

crossi created this revision. crossi added reviewers: Plasma, ervin, bport, meven, mart, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY Since there is no configuration saved, all button are hidde

D26082: Provide a method to query isImmutable attribute of a setting related to notification.

crossi updated this revision to Diff 73216. crossi added a comment. space REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26082?vs=73215&id=73216 REVISION DETAIL https://phabricator.kde.org/D26082 AFFECTED FILES libnotificationmanager/settings

D26082: Provide a method to query isImmutable attribute of a setting related to notification.

crossi updated this revision to Diff 73215. crossi added a comment. Add API documentation REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26082?vs=71783&id=73215 REVISION DETAIL https://phabricator.kde.org/D26082 AFFECTED FILES libnotification

D26047: Expose KConfig settings to allow registration in KCM Notification

crossi updated this revision to Diff 73214. crossi added a comment. Add API documentation REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26047?vs=71676&id=73214 REVISION DETAIL https://phabricator.kde.org/D26047 AFFECTED FILES libnotification

D25843: Restore notifier on AnimationDurationFactor that was lost during KConfig XT port

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6ea1971ed13c: Restore notifier on AnimationDurationFactor that was lost during KConfig XT port (authored by crossi). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25843?vs=71183&id=72868#toc

D26100: [KCM/Component] Convert to KConfigXT browser cfg and make default and reinit buttons work properly

crossi added a comment. some nitpicks, otherwise looks good. INLINE COMMENTS > componentchooser.h:42 > virtual void defaults()=0; > +virtual bool isDefaults() { > +return false; Can you make it const please. > componentchooserbrowser.cpp:110 > > -const auto &browsers

D26047: Expose KConfig settings to allow registration in KCM Notification

crossi added inline comments. INLINE COMMENTS > broulik wrote in settings.h:343 > Not a fan of this becoming public API Maybe not the best approach. Any suggestion to access the KCoreConfigSkeleton encapsulated to register them in the KCM's ConfigModule ? REPOSITORY R120 Plasma Workspace R

D26082: Provide a method to query isImmutable attribute of a setting related to notification.

crossi created this revision. crossi added reviewers: Plasma, Frameworks, ervin, mart, davidedmundson, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY Allow the KCM Notifications to query the immutable

D26083: KCM Notifications : disable settings that are immutable

crossi created this revision. crossi added reviewers: Plasma, ervin, mart, davidedmundson, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY Need D26082 to work. TEST

D26039: [Plasma Style KCM] Add search filter

crossi added a comment. In D26039#579546 , @davidre wrote: > - Only move to the next theme if the current selected one is marked for deletion > > FYI I could spot this same bug in the colors kcm. Will fix after this Looks good to me

D26039: [Plasma Style KCM] Add search filter

crossi added a comment. In D26039#579253 , @davidre wrote: > - Reinstate isSaveNeeded > - Fix initial index and pendingDeletion I can confirm these issue are fixed. Still one concern, when setting an item for pending deletion, it mo

D26039: [Plasma Style KCM] Add search filter

crossi added a comment. Some concern here as I tested the patch. The filter is working but the implementation breaks some functionality. - At initialization, the current theme is not selected in the grid view. - When settings a theme for deletion, it does not activate the apply button

D26045: Add immutability to KCM Icons

crossi added inline comments. INLINE COMMENTS > broulik wrote in main.qml:55 > Shouldn't this be set on the grid view then, i.e. the `view.enabled` stuff > Marco fixed a while back? Yes it should. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26045 To: bport

D26052: KCM Cursor Theme : Use ManagedConfigModule

crossi added inline comments. INLINE COMMENTS > kcmcursortheme.cpp:367 > { > m_settings->save(); > +setPreferredSize(m_settings->cursorSize()); Now you should simply call ManagedConfigModule::save(); instead > kcmcursortheme.cpp:384 > { > m_settings->load(); > +setPreferredS

D24846: Port kcm icons to kconfigxt

crossi added inline comments. INLINE COMMENTS > iconsmodel.cpp:29 > #include > +#include > include not used REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24846 To: bport, ervin, mart, #plasma, crossi Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev

D26048: KCM Notification port to ManagedConfigModule

crossi created this revision. crossi added reviewers: Plasma, ervin, bport, mart, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY Require D26046 and D26047

D26047: Expose KConfig settings to allow registration in KCM Notification

crossi created this revision. crossi added reviewers: Plasma, Frameworks, ervin, bport, davidedmundson, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY For KCM Notification, allow to register the generated

D25792: Add notifiers to workspace options kcfg

crossi added a comment. Thanks @davidedmundson for spotting this regression. Actually, only AnimationDurationFactor should notify. From D25586 See kcms/workspaceoptions/workspaceoptions.cpp line 221. REPOSITORY R119 Plasma Desktop REVISION

D25843: Restore notifier on AnimationDurationFactor that was lost during KConfig XT port

crossi created this revision. crossi added reviewers: Plasma, ervin, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY Following D25792 and D25586

D25525: KCM Style : take into account immutable properties

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a7089ca61db2: KCM Style : take into account immutable properties (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25525?vs=70351&id=70559

D25523: KCM LookAndFeel : take into account immutable property

This revision was automatically updated to reflect the committed changes. Closed by commit R119:277bb04e7455: KCM LookAndFeel : take into account immutable property (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25523?vs=70295&id=7

D25586: KCM WorkspaceOptions port to KConfigXT. Take into account immutable properties

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a3b97eaa91c6: KCM WorkspaceOptions port to KConfigXT. Take into account immutable properties (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.

D25524: KCM KSplash : take into account immutable property

This revision was automatically updated to reflect the committed changes. Closed by commit R119:dd9a6da45f9e: KCM KSplash : take into account immutable property (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25524?vs=70296&id=70558

D25526: KCM launch feedback : take into account immutable properties

This revision was automatically updated to reflect the committed changes. Closed by commit R119:2b2383cc77f6: KCM launch feedback : take into account immutable properties (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25526?vs=7030

  1   2   >