crossi added a comment.

  In D26039#579253 <https://phabricator.kde.org/D26039#579253>, @davidre wrote:
  
  > - Reinstate isSaveNeeded
  > - Fix initial index and pendingDeletion
  
  
  I can confirm these issue are fixed.
  
  Still one concern, when setting an item for pending deletion, it moves the 
current index to the next item after the one marked for deletion. See the 
attachement below.
  
  Current style is Breeze Dark, I want to delete Nordic style.
  F7823665: D26039_before_delete.png <https://phabricator.kde.org/F7823665>
  
  Once marked for deletion, Oxygen style is now selected
  F7823668: D26039_pending_delete.png <https://phabricator.kde.org/F7823668>

REPOSITORY
  R119 Plasma Desktop

BRANCH
  filtermodel

REVISION DETAIL
  https://phabricator.kde.org/D26039

To: davidre, #plasma, #vdg, broulik, ndavis
Cc: ervin, ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to