Re: Review Request: Molmasscalcuation for the kalzium-engine

2010-03-10 Thread Carsten Niehaus
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3228/#review4454 --- Ship it! Looks good to me. Thanks for taking care! - Carsten On 20

Moving libconversation to kdereview

2009-07-23 Thread Carsten Niehaus
Moin moin With the commits r1001601, r1001602,r1001603 and r1001608 I moved the lib to kde-review. I hope I did everything correctly... I never moved a lib... There is one CMake-issue left which I am unable to fix: For some reasons I am getting this issue: kdeplasma-addons/libs/plasmaweather/w

Re: shared lib: conversion-lib in Plasma

2009-07-19 Thread Carsten Niehaus
Moin moin > > > I don't think having such a library in kdelibs is such a bad idea, > > > actually. > > > > > > By policy, we usually require at least 2 users of the library before it > > > can be added into kdelibs. But this seems like something worth > > > having around in kdelibs to me. > > >

Re: Review Request: Density unit conversion

2009-07-16 Thread Carsten Niehaus
> On 2009-06-02 08:44:36, Aaron Seigo wrote: > > as this introduces new strings (and arguably a new feature :) it will have > > to wait for the 4.4 dev cycle to open up. > > > > in the meantime, the i18n here looks very wrong. shouldn't it be: > > > > i18np("density unit", "ounce per cubic foo

Re: Plasma Unit conversion library

2009-07-15 Thread Carsten Niehaus
Moin >> I'm not sure how to proceed when multiple projects in KDE start to >> use the same lib so I let others to answer to that. > they get moved somewhere common, though i don't know where this one > would go. it has kdelibs deps (so kde-support is out), i don't know if > it really fits into k