Re: Can we remove or quiet down the commit bot in the chatrooms

Or in the territory of using a Matrix bot to post commits, I could add Matrix capabilities to my bot [1] that's already been monitoring invent.kde.org for roughly a year now and has been posting notifications to Telegram for that time. [1] https://invent.kde.org/cblack/kijetesantakalu_lukin Carl

T13927: Pop shell in KDE Plasma

cblack added a comment. In T13927#245978 , @ngraham wrote: > What is "pop shell"? Pop Shell is the name of the extension that system76 ships with their GNOME shell to make the window management closer to tiling WMs or Android/iPadOS TASK

D29876: ScreenPool: Store primary connector separately

cblack added a comment. Thanks for the patch, however we use GitLab now for contributing code. Would you mind opening this as an MR at https://invent.kde.org/plasma/plasma-workspace? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29876 To: genpfault C

D27271: [kcms/colors] RFC: Accent Colours

cblack abandoned this revision. cblack added a comment. https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/305 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27271 To: cblack, #plasma, #vdg Cc: crossi, ngraham, The-Feren-OS-Dev, plasma-devel, Ora

D27271: [kcms/colors] RFC: Accent Colours

cblack added a comment. oooh man, this'll be a doozy to rebase :D REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27271 To: cblack, #plasma, #vdg Cc: crossi, ngraham, The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ra

D27271: [kcms/colors] RFC: Accent Colours

cblack added a comment. In D27271#676512 , @ngraham wrote: > Could you move this and the dependent patches to Gitlab? It would be good to get this in for 5.21. Sure REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.

D29466: [applets/appmenu] Add search to global application menu

cblack added a comment. In D29466#676411 , @ngraham wrote: > Putting it in KRunner could make at least a little bit of sense if it worked everywhere--i.e. with in-window menubars as well. However since it does not, I think the current location m

D27669: [kstyle] Tools area

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R31:ea978ea6eb36: [kstyle] Tools area (authored by cblack). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://pha

D27669: [kstyle] Tools area

cblack added a comment. In D27669#673112 , @ndavis wrote: > what are some ways the issue of toolbar colors not being perfectly in sync with titlebar colors could be fixed or worked around? When animating? Wayland. REPOSITORY R31 Breeze

D29466: [applets/appmenu] Add search to global application menu

cblack added inline comments. INLINE COMMENTS > nicolasfella wrote in appmenumodel.h:70 > const actions are needed as non-const REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29466 To: cblack, #plasma, #vdg Cc: nicolasfella, gikari, plasma-devel, Orage, LeGa

D29466: [applets/appmenu] Add search to global application menu

cblack updated this revision to Diff 83175. cblack marked 5 inline comments as done. cblack added a comment. Address feedback REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29466?vs=82144&id=83175 BRANCH arcpatch-D29466 REVISION DETAIL https:

D28154: Add users KCM

cblack closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28154 To: cblack, #plasma, #vdg, ngraham Cc: ltoscano, mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-deve

D28154: Add users KCM

cblack updated this revision to Diff 83095. cblack added a comment. Rename to kcm_users REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=83079&id=83095 BRANCH arcpatch-D28154_1 REVISION DETAIL https://phabricator.kde.org/D28154 AFFECTED

D29395: Refactor MediaController

cblack updated this revision to Diff 83084. cblack added a comment. Guess that segfault wants to resolve itself :D REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29395?vs=83073&id=83084 BRANCH arcpatch-D29395_1 REVISION DETAIL https://phabric

D28154: Add users KCM

cblack added inline comments. INLINE COMMENTS > broulik wrote in UserDetailsPage.qml:97 > Pfp? profile picture > broulik wrote in UserDetailsPage.qml:219 > Is this `RowLayout` needed? it's a convenience for the default alignment of a layout (`Qt.AlignVCenter | Qt.AlignLeft`) REPOSITORY R11

D29395: Refactor MediaController

cblack added inline comments. INLINE COMMENTS > broulik wrote in Media.qml:6 > Make this a `QtObject` Seems to cause a segfault with the data source. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29395 To: cblack, #plasma Cc: iasensio, broulik, trmdi, ngrah

D29464: [applets/appmenu] Hide old menu before showing new menu

cblack closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29464 To: cblack, #plasma, #kwin, broulik Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, l

D29464: [applets/appmenu] Hide old menu before showing new menu

cblack updated this revision to Diff 83083. cblack added a comment. Only do that on Wayland REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29464?vs=82041&id=83083 BRANCH arcpatch-D29464 REVISION DETAIL https://phabricator.kde.org/D29464 AFFE

D28154: Add users KCM

cblack updated this revision to Diff 83079. cblack added a comment. Focus the stackSwitcher when opening the sheet REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=83074&id=83079 BRANCH arcpatch-D28154_1 REVISION DETAIL https://phabricat

D27669: [kstyle] Tools area

cblack updated this revision to Diff 83075. cblack added a comment. Properly determine if tools area should be drawn on QDialogs with auto set REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=81137&id=83075 BRANCH arcpatch-D27669_2 REVISION DETAIL

D28154: Add users KCM

cblack updated this revision to Diff 83074. cblack marked 17 inline comments as done. cblack added a comment. Address code concerns; add escape keyboard gesture REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=82214&id=83074 BRANCH arcpatch

D29395: Refactor MediaController

cblack updated this revision to Diff 83073. cblack marked 8 inline comments as done. cblack added a comment. Address feedback REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29395?vs=81831&id=83073 BRANCH arcpatch-D29395 REVISION DETAIL https:

D29395: Refactor MediaController

cblack added inline comments. INLINE COMMENTS > broulik wrote in ExpandedRepresentation.qml:99 > Unrelated cleanup a cleanup is unrelated in a cleanup patch? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29395 To: cblack, #plasma Cc: broulik, trmdi, ngraham

D29465: [applets/appmenu] Improve menu feel

This revision was automatically updated to reflect the committed changes. Closed by commit R120:bf337f552a02: [applets/appmenu] Improve menu feel (authored by cblack). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29465?vs=82043&id=83069 REVISION DE

D29694: Introduce Avatar component

cblack added a comment. This is being moved to GitLab. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29694 To: cblack, #kirigami, #vdg, mart Cc: mart, ratijastk, ngraham, filipf, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ahiemstra, davidedmunds

D29694: Introduce Avatar component

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R169:cce0214570af: Introduce Avatar component (authored by cblack). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D28873: Add SwipeNavigator component

cblack abandoned this revision. cblack added a comment. Moving to a GitLab MR REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28873 To: cblack, #kirigami, #vdg Cc: EspiDev, squeakypancakes, ngraham, niccolove, mart, ndavis, camiloh, plasma-devel, fbampaloukas, GB_2

D28873: Add SwipeNavigator component

cblack added a comment. In D28873#672598 , @mart wrote: > what should happen in this case? > F8331924: Screenshot_20200518_114607.png My answer would be "set a minimum window size", though on mobi

D28873: Add SwipeNavigator component

cblack updated this revision to Diff 82965. cblack added a comment. Improve the small toolbar REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28873?vs=82962&id=82965 BRANCH cblack/lateral (branched from master) REVISION DETAIL https://phabricator.kde.

D28873: Add SwipeNavigator component

cblack updated this revision to Diff 82962. cblack added a comment. Rebase on master REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28873?vs=80804&id=82962 BRANCH cblack/lateral (branched from master) REVISION DETAIL https://phabricator.kde.org/D2887

D29694: Introduce Avatar component

cblack updated this revision to Diff 82961. cblack added a comment. Unsplit template and control for documentation purposes REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29694?vs=82957&id=82961 BRANCH cblack/avatar (branched from master) REVISION DETA

D29694: Introduce Avatar component

cblack added inline comments. INLINE COMMENTS > mart wrote in Avatar.qml:52 > enum values should be written and explained here F8323278: ksnip_20200515-114734.png Unfortunately; splitting into a template throws documentation out of the window; which is wh

D29694: Introduce Avatar component

cblack updated this revision to Diff 82957. cblack marked 3 inline comments as done. cblack added a comment. Split into a template; make borders customisable REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29694?vs=82783&id=82957 BRANCH cblack/avatar (br

D29694: Introduce Avatar component

cblack added inline comments. INLINE COMMENTS > mart wrote in kirigamiplugin.cpp:259 > I don't like this, as even tough is called "private" is really public api as > there isn't really any way to make a c++ type not accessible. > nothing in that c++ class seems really to be necessary to be c++

D28873: Add SwipeNavigator component

cblack added a comment. In D28873#671043 , @ngraham wrote: > In that window, there's plenty of space for the component to expand horizontally. I would prefer to avoid scrolling tabs; their interaction is usually not great. It's collapsin

D29694: Introduce Avatar component

cblack updated this revision to Diff 82783. cblack added a comment. Avoid trying to display initials of non-Latin characters REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29694?vs=82780&id=82783 BRANCH cblack/avatar (branched from master) REVISION DET

D29694: Introduce Avatar component

3> (2x scale) Row { spacing: Kirigami.Units.smallSpacing Kirigami.Avatar { name: "Carson Black" } Kirigami.Avatar { name: "Marco Martin" } Kirigami.Avatar { name: "Carl

D29288: Improve PageRouter API

This revision was automatically updated to reflect the committed changes. Closed by commit R169:db704d344b2c: Improve PageRouter API (authored by cblack). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29288?vs=81555&id=82567 REVISION DETAIL https://phabric

D29637: Introduce ImageColors

cblack added inline comments. INLINE COMMENTS > colorutils.h:182 > +/** > + * Returns the Cielab "Chroma" of the color which is a slightly better > quantificator for how much a color appears > https://en.wikipedia.org/wiki/Colorfulness > + * This is how much a color looks diffenent

D29637: Introduce ImageColors

cblack added inline comments. INLINE COMMENTS > imagecolorstest.qml:1 > + > +import QtQuick 2.12 There's no test cases here, this should probably go in examples. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29637 To: mart, #kirigami Cc: cblack, plasma-devel, fbamp

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

cblack added a comment. While this is neat, I'm fairly sure that creating the CSS for this in a manner that works across themes is going to be hard if not impossible. Even our own Breeze GTK uses palette swaps rather than unique pixmaps for every state. REPOSITORY R99 KDE Gtk Configuration

D29535: Change panel thickness adjustment UI to use a SpinBox

cblack added inline comments. INLINE COMMENTS > ToolBar.qml:119-120 > + > +from: 2 > +to: 960 > +stepSize: 2 These values seem arbitrary. Could it be possible to base off the screen dimensions? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phab

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

cblack added a comment. In D29514#665869 , @ngraham wrote: > Hmm, on my system, the file is located at `/usr/src/xserver/include/xserver-properties.h`, and this doesn't seen to find it: > > -- The following features have been disabled: >

D28154: Add users KCM

cblack updated this revision to Diff 82214. cblack marked 4 inline comments as done. cblack added a comment. Parent temporary file to the application REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=82212&id=82214 BRANCH arcpatch-D28154 RE

D28154: Add users KCM

cblack updated this revision to Diff 82212. cblack added a comment. realize you forgot to change the name of the argument in the body as well REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=82211&id=82212 BRANCH arcpatch-D28154 REVISION D

D28154: Add users KCM

cblack updated this revision to Diff 82211. cblack added a comment. Refine method signature and add a comment for less ambiguity REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=82210&id=82211 BRANCH arcpatch-D28154 REVISION DETAIL https

D28154: Add users KCM

cblack added inline comments. INLINE COMMENTS > davidedmundson wrote in kcm.cpp:121 > Normally the app creating a temp file would clean it up. > > A quick fix would be > file = new QTemporaryFile(this); > > It's sort of leaking the object, but on exit it'll tidy everything up. that looks like

D28154: Add users KCM

cblack updated this revision to Diff 82210. cblack marked an inline comment as done. cblack added a comment. Parent the dynamically created user to the model REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=82209&id=82210 BRANCH arcpatch-D2

D29288: Improve PageRouter API

cblack added inline comments. INLINE COMMENTS > cblack wrote in pagerouter.h:443 > It could possibly be a list, but not of pure strings. You want to be able to > watch a list of routes? Watching a list of routes is probably going to result in both clunky code and clunky API design in return fo

D28154: Add users KCM

cblack updated this revision to Diff 82209. cblack marked 4 inline comments as done. cblack added a comment. Address some of the code feedback from d_ed REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=82158&id=82209 BRANCH arcpatch-D28154

D28154: Add users KCM

cblack marked 5 inline comments as done. cblack added inline comments. INLINE COMMENTS > davidedmundson wrote in kcm.cpp:94 > what's this for? used as a hook for QML to know when the KCM needs to apply > davidedmundson wrote in kcm.cpp:97 > This is an odd method name. > > I don't really unders

D29288: Improve PageRouter API

cblack added inline comments. INLINE COMMENTS > mart wrote in pagerouter.h:443 > could this be just a QStringList? It could possibly be a list, but not of pure strings. You want to be able to watch a list of routes? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D292

D28154: Add users KCM

cblack updated this revision to Diff 82158. cblack marked 9 inline comments as done. cblack added a comment. Address code and icon feedback REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=82150&id=82158 BRANCH arcpatch-D28154 REVISION DET

D29081: [QStyle] Make menu titles look less like menu items

cblack added a comment. In D29081#665203 , @ndavis wrote: > Big +1 to the idea, but this shouldn't use `darker()` because that won't look right in Breeze Dark. Personally, I think this will look fine when always using `darker()`. REPOSIT

D28154: Add users KCM

cblack updated this revision to Diff 82150. cblack added a comment. Fix faceValid checking REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=82137&id=82150 BRANCH arcpatch-D28154 REVISION DETAIL https://phabricator.kde.org/D28154 AFFECTE

D29466: [applets/appmenu] Add search to global application menu

cblack updated this revision to Diff 82144. cblack added a comment. Clear search text on application change REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29466?vs=82141&id=82144 BRANCH cblack/appmenu-search (branched from master) REVISION DETA

D29466: [applets/appmenu] Add search to global application menu

cblack updated this revision to Diff 82141. cblack added a comment. Add better non-Wayland guards REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29466?vs=82138&id=82141 BRANCH cblack/appmenu-search (branched from master) REVISION DETAIL https

D29466: [applets/appmenu] Add search to global application menu

cblack added a comment. In D29466#665145 , @gikari wrote: > Is it possible to integrate the search into the help menu, if it exists already or create an entry for it. Much like macOS does. > F8290151: Screenshot_20200506_214642.png

D29466: [applets/appmenu] Add search to global application menu

cblack created this revision. cblack added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack updated this revision to Diff 82125. cblack added a comment. cblack updated this revision to Diff 82138. cblack added a dependency: D29486: xdgshellclie

D28154: Add users KCM

cblack updated this revision to Diff 82137. cblack added a comment. begone, kule REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=82135&id=82137 BRANCH arcpatch-D28154 REVISION DETAIL https://phabricator.kde.org/D28154 AFFECTED FILES

D28154: Add users KCM

cblack updated this revision to Diff 82135. cblack added a comment. Make sure arc diff does what it should REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=82048&id=82135 BRANCH arcpatch-D28154 REVISION DETAIL https://phabricator.kde.org

D29476: WIP: Port klipper to use wayland clipboard

cblack added inline comments. INLINE COMMENTS > systemclipboard.cpp:61 > + > +#include "qwayland-wlr-data-control-unstable-v1.h" > + Is there a reason this `#include` is all the way down here instead of at the top of the file? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabr

D28154: Add users KCM

cblack added inline comments. INLINE COMMENTS > ngraham wrote in main.qml:54 > Could this be a BasicListItem with a title and subtitle, or is that not > possible because you can't render the avatar+circle into an image source to > feed it? Not possible, AFAIK. At least not as long as grabbing

D28154: Add users KCM

cblack updated this revision to Diff 82048. cblack added a comment. Address code issue and add reset functionality REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=82046&id=82048 BRANCH arcpatch-D28154 REVISION DETAIL https://phabricator

D28154: Add users KCM

cblack updated this revision to Diff 82046. cblack marked an inline comment as done. cblack added a comment. Fix item alignment REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=82025&id=82046 BRANCH arcpatch-D28154 REVISION DETAIL https:

D29465: [applets/appmenu] Improve menu feel

cblack created this revision. cblack added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY The appmenu applet now accurately replicates the hover behaviour of a regular menubar. TEST PLAN

D29464: [applets/appmenu] Hide old menu before showing new menu

cblack added a comment. FWIW, I don't notice the flickering behaviour mentioned in the comment. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29464 To: cblack, #plasma, #kwin Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D29464: [applets/appmenu] Hide old menu before showing new menu

cblack created this revision. cblack added reviewers: Plasma, KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY Hiding the old menu after the new menu is shown isn't possible on Wayland: qt.qpa.wayland

D28154: Add users KCM

cblack updated this revision to Diff 82025. cblack marked 4 inline comments as done. cblack added a comment. Address feedback REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=82020&id=82025 BRANCH arcpatch-D28154 REVISION DETAIL https://

D28154: Add users KCM

cblack updated this revision to Diff 82020. cblack added a comment. Fix permission denied bouncing REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=82016&id=82020 BRANCH arcpatch-D28154 REVISION DETAIL https://phabricator.kde.org/D28154

D28154: Add users KCM

cblack updated this revision to Diff 82016. cblack added a comment. Add Messages.sh REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=82015&id=82016 BRANCH arcpatch-D28154 REVISION DETAIL https://phabricator.kde.org/D28154 AFFECTED FILES

D28154: Add users KCM

cblack updated this revision to Diff 82015. cblack added a comment. Add Messages.sh REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=82012&id=82015 BRANCH arcpatch-D28154 REVISION DETAIL https://phabricator.kde.org/D28154 AFFECTED FILES

D28154: Add users KCM

cblack updated this revision to Diff 82012. cblack added a comment. Use section headers instead of font weights REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=82010&id=82012 BRANCH arcpatch-D28154 REVISION DETAIL https://phabricator.kd

D28154: Add users KCM

cblack updated this revision to Diff 82010. cblack added a comment. Improved dirty state handling REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=82008&id=82010 BRANCH arcpatch-D28154 REVISION DETAIL https://phabricator.kde.org/D28154

D28154: Add users KCM

cblack updated this revision to Diff 82008. cblack added a comment. Address the page oddities REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=82006&id=82008 BRANCH arcpatch-D28154 REVISION DETAIL https://phabricator.kde.org/D28154 AFFE

D28154: Add users KCM

cblack updated this revision to Diff 82006. cblack added a comment. Take care of that feedback REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=80942&id=82006 BRANCH arcpatch-D28154 REVISION DETAIL https://phabricator.kde.org/D28154 AFF

D28888: Fix navigation regressions

This revision was automatically updated to reflect the committed changes. Closed by commit R1014:f98e5d33f46b: Fix navigation regressions (authored by cblack). REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2?vs=81713&id=81889 REVISION DETAIL

D29106: Introduce RouterWindow control

This revision was automatically updated to reflect the committed changes. Closed by commit R169:d2060bf4a12a: Introduce RouterWindow control (authored by cblack). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29106?vs=80922&id=81888 REVISION DETAIL https:

D29307: Implement smallFont in Kirigami plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R858:5b8868783c01: Implement smallFont in Kirigami plugin (authored by cblack). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29307?vs=81642&

D29395: Refactor MediaController

cblack added a comment. In D29395#662576 , @ngraham wrote: > Now the inner image has a greater top margin than bottom margin. Also, could the artist and album be allowed to become two-line strings before eliding, maybe? F8282138: Screenshot_2020

D29395: Refactor MediaController

cblack created this revision. cblack added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY MediaController is refactored to: 1. make the code easier to read and therefore more maintainabl

D28888: Fix navigation regressions

cblack updated this revision to Diff 81713. cblack added a comment. Use normal list delegates REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2?vs=81214&id=81713 BRANCH cblack/better-navigation (branched from master) REVISION DETAIL https

D28627: Adaptive panel opacity

cblack added a comment. @davidedmundson can you take another look at the general direction of the code here? I'd like to know your thoughts on the direction this code is using before I start spending time sanding off the rough parts REPOSITORY R119 Plasma Desktop REVISION DETAIL https:/

D29307: Implement smallFont in Kirigami plugin

cblack added a comment. In D29307#660851 , @filipf wrote: > How does this relate to D14562 1. This would have been a companion patch to it if the author didn't abandon it 2. But they did, so th

D29301: [applets/mediacontroller] Elide text

This revision was automatically updated to reflect the committed changes. Closed by commit R120:0dcc58a10628: [applets/mediacontroller] Elide text (authored by cblack). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29301?vs=81598&id=81661 REVISION D

D29307: Implement smallFont in Kirigami plugin

cblack updated this revision to Diff 81642. cblack added a comment. Add explanatory comment REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29307?vs=81609&id=81642 BRANCH cblack/smallfont (branched from master) REVISION DETAIL

D29307: Implement smallFont in Kirigami plugin

cblack created this revision. cblack added a reviewer: Kirigami. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. TEST PLAN F8273961: image.png F8273893: font.qml

D29294: Add support for layers to PagePoolAction.

cblack added inline comments. INLINE COMMENTS > tst_layers.qml:19-25 > +function initTestCase() { > +mainWindow.show() > +} > + > +function cleanupTestCase() { > +mainWindow.close() > +} You want to use `when: windowShown` > tst_layers.qml:27 > + > +function

D29304: Introduce Theme::smallFont

This revision was automatically updated to reflect the committed changes. Closed by commit R169:9368dcc28f66: Introduce Theme::smallFont (authored by cblack). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29304?vs=81603&id=81604 REVISION DETAIL https://ph

D29304: Introduce Theme::smallFont

cblack updated this revision to Diff 81603. cblack added a comment. Drop Rust-ism REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29304?vs=81601&id=81603 BRANCH cblack/smallFont (branched from master) REVISION DETAIL https://phabricator.kde.org/D29304

D29304: Introduce Theme::smallFont

cblack created this revision. cblack added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY Like defaultFont, but smaller. TEST PLAN F8273893: font.qml

D29301: [applets/mediacontroller] Elide text

cblack updated this revision to Diff 81598. cblack retitled this revision from "[applets/mediacontroller] Drop maximum height on songTitle" to "[applets/mediacontroller] Elide text". cblack edited the test plan for this revision. cblack added a comment. Elide text REPOSITORY R120 Plasma Wor

D29301: [applets/mediacontroller] Drop maximum height on songTitle

cblack created this revision. cblack added reviewers: VDG, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. TEST PLAN Before: F8273701: image.png After: F8273704: image.png

D29074: Make BasicListItem more useful by giving it a subtitle property

cblack added inline comments. INLINE COMMENTS > BasicListItem.qml:31 > + * Optional; if not defined, the list item will only have a main label > + * @since 2.12 > + */ @since 5.70 @since org.kde.kirigami 2.12 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.or

D29288: Improve PageRouter API

cblack created this revision. cblack added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. cblack updated this revision to Diff 81555. cblack added a comment. cblack requested review of this revision. Add missing EOF linebreak REVISION SUMMARY

D29290: IGNORE THIS - TESTING A PHAB THING

cblack added a comment. submit the revision as a draft (`arc diff --draft`) so you don't cause useless emails next time REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D29290 To: davidedmundson, qi437103 Cc: cblack, plasma-devel, Orage, LeGast0

D29279: Don't play volume feedback if max volume is reached

cblack added a comment. In D29279#659922 , @nicolasfella wrote: > To be clear: the 95%->100% transition still emits a sound, but 100%->100% does not any more Yes, that's what I rely on to know that I'm at maximum volume-when the volume

D29279: Don't play volume feedback if max volume is reached

cblack added a comment. Not sure how I feel about this change. I often rely on auditory feedback rather than visual feedback to confirm that I'm at maximum volume. REPOSITORY R115 Plasma Audio Volume Applet BRANCH vol REVISION DETAIL https://phabricator.kde.org/D29279 To: nicolasfell

D29156: [kcms/fonts] When adjusting all fonts, keep Small font size smaller

cblack accepted this revision as: cblack. cblack added a comment. +1 from a design standpoint here. REPOSITORY R119 Plasma Desktop BRANCH make-small-font-smaller-when-changing-all-font-sizes (branched from master) REVISION DETAIL https://phabricator.kde.org/D29156 To: ngraham, #plasma

D29262: Less segfaulty PageRouterAttached

This revision was automatically updated to reflect the committed changes. Closed by commit R169:e0107f5854dc: Less segfaulty PageRouterAttached (authored by cblack). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29262?vs=81466&id=81468 REVISION DETAIL htt

  1   2   3   4   5   6   7   >