More Love for Aether

2019-04-12 Thread Boudhayan Gupta
Hi all, I've been using Aether Dark (https://store.kde.org/p/1245521/) pretty much exclusively on all my computers for over half a year now. I think it's beautiful (I prefer dark themes and IMO this is currently far better than the default Plasma Dark theme). I haven't _really_ noticed anything b

Re: CI system maintainability

2019-03-28 Thread Boudhayan Gupta
Hi, On Thu, 28 Mar 2019 at 15:21, Kevin Ottens wrote: > Hello, > > On Thursday, 28 March 2019 14:33:59 CET laurent Montel wrote: > > I am against to force mandatory review, as it will create a lot of lose > of > > time, > > As I said, unpopular. > I don't get why mandatory code reviews are so u

D1976: Image of the Day wallpaper plugin

2017-08-17 Thread Boudhayan Gupta
bgupta abandoned this revision. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D1976 To: bgupta, #plasma, sebas Cc: broulik, garg, sebas, graesslin, davidedmundson, plasma-devel, #plasma, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol,

[Differential] [Commented On] D3476: Support screenshot current screen and fullscreen on KWin/Wayland

2016-11-24 Thread bgupta (Boudhayan Gupta)
bgupta added a comment. Good point. This is going to need more insidious changes in Spectacle. Alright, ship this for now. REPOSITORY rSPECTACLE Spectacle BRANCH kwin-screenshot-screen REVISION DETAIL https://phabricator.kde.org/D3476 EMAIL PREFERENCES https://phabricator.kde.org/s

[Differential] [Commented On] D3475: Add interactive position selection to screenshot screen under cursor

2016-11-24 Thread bgupta (Boudhayan Gupta)
bgupta added a comment. Yeah, I was planning on each plugin returning a list of supported grab modes and ancillary features (on click, timeouts, etc), and modifying the UI based on that information. Ship this for now. I'll work on this when I'm done with college (end of December this ye

[Differential] [Accepted] D3475: Add interactive position selection to screenshot screen under cursor

2016-11-24 Thread bgupta (Boudhayan Gupta)
bgupta accepted this revision. bgupta added a comment. This revision is now accepted and ready to land. Hmm, so "On Click" mode is always selected. REPOSITORY rKWIN KWin BRANCH screenshot-screen-fullscreen REVISION DETAIL https://phabricator.kde.org/D3475 EMAIL PREFERENCES https://p

[Differential] [Accepted] D3476: Support screenshot current screen and fullscreen on KWin/Wayland

2016-11-23 Thread bgupta (Boudhayan Gupta)
bgupta accepted this revision. bgupta added a comment. This revision is now accepted and ready to land. Looks lovely. I just have one nitpick, which is in an inline comment below. INLINE COMMENTS > KWinWaylandImageGrabber.h:48 > +void startReadImage(int readPipe); > +enum class Mode {

[Differential] [Updated] D3475: Add interactive position selection to screenshot screen under cursor

2016-11-23 Thread bgupta (Boudhayan Gupta)
bgupta added a comment. Does this mean taking a full screen screenshot also requires a click anywhere on the screen from the user? Or is the click optional? REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3475 EMAIL PREFERENCES https://phabricator.kde.org/settings/p

[Differential] [Accepted] D3413: Introduce a KWin/Wayland image grabber

2016-11-18 Thread bgupta (Boudhayan Gupta)
bgupta accepted this revision. bgupta added a comment. This is lovely. Thanks for doing this. REPOSITORY rSPECTACLE Spectacle BRANCH kwin-wayland REVISION DETAIL https://phabricator.kde.org/D3413 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To

[Differential] [Updated] D2983: Support solid colour and image backgrounds with a configurable background colour in the SDDM theme

2016-10-11 Thread bgupta (Boudhayan Gupta)
bgupta removed a commit: rPLASMAWORKSPACEaafa20f19c87: sddm-theme: support configurable solid colour and image backgrounds. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2983 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpref

[Differential] [Closed] D2983: Support solid colour and image backgrounds with a configurable background colour in the SDDM theme

2016-10-11 Thread bgupta (Boudhayan Gupta)
bgupta closed this revision. bgupta added a comment. Committed in https://phabricator.kde.org/rPLASMAWORKSPACEaafa20f19c87898a1ff06996ba0fffebdc236ba5: sddm-theme: support configurable solid colour and image backgrounds. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https

[Differential] [Updated] D2983: Support solid colour and image backgrounds with a configurable background colour in the SDDM theme

2016-10-11 Thread bgupta (Boudhayan Gupta)
bgupta added a commit: rPLASMAWORKSPACEaafa20f19c87: sddm-theme: support configurable solid colour and image backgrounds. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2983 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefer

[Differential] [Commented On] D2983: Support solid colour and image backgrounds with a configurable background colour in the SDDM theme

2016-10-09 Thread bgupta (Boudhayan Gupta)
bgupta added a comment. In https://phabricator.kde.org/D2983#55400, @markuss wrote: > This patch modifies an existing file. Removing the original copyright is illegal! If you want your new code to be under a different license (which is fine), you need to rework the header to state: "Orig

[Differential] [Request, 97 lines] D2983: Support solid colour and image backgrounds with a configurable background colour in the SDDM theme

2016-10-07 Thread bgupta (Boudhayan Gupta)
bgupta created this revision. bgupta added a reviewer: davidedmundson. bgupta set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This patch reworks t

Re: Review Request 128892: Open baloo lmdb database read-only beside in baloo_file/baloo_file_extractor + balooctl (for some commands) + unit tests

2016-09-11 Thread Boudhayan Gupta
like a gigantic patch and I'm not sure I understand all of it right now. - Boudhayan Gupta On Sept. 12, 2016, 12:42 a.m., Christoph Cullmann wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 128890: Make e.g. Baloo::Query thread safe.

2016-09-11 Thread Boudhayan Gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128890/#review99101 --- Ship it! Ship It! - Boudhayan Gupta On Sept. 11, 2016

[Differential] [Commented On] D1976: Image of the Day wallpaper plugin

2016-07-13 Thread bgupta (Boudhayan Gupta)
bgupta added a comment. I'll re-work a bunch of stuff, including image caching, and placement of credit text/logo based on where the panel is. Then I'll file a new revision. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D1976 EMAIL PREFERENCES h

[Differential] [Updated, 772 lines] D1976: Image of the Day wallpaper plugin

2016-06-23 Thread bgupta (Boudhayan Gupta)
bgupta changed the visibility from "All Users" to "Public (No Login Required)". bgupta updated this revision to Diff 4689. bgupta added a comment. I've addressed all of the issues except for layout and alignment in the configuration dialog. I'm soliciting feedback for all the outstanding

[Differential] [Updated] D1976: Image of the Day wallpaper plugin

2016-06-23 Thread bgupta (Boudhayan Gupta)
bgupta marked 13 inline comments as done. bgupta added inline comments. INLINE COMMENTS > bgupta wrote in main.qml:111 > It's true that there's no regular scaling involved. I clearly misunderstood > the point of mipmap scaling over regular smoothing. I'll swap this in favour > of smoothing. >F

[Differential] [Updated] D1976: Image of the Day wallpaper plugin

2016-06-23 Thread bgupta (Boudhayan Gupta)
bgupta marked 2 inline comments as done. bgupta added a subscriber: garg. bgupta added inline comments. INLINE COMMENTS > sebas wrote in config.qml:178 > So it will at most switch every 15 minutes? Seems a bit long as minimal value > to me... Note that we're hitting APIs, some of which have lim

[Differential] [Updated] D1976: Image of the Day wallpaper plugin

2016-06-23 Thread bgupta (Boudhayan Gupta)
bgupta marked 2 inline comments as done. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D1976 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bgupta, #plasma, sebas Cc: garg, sebas, graesslin, davidedmundson, plasma

[Differential] [Commented On] D1976: Image of the Day wallpaper plugin

2016-06-23 Thread bgupta (Boudhayan Gupta)
bgupta added a comment. In https://phabricator.kde.org/D1976#36389, @graesslin wrote: > You might have seen that I have an open differential request to integrate Plasma Wallpapaer into kscreenlocker. > > This makes me ask the question: how will this wallpaper plugin look like if you

[Differential] [Commented On] D1976: Image of the Day wallpaper plugin

2016-06-22 Thread bgupta (Boudhayan Gupta)
bgupta added inline comments. INLINE COMMENTS > davidedmundson wrote in config.qml:27 > If you switch these to ColumnLayout / RowLayout (from QtQuick.Layouts, which > you're currently not using) you can get rid of a lot of the anchors and > widths in this code. I was initially using ColumnLayo

[Differential] [Updated] D1976: Image of the Day wallpaper plugin

2016-06-22 Thread bgupta (Boudhayan Gupta)
bgupta added a reviewer: Plasma. REPOSITORY rKDEPLASMAADDONS Plasma Addons REVISION DETAIL https://phabricator.kde.org/D1976 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bgupta, #plasma Cc: plasma-devel, #plasma, jensreuterberg, sebas

[Differential] [Request, 788 lines] D1976: Image of the Day wallpaper plugin

2016-06-22 Thread bgupta (Boudhayan Gupta)
bgupta created this revision. bgupta added a subscriber: Plasma. bgupta set the repository for this revision to rKDEPLASMAADDONS Plasma Addons. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This patch adds a wallpaper pl

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2016-05-19 Thread Boudhayan Gupta
> On May 17, 2016, 8:07 p.m., Martin Gräßlin wrote: > > given that Plasma integration got removed I suggest to create a dedicated > > osx-integration repository for it as well. > > René J.V. Bertin wrote: > I quite like the way things are, but yes, I've played with that idea. > >

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-02 Thread Boudhayan Gupta
> On Feb. 2, 2016, 1:42 a.m., andreas kainz wrote: > > Hi, I know I say I will keep oxygen-icons5 up to date, and I hope I get the > > time I need the plasma oxygen theme too to give the user the one single > > click feature (look & feel package). Is there an space where you can move > > "unma

Re: Review Request 126949: Remove Air and Oxygen themes

2016-02-01 Thread Boudhayan Gupta
only two themes - the default one and a high-contrast counterpart. In fact all other themes should reside elsewhere. If we still want to "officially" provide Air and Oxygen, maybe we should move them to an extra-themes package instead instead of kde-look? - Boudhayan Gupta On Feb.

Re: Review Request 126319: Plasma 5.6 "Graphite" Wallpaper

2015-12-27 Thread Boudhayan Gupta
using it as my wallpaper and it looks very in-place. - Boudhayan Gupta On Dec. 27, 2015, 5:52 a.m., Ken Vermette wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 126319: Plasma 5.6 "Graphite" Wallpaper

2015-12-26 Thread Boudhayan Gupta
> On Dec. 22, 2015, 6:43 p.m., Marco Martin wrote: > > +1 from me too > > I quite like it. perhaps i'm not too sold as well on that little line that > > has very tiny itams (a bit too much Intel sticker?) but overall is very > > pretty. I was going to say the exact same thing. +1 on the overal

Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package

2015-11-24 Thread Boudhayan Gupta
it: https://git.reviewboard.kde.org/r/126091/#review88757 --- On Nov. 24, 2015, 5:23 p.m., Boudhayan Gupta wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package

2015-11-24 Thread Boudhayan Gupta
marked as submitted. Review request for KDE Frameworks, Plasma and David Edmundson. Changes --- Submitted with commit a8c177911dea1e099bfb499f199ee7039c756cde by Boudhayan Gupta to branch master. Repository: khotkeys Description --- After moving KSnapshot to Extragear I&#x

Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package

2015-11-24 Thread Boudhayan Gupta
-packagers mailing list posting (in fact, no comments at all), I'm committing this to Plasma/5.5 and merging to master. Reference to posting: https://mail.kde.org/pipermail/kde-distro-packagers/2015-November/000107.html - Boudhayan Gupta On Nov. 16, 2015, 10:36 p.m., Boudhayan Gupta

Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package

2015-11-22 Thread Boudhayan Gupta
> On Nov. 16, 2015, 10:46 p.m., Hrvoje Senjan wrote: > > >assuming, that is, distros push out the updates together > > > > don't assume this ;-) at least send a mail to kde-distro-packagers about > > the sideeffects if those 3 are pushed asynchronously >

Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package

2015-11-17 Thread Boudhayan Gupta
Boudhayan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126091/#review88456 --- On Nov. 16, 2015, 10:36 p.m., Boudhayan Gu

Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package

2015-11-16 Thread Boudhayan Gupta
sit: https://git.reviewboard.kde.org/r/126091/#review88438 ------- On Nov. 16, 2015, 10:36 p.m., Boudhayan Gupta wrote: > > --- > This is an automatically generated e-mail. To re

Review Request 126091: Remove printscreen.khotkeys from KHotkeys package

2015-11-16 Thread Boudhayan Gupta
.txt f3bcb57 data/printscreen.khotkeys e583311 Diff: https://git.reviewboard.kde.org/r/126091/diff/ Testing --- Doesn't install the printscreen.khotkeys file anymore Thanks, Boudhayan Gupta ___ Plasma-devel mailing list Plasma-devel@kde.org htt

Re: Review Request 125666: Add Spectacle to KHotkeys, disable the existing printscreen.khotkeys file

2015-10-17 Thread Boudhayan Gupta
> On Oct. 17, 2015, 1:39 p.m., David Edmundson wrote: > > apps and plasma don't release at the same time, which means there's going > > to be a point in time where this is broken? > > Boudhayan Gupta wrote: > Exactly why I posted an RR instead of directl

Re: Review Request 125666: Add Spectacle to KHotkeys, disable the existing printscreen.khotkeys file

2015-10-17 Thread Boudhayan Gupta
/printscreen.khotkeys bffe62e data/spectacle.khotkeys PRE-CREATION Diff: https://git.reviewboard.kde.org/r/125666/diff/ Testing --- The correct actions are triggered when the keys are pressed. Thanks, Boudhayan Gupta ___ Plasma-devel mailing list Plasma

Re: Review Request 125666: Add Spectacle to KHotkeys, disable the existing printscreen.khotkeys file

2015-10-17 Thread Boudhayan Gupta
the patch. - Boudhayan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125666/#review86940 --- On Oct. 17, 2015, 12:09 p.

Review Request 125666: Add Spectacle to KHotkeys, disable the existing printscreen.khotkeys file

2015-10-16 Thread Boudhayan Gupta
://git.reviewboard.kde.org/r/125666/diff/ Testing --- The correct actions are triggered when the keys are pressed. Thanks, Boudhayan Gupta ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel