bgupta accepted this revision.
bgupta added a comment.
This revision is now accepted and ready to land.
Looks lovely. I just have one nitpick, which is in an inline comment below.
INLINE COMMENTS
> KWinWaylandImageGrabber.h:48
> + void startReadImage(int readPipe);
> + enum class Mode {
> + Window,
Can we re-use the ImageGrabber::CaptureMode enum here?
REPOSITORY
rSPECTACLE Spectacle
BRANCH
kwin-screenshot-screen
REVISION DETAIL
https://phabricator.kde.org/D3476
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, #plasma_on_wayland, bgupta
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
