Re: KEmoticons, emoticons kcm

On 5/22/20 6:49 PM, Aleix Pol wrote: Hi, I was looking through some Plasma code and I saw that we have some fairly old emoticons KCM using KF5Emoticons. Now while I know why this exists, it feels like it's more of a thing of the past from when people wrote :) instead of 🙂. While keeping it aroun

D29827: Give users the ability to disable the microphone indicator

ngraham added a comment. The name needs to be your full name ("Firstname Lastname"). This was a pre-existing requirement, it's just not enforced before patch submission, rather than afterwards. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D29827

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.14 - Build # 104 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.14/104/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 23 May 2020 01:09:41 + Build duration: 3 min 44 sec and counting CONSOLE OUTPUT [...tr

D28539: [Emoji panel] search when the user begins typing

ngraham closed this revision. ngraham added a comment. This landed. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28539 To: ngraham, apol, #plasma, #vdg Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, Z

KEmoticons, emoticons kcm

Hi, I was looking through some Plasma code and I saw that we have some fairly old emoticons KCM using KF5Emoticons. Now while I know why this exists, it feels like it's more of a thing of the past from when people wrote :) instead of 🙂. While keeping it around for the few apps that might still use

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.14 - Build # 103 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.14/103/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 23 May 2020 00:27:19 + Build duration: 12 min and counting CONSOLE OUTPUT [...truncate

D29827: Give users the ability to disable the microphone indicator

kurmikon added a comment. In D29827#673541 , @bcooksley wrote: > You are being rejected because those commits were made using a name that appears to just be a first name - you will need to amend your user.name in your Git configuration and amen

D29827: Give users the ability to disable the microphone indicator

bcooksley added a comment. You are being rejected because those commits were made using a name that appears to just be a first name - you will need to amend your user.name in your Git configuration and amend the commits accordingly REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAI

D29827: Give users the ability to disable the microphone indicator

kurmikon added a comment. In D29827#673539 , @ngraham wrote: > You need to push to your fork of the `plasma-pa` repo, not the main location. `git push fork` should do it if you've set up your fork with the name `fork` as described in https://co

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.14 - Build # 102 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.14/102/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 22 May 2020 22:36:29 + Build duration: 5 min 4 sec and counting CONSOLE OUTPUT [...tru

D29827: Give users the ability to disable the microphone indicator

ngraham added a comment. You need to push to your fork of the `plasma-pa` repo, not the main location. `git push fork` should do it if you've set up your fork with the name `fork` as described in https://community.kde.org/Infrastructure/GitLab#Add_the_fork_to_your_source_checkout REPOSITORY

D29827: Give users the ability to disable the microphone indicator

kurmikon added a comment. @ngraham I'm following instructions, but push is rejected: remote: Push declined - commits failed audit REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D29827 To: kurmikon, ngraham, #vdg, #plasma Cc: ngraham, plasma-

D29827: Give users the ability to disable the microphone indicator

ngraham added a comment. In D29827#673535 , @kurmikon wrote: > In D29827#673534 , @ngraham wrote: > > > What email? Huh? > > > The page you linked say I have to send an email. > > Anyway, I

D29827: Give users the ability to disable the microphone indicator

kurmikon added a comment. In D29827#673534 , @ngraham wrote: > What email? Huh? The page you linked say I have to send an email. Anyway, I'm able to use git, but I don't get how to push my modification in my branch on my personal rep

D29827: Give users the ability to disable the microphone indicator

ngraham added a comment. What email? Huh? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D29827 To: kurmikon, ngraham, #vdg, #plasma Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, Zr

D29827: Give users the ability to disable the microphone indicator

kurmikon added a comment. @ngraham I'm sending the email, but the system reject the request. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D29827 To: kurmikon, ngraham, #vdg, #plasma Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, c

D29827: Give users the ability to disable the microphone indicator

ngraham added a comment. Thanks for the patch! KDE has since moved to GitLab at invent.kde.org/ and we would prefer not to use Phabricator for new patches. Could you re-submit this as a merge request at https://invent.kde.org/plasma/plasma-pa/-/merge_requests, and then Abandon this? Tha

D28154: Add users KCM

filipf added a comment. In D28154#672453 , @ngraham wrote: > Now that D29394 has landed, you can add those images here! . REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.or

D29827: Give users the ability to disable the microphone indicator

kurmikon created this revision. kurmikon added reviewers: ngraham, VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kurmikon requested review of this revision. REVISION SUMMARY Plasma is an high customizable desktop environment. When it comes to system tray,

D26777: [App Style KCM] Port away from QDBusInterface

gikari abandoned this revision. gikari added a comment. I have a better idea of how to get rid of the dbus calls entirely in the future. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26777 To: gikari, #plasma Cc: apol, plasma-devel, Orage, LeGast00n, The-Fe

D29807: Change Chrome API design

alex updated this revision to Diff 83118. alex added a comment. Formatting, remove debug statement REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29807?vs=83116&id=83118 BRANCH api_inconsistencies (branched from master) REVISION DETAIL https:

D29807: Change Chrome API design

meven added a comment. Seems good, two small clean ups INLINE COMMENTS > chromeprofile.cpp:8 > +ProfileBookmarks::ProfileBookmarks(const QString &path, const QString &name) > +: m_path(path), m_name(name), m_favicon(nullptr) { > +// Remove "Bookmarks" from end of path `{` on new line

Re: Plasma Firewall

Hi Kai, This is something that Plasma has been missing for a long time. Thanks to everyone involved! A few comments from a quick run-through over kcm/core: # Style issues - Some enums use MACRO_STYLE, some NormalStyle - Some one-line if bodies in the same file have {}, some do not - Double

D29384: KCM Runners: Use setAppendServiceFile method for plugin selector

alex abandoned this revision. alex added a comment. Task will proceed on GitLab. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29384 To: alex, #plasma, ngraham, meven Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampalouk

D29807: Change Chrome API design

alex updated this revision to Diff 83116. alex retitled this revision from "WIP: Change Chrome API design" to "Change Chrome API design". alex edited the summary of this revision. alex added reviewers: ngraham, meven. alex added a comment. Change import, formatting REPOSITORY R120 Plasma Wo

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.14 - Build # 101 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.14/101/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 22 May 2020 14:56:21 + Build duration: 29 min and counting CONSOLE OUTPUT [...truncate

D27555: Add a category for kde-only and gnome-only apps

apol abandoned this revision. apol added a comment. I don't feel like the world needs this. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D27555 To: apol, #plasma, #vdg, ngraham Cc: ngraham, pino, nicolasfella, plasma-devel, Orage, LeGast00n, The-Fe

Plasma Firewall

Hi all, Tomaz, Lucas, and me have been working on a simple Firewall KCM for Plasma based on nx-firewall. It supports both ufw and firewalld. I'd like to eventually include that in Plasma 5.20 so please give it some code review and testing so we can iron out any issues for that, especially wit

[ksysguard] [Bug 421902] Package ksysguard5 cannot be installed on the current openSUSE Leap

https://bugs.kde.org/show_bug.cgi?id=421902 Antonio Rojas changed: What|Removed |Added Status|REPORTED|RESOLVED CC|

[ksysguard] [Bug 421902] New: Package ksysguard5 cannot be installed on the current openSUSE Leap

https://bugs.kde.org/show_bug.cgi?id=421902 Bug ID: 421902 Summary: Package ksysguard5 cannot be installed on the current openSUSE Leap Product: ksysguard Version: 5.18.90 Platform: openSUSE RPMs OS: Linux

D28904: Cleanup dependencies

broulik added inline comments. INLINE COMMENTS > anthonyfieroni wrote in CMakeLists.txt:20 > That's not right at least. It should be optional when KF5NetworkManagerQt is > found. It looks weird to present at all. Yes, this looks wrong but I don't understand why I even have to add this manually