broulik added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in CMakeLists.txt:20
> That's not right at least. It should be optional when KF5NetworkManagerQt is 
> found. It looks weird to present at all.

Yes, this looks wrong but I don't understand why I even have to add this 
manually... NetworkManager-Qt CMake looks for Qt5 Network and it also has it in 
its PUBLIC link interface.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D28904

To: broulik, #plasma
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to