D29394: Add photographic user avatars

ngraham added a comment. @jriddell, does this licensing situation look sane? REPOSITORY R128 User Manager BRANCH add-photo-avatars (branched from master) REVISION DETAIL https://phabricator.kde.org/D29394 To: filipf, #vdg, ngraham Cc: jriddell, cblack, ognarb, plasma-devel, Orage, LeG

D29024: feat(wayland): support multiple protocol extensions through plugin system

romangg added a comment. Oh I nearly forgot: great work that you ignore everything else I wrote and only reply to the most unimportant statement in all of that. That's a great rhetorical trick. Every good politician must know about this one for distraction. REPOSITORY R110 KScreen Library

D29024: feat(wayland): support multiple protocol extensions through plugin system

romangg added a comment. In D29024#669718 , @davidedmundson wrote: > > Show me where the documentation for this QtWaylandClientExtension is and where you documented that we "agreed" on using that in Plasma exclusively and we can talk about libk

D29157: force systemsettings for kcms

davidedmundson added a comment. We need a fix for https://bugs.kde.org/show_bug.cgi?id=421431 Which could just be me removing making it hidden. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29157 To: mart, #plasma, ngraham Cc: davidedmundson, broulik,

D29024: feat(wayland): support multiple protocol extensions through plugin system

davidedmundson added a comment. > Show me where the documentation for this QtWaylandClientExtension is and where you documented that we "agreed" on using that in Plasma exclusively and we can talk about libkscreen using it in 5.20 It was documented here https://phabricator.kde.org/T11903

D29394: Add photographic user avatars

filipf updated this revision to Diff 82697. filipf added a comment. Use this format https://reuse.software/tutorial/ making a LICENCE/ directory with the licence text in it and cat.jpg.license with the SPDX header REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator

D29603: Adds custom spacing between task manager icons

martellini added a comment. In D29603#669457 , @ngraham wrote: > In D29603#669015 , @martellini wrote: > > > Sounds cool. I'll be working on it. > > I must that the iconSize setting is only visibi

D29394: Add photographic user avatars

ngraham accepted this revision. ngraham added a comment. Perfecto. REPOSITORY R128 User Manager BRANCH add-photo-avatars (branched from master) REVISION DETAIL https://phabricator.kde.org/D29394 To: filipf, #vdg, ngraham Cc: jriddell, cblack, ognarb, plasma-devel, Orage, LeGast00n, Th

D29394: Add photographic user avatars

filipf updated this revision to Diff 82694. filipf added a comment. actually remove Chip and Gecko(due to rename) REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29394?vs=82693&id=82694 BRANCH add-photo-avatars (branched from master) REVISION DETAIL

D29394: Add photographic user avatars

filipf updated this revision to Diff 82693. filipf added a comment. - rename Gecko to Chameleon because that wasn't a gecko - remove Chip - add Air Balloon, Dog, Fish, Owl, Pencils, Sushi - WIP: licence files REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator

D29692: Recommend better width calculation for PlaceholderMessage

This revision was automatically updated to reflect the committed changes. Closed by commit R169:f1a2c678f9bd: Recommend better width calculation for PlaceholderMessage (authored by ngraham). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29692?vs=82689&id=826

D29692: Recommend better width calculation for PlaceholderMessage

ngraham created this revision. ngraham added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Left and right anchors + margins + vertical centering don't work well work together, and th

D29689: Port "sorry, nothing found" message to Kirigami.PlaceholderMessage

This revision was automatically updated to reflect the committed changes. Closed by commit R134:eb5ccec97a12: Port "sorry, nothing found" message to Kirigami.PlaceholderMessage (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.or

D29689: Port "sorry, nothing found" message to Kirigami.PlaceholderMessage

filipf accepted this revision. filipf added a comment. Works well and looks good. REPOSITORY R134 Discover Software Store BRANCH port-to-placeholdermessage (branched from master) REVISION DETAIL https://phabricator.kde.org/D29689 To: ngraham, apol, #discover_software_store, #vdg, fili

D29689: Port "sorry, nothing found" message to Kirigami.PlaceholderMessage

ngraham updated this revision to Diff 82687. ngraham marked 2 inline comments as done. ngraham added a comment. Address review comments REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29689?vs=82683&id=82687 BRANCH port-to-placeholdermessa

D29689: Port "sorry, nothing found" message to Kirigami.PlaceholderMessage

filipf accepted this revision. filipf added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ApplicationsListPage.qml:152 > + > +visible: opacity != 0 > +opacity: apps.count == 0 && !appsModel.isBusy ? 1 : 0 Should work without this, no?

D29691: Restore ability to send tel: URLs to the phone

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY They're not `http` or `https` URLs. Add a dedicated handler with appropriate "Call on devic

D29689: Port "sorry, nothing found" message to Kirigami.PlaceholderMessage

ngraham created this revision. ngraham added reviewers: apol, Discover Software Store, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. TEST PLAN F8313851: Screenshot_20200512_121457.png

D29679: Dedicated drop areas for assigning tasks to activities

ivan closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29679 To: ivan, #plasma, ngraham, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mo

D29679: Dedicated drop areas for assigning tasks to activities

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM! Very nice work. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D29679 To: ivan, #plasma, ngraham, mart Cc: plasma-devel, Orage, LeG

D29394: Add photographic user avatars

ngraham accepted this revision. ngraham added a comment. Awesome. Love the pancakes, the gecko, and the new gaming controller. Much nicer. I really like Doggo, AirBalloon, Pencils, and Sushi, and think those might be worth including as well. I also kind of like Fish too! Chip seems

D29688: Ignore mount paths that start with '/snap/'

ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY Apparently, each snap is mounted as a squashfs file. This causes a lot of sensors to appea

D29687: [IconApplet] Port KRun to ApplicationLauncherJob

ngraham added a comment. (JFYI I just noticed that kde-cli-tools is broken and needs porting too) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29687 To: ahmadsamir, #plasma, broulik Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, j

D29687: [IconApplet] Port KRun to ApplicationLauncherJob

ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, broulik. Herald added a project: Plasma. ahmadsamir requested review of this revision. TEST PLAN Open the Application Launcher, right click any app -> Add to Panel (Widget), then click the icon on the panel, it should launch

D28154: Add users KCM

ngraham added a comment. In D28154#668362 , @ltoscano wrote: > Technically kcm should be called kcm_. So far the Plasma_version part has been ignored, but at least kcm_ should be there. > > I'm not sure about the lack of the button. I

D29431: Remove stepsize 24 from DPI spinbox inside kcm fontconfig

This revision was automatically updated to reflect the committed changes. Closed by commit R119:854a62e57772: Remove stepsize 24 from DPI spinbox inside kcm fontconfig (authored by kurmikon, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.k

D29431: Remove stepsize 24 from DPI spinbox inside kcm fontconfig

ngraham added a comment. Thanks! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29431 To: kurmikon, #plasma, #vdg, ngraham Cc: davidedmundson, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot

D29595: Add gocryptfs support

ivan added a comment. Done. Thanks again for the patch! REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D29595 To: mpilia, ivan, #plasma Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himc

D29595: Add gocryptfs support

ivan closed this revision. REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D29595 To: mpilia, ivan, #plasma Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, j

D29431: Remove stepsize 24 from DPI spinbox inside kcm fontconfig

kurmikon added a comment. In D29431#669402 , @ngraham wrote: > Got confirmation from @davidedmundson that this is okay. Can you provide an email address so I can land your patch with correct git authorship information? kurmi...@libero.it

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

ndavis added a comment. That's a good point. Is there a way to choose a different default layout based on info about the user's setup? I think choosing layouts based on the user's hardware may be necessary to get defaults that please most people while still being touch friendly in contexts w

D29603: Adds custom spacing between task manager icons

ngraham added a comment. In D29603#669015 , @martellini wrote: > Sounds cool. I'll be working on it. > I must that the iconSize setting is only visibile if the panel is vertical, why do you think it is so? Not sure I fully understahd,

D29595: Add gocryptfs support

ngraham added a comment. @ivan are you gonna land this, or should I? REPOSITORY R845 Plasma Vault BRANCH add-gocryptfs-support (branched from master) REVISION DETAIL https://phabricator.kde.org/D29595 To: mpilia, ivan, #plasma Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-

D29264: New tabs for Breeze

niccolove added a comment. +1 for the direction! REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D29264 To: abstractdevelop, #vdg, #breeze Cc: niccolove, manueljlin, filipf, ngraham, cblack, plasma-devel, dmenig, Orage, LeGast00n, The-Feren-OS-Dev, konkinartem, ian, jg

D29682: Elide sensor names in config view

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN Eyes REPOSITORY R111 KSysguard Library BRANCH master REVISION DETAIL https:

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

ngraham added a comment. In D29501#667413 , @ndavis wrote: > I agree with the size chosen if we are doing a vertical panel since that size allows app icons to be 48px and makes the systray more compact by using 2 columns. However, I can't think

D29621: [kstart] Port to ApplicationLauncherJob and CommandLauncherJob

davidedmundson added inline comments. INLINE COMMENTS > kstart.cpp:121 > +} else { > +printf("%d\n", job->pid()); > +} I know it's copied but, there's no need to randomly go to C to use std::cout > kstart.cpp:128 > +if (job->error()) { > +

D27513: Kill Runner: Remove duplicate function calls and refactor

alex updated this revision to Diff 82669. alex added a comment. Formatting REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27513?vs=82666&id=82669 BRANCH arcpatch-D27513_1 REVISION DETAIL https://phabricator.kde.org/D27513 AFFECTED FILES ru

D27513: Kill Runner: Remove duplicate function calls and refactor

alex updated this revision to Diff 82666. alex added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27513?vs=81006&id=82666 BRANCH arcpatch-D27513_1 REVISION DETAIL https://phabricator.kde.org/D27513 AFFECTED FILES runner

D29624: Fix Warning about KF5::KSysGuard target being deprecated

meven abandoned this revision. meven added a comment. Superseeded by D29626 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29624 To: meven, #plasma, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cbla

D29615: Nice all threads of multithreaded programs

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > Still, I think this behavior is actually the only one usable, Indeed. A user shouldn't be expected to know what each thread is doing inside an app, there isn't enough

D29431: Remove stepsize 24 from DPI spinbox inside kcm fontconfig

ngraham added a comment. Got confirmation from @davidedmundson that this is okay. Can you provide an email address so I can land your patch with correct git authorship information? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29431 To: kurmikon, #plasma, #

D29394: Add photographic user avatars

filipf added a comment. Some pictures I didn't include in case people like them: F8313250: image.png F8313256: image.png (yes the Leopard is nice but the circular cropping eats too much into it) With the

D29394: Add photographic user avatars

filipf updated this revision to Diff 82662. filipf added a comment. - Remove all Unsplash and Pexels licensed photos to avoid complications. - Use CC0 pictures from Pexels instead - Licence files to be added REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kd

D29679: Dedicated drop areas for assigning tasks to activities

ivan created this revision. ivan added reviewers: Plasma, ngraham, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ivan requested review of this revision. REVISION SUMMARY Instead of using a difficult to discover 'move to activity by default, copy to activity whe

D29633: [Battery Monitor] Fix toolTipMainText when plugged in

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ddefcfb7c901: [Battery Monitor] Fix toolTipMainText when plugged in (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29633?vs=82530&id

D29431: Remove stepsize 24 from DPI spinbox inside kcm fontconfig

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. That's not how it works. Patches need to be properly reviewed. I can do so on behalf of VDG, bud I'd like @davidedmundson's sign-off too, because IIRC he was the one who proposed or imple

D28321: [applets/devicenotifier] Port to ExpandableListItem

ngraham updated this revision to Diff 82653. ngraham added a comment. Remove a FIXME (it's already a problem in the existing version so it's not an artifact of this port REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28321?vs=82264&id=82653 BRANC

D29675: initialize bools to false by default

This revision was automatically updated to reflect the committed changes. Closed by commit R871:c517b795936f: initialize bools to false by default (authored by sitter). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29675?vs=82647&id=82651 REVISION DETAIL h

D29476: WIP: Port klipper to use wayland clipboard

davidedmundson updated this revision to Diff 82650. davidedmundson added a comment. shuffle files about REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29476?vs=82106&id=82650 BRANCH davidedmundson/clipboard2 REVISION DETAIL https://phabricato

D29394: Add photographic user avatars

jriddell added a comment. Oh yes I made the rookie error of not reading to the end, Unsplash is not free and we can't use it. REPOSITORY R128 User Manager BRANCH add-photo-avatars (branched from master) REVISION DETAIL https://phabricator.kde.org/D29394 To: filipf, #vdg, ngraham Cc:

D29675: initialize bools to false by default

sitter created this revision. sitter added a reviewer: davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY This should fix random 113 errors (user_not_insider) coming out of the api I can't reall

D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout

filipf added a comment. Is this okay now @mart and okay to land on 5.18? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29351 To: filipf, ngraham, cblack, #plasma, mart Cc: mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, f

D29431: Remove stepsize 24 from DPI spinbox inside kcm fontconfig

kurmikon marked an inline comment as done. kurmikon added a comment. @ngraham No reply after one week. I think this can be merged. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29431 To: kurmikon, #plasma, #vdg Cc: davidedmundson, ngraham, plasma-devel, Orag

D29637: Introduce ImageColors

mart updated this revision to Diff 82645. mart marked 12 inline comments as done. mart added a comment. - adress feedbacks REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29637?vs=82537&id=82645 BRANCH mart/imageColors REVISION DETAIL https://phabrica

D29140: Fix POTD in lock screen (complete)

guoyunhe updated this revision to Diff 82635. guoyunhe added a comment. Fix watcher when file is recreated REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29140?vs=82632&id=82635 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29140 A

D29140: Fix POTD in lock screen (complete)

guoyunhe added a comment. @ngraham the kded module is working now. please have a look! REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D29140 To: guoyunhe, #plasma, ngraham Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh

D29140: Fix POTD in lock screen (partly)

guoyunhe updated this revision to Diff 82632. guoyunhe added a comment. Fix config file path REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29140?vs=82620&id=82632 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29140 AFFECTED FILES

D29570: Fix some alignments

This revision was automatically updated to reflect the committed changes. Closed by commit R120:de52cb8944e8: Fix some alignments (authored by niccolove). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29570?vs=82389&id=82631 REVISION DETAIL https:/

D29632: [kcms/keys] Use better collator settings

This revision was automatically updated to reflect the committed changes. Closed by commit R119:847d9216e0c1: [kcms/keys] Use better collator settings (authored by davidre). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29632?vs=82625&id=82626 REVISIO

D29632: [kcms/keys] Use better collator settings

davidre updated this revision to Diff 82625. davidre added a comment. numeric REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29632?vs=82529&id=82625 BRANCH collator (branched from master) REVISION DETAIL https://phabricator.kde.org/D29632 AFFE

D29140: Fix POTD in lock screen (partly)

guoyunhe added a comment. I created the kded service and it seems running. But it doesn't cache the image as I expected. Don't know how to debug it. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D29140 To: guoyunhe, #plasma, ngraham Cc: davidre, ngraham, plas

D29644: Select application after it is added

This revision was automatically updated to reflect the committed changes. Closed by commit R119:bc5c1d882ed8: Select application after it is added (authored by davidre). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29644?vs=82621&id=82624 REVISION DE

D29579: [kcms/keys] Really ignore unknown action

This revision was automatically updated to reflect the committed changes. Closed by commit R119:12a14a789da4: [kcms/keys] Really ignore unknown action (authored by davidre). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29579?vs=82407&id=82623 REVISIO