D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

ndavis added a comment. In D29365#663395 , @ngraham wrote: > Of course the problem with a spinbox is that by displaying numbers, it demands some kind of legend or label. What does a value of 100 mean? Does a value of 0 make any sense? etc. The v

D29439: [RFC] Adjust color schemes for tools area/Breeze evolution

ndavis updated this revision to Diff 81966. ndavis added a comment. Fix some colors REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29439?vs=81963&id=81966 BRANCH new-colors (branched from master) REVISION DETAIL https://phabricator.kde.org/D29439 AFFEC

D29439: [RFC] Adjust color schemes for tools area/Breeze evolution

ndavis updated this revision to Diff 81963. ndavis added a comment. squash commits REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29439?vs=81962&id=81963 BRANCH new-colors (branched from master) REVISION DETAIL https://phabricator.kde.org/D29439 AFFECT

D29439: [RFC] Adjust color schemes for tools area/Breeze evolution

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY I also renamed Breeze to Breeze Light because it's very awkward to talk about the Breeze project when i

D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout

ngraham added a comment. Wait for @mart, but landing on the stable branch seems safe. No need for a bug report if there isn't already one open. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29351 To: filipf, ngraham, cblack, #plasma, mart Cc: mart, plasma

D29438: Use font: instead of font.pointSize: where possible

ngraham created this revision. ngraham added reviewers: cblack, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Otherwise we're discarding style information possibly set in the user's small font choice

D29437: Use font: instead of font.pointSize: where possible

ngraham created this revision. ngraham added reviewers: cblack, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Otherwise we're discarding style information possibly set in the user's small font choice

D29366: [Wallpaper Configuration] Reword inline message concerning widget locking

This revision was automatically updated to reflect the committed changes. Closed by commit R119:52d3389f7495: [Wallpaper Configuration] Reword inline message concerning widget locking (authored by filipf). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout

filipf added a comment. Should I also land this for 5.18 (do I have to create a bug report first)? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29351 To: filipf, ngraham, cblack, #plasma, mart Cc: mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cb

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon added a comment. In D29365#663597 , @ngraham wrote: > Hmm, 0% as a lower value would imply no movement speed, which is obviously not possible here. As far as I know, libinput manages acceleration rather speed. Let's change the l

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

ngraham added a comment. Hmm, 0% as a lower value would imply no movement speed, which is obviously not possible here. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29365 To: kurmikon, #vdg, #plasma Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-

D29394: Add photographic user avatars

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Everything looks great to me! Now go ask for re-licensing, I suppose. REPOSITORY R128 User Manager BRANCH add-photo-avatars (branched from master) REVISION DETAIL https://phab

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon added a comment. Another solution. Spinbox 0% to 100%. -1 is 0% and 1 is 100%. Libinput default 0 will set 50%. // Acceleration RowLayout { Controls.SpinBox { Kirigami.FormData.label: i18nd("kcm_touchpad", "Pointer speed:") id: accelSpeed

D29394: Add photographic user avatars

filipf updated this revision to Diff 81955. filipf added a comment. Drop: - Air Balloon - Gamepad Add: - Architecture - Food - Chalk Change: - Embiggen the leopard REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29394?vs=8

D29431: Remove stepsize 24 from DPI spinbox inside kcm fontconfig

ngraham added reviewers: Plasma, VDG. ngraham added a comment. IIRC the idea was that people who have specific DPI in mind would type it in, and clicking on the arrows to navigate one at a time would be frustrating--hence the large step size. Maybe we went too far in the direction of efficie

D29435: Fix typo in examples

nicolasfella created this revision. nicolasfella added reviewers: Kirigami, cblack. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REPOSITORY R169 Kirigami BRANCH typo REVISION DETAIL https://phabricator.kde.org/D2

D29432: Use small font for BasicListItem subtitle

This revision was automatically updated to reflect the committed changes. Closed by commit R169:349b80d63429: Use small font for BasicListItem subtitle (authored by ngraham). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29432?vs=81948&id=81952 REVISION DET

D29431: Remove stepsize 24 from DPI spinbox inside kcm fontconfig

kurmikon added a comment. In D29431#663558 , @davidedmundson wrote: > That doesn't explain why we're changing the step size. > > No-one wants to click the up arrow 100 times. I have to set 101 and the default is 96. The arrow are ther

D29431: Remove stepsize 24 from DPI spinbox inside kcm fontconfig

davidedmundson added a comment. That doesn't explain why we're changing the step size. No-one wants to click the up arrow 100 times. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29431 To: kurmikon Cc: davidedmundson, ngraham, plasma-devel, Orage, LeGas

D29432: Use small font for BasicListItem subtitle

ngraham created this revision. ngraham added reviewers: Kirigami, cblack. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Should make @broulik happy. :) TEST PLAN Doesn't actually seem to work with the wall

D29431: Remove stepsize 24 from DPI spinbox inside kcm fontconfig

kurmikon created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kurmikon requested review of this revision. REVISION SUMMARY Since the spinbox read and write the DPI value "as is", without performing any format change, there's no need to set a stepsize o

D29264: New tabs for Breeze

ngraham added a comment. In general I think this is a good direction to move in. However I don't think it's quite ready yet. Small nitpick: this will result in framed tab views having rounded bottom corners, but at least one pointy top corner: F8284555: Screenshot_20200504_140532.png

D29422: Modify kcm fontconfig to get independent subpixel and hintstyle options

kurmikon abandoned this revision. kurmikon added a comment. No changes needed. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29422 To: kurmikon, bport, #plasma Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampalo

D29422: Modify kcm fontconfig to get independent subpixel and hintstyle options

ngraham added a comment. No worries! You have to abandon it: Add Action... > Abandon Revision REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29422 To: kurmikon, bport, #plasma Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jralei

D29422: Modify kcm fontconfig to get independent subpixel and hintstyle options

kurmikon added a comment. In D29422#663389 , @ngraham wrote: > How does subpixel hinting work without anti-aliasing? Good question. I thought they were independent because fontconfig has an hinting option that can be set true or false in

D29394: Add photographic user avatars

ngraham added a comment. In D29394#663180 , @filipf wrote: > In D29394#663012 , @ngraham wrote: > > > This is an improvement, for sure. But what happened to the noodle bowl? I loved that one! >

D29294: Add support for layers to PagePoolAction.

This revision was automatically updated to reflect the committed changes. Closed by commit R169:9c3c2d1a2379: Add support for layers to PagePoolAction. (authored by masonm). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29294?vs=81640&id=81935#toc REPOSITORY R169 Kirigami CHANGES SIN

D29080: [kcms/fonts] Guide users towards KScreen KCM for making things bigger on-screen

ngraham marked 4 inline comments as done. ngraham added a comment. Thanks, improved in 4517ef502169ebd104627a8463543880b3b7f7d. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29080 To: ngraham, #vdg, #plasma, cblack, bport Cc: broulik, romangg, ahmadsamir, pl

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon added a comment. In D29365#663395 , @ngraham wrote: > Of course the problem with a spinbox is that by displaying numbers, it demands some kind of legend or label. What does a value of 100 mean? Does a value of 0 make any sense? etc. The

Re: kwallet-pam >= 5.18.4 and ecryptfs homes

On 5/3/20 4:02 PM, Albert Astals Cid wrote:> Problem with SOLUTION 1 is that it adds lots of code in a relative "sensitive" piece of code like a pam module for for what it is a one time thing. Problem with SOLUTION 2 is that it's not a solution :D Opinions? I feel pretty confident in your sk

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

ngraham added a comment. Of course the problem with a spinbox is that by displaying numbers, it demands some kind of legend or label. What does a value of 100 mean? Does a value of 0 make any sense? etc. The value displayed to the user must make some sense or explained with context. In this

D29422: Modify kcm fontconfig to get independent subpixel and hintstyle options

ngraham added reviewers: bport, Plasma. ngraham added a comment. How does subpixel hinting work without anti-aliasing? I don't know the reason behind limiting the font DPI spinbox to multiples of 24, but that question should be asked elsewhere, not in the description section of a patch,

D29386: [systemtray] Fix SNI icon not rendering

kmaterka added a comment. In D29386#663325 , @ngraham wrote: > Great thanks! Don't forget to merge `Plasma/5.18` into master, fixing the merge conflicts. Merged. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.k

D29386: [systemtray] Fix SNI icon not rendering

ngraham added a comment. Great thanks! Don't forget to merge `Plasma/5.18` into master, fixing the merge conflicts. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29386 To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham Cc: plasma-

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

apol updated this revision to Diff 81926. apol added a comment. Rebase on top of kwayland-server changes REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28884?vs=81343&id=81926 BRANCH arcpatch-D28884 REVISION DETAIL

D29386: [systemtray] Fix SNI icon not rendering

This revision was automatically updated to reflect the committed changes. Closed by commit R120:77975468dc10: [systemtray] Fix SNI icon not rendering (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29386?vs=81903&id=81925 REVIS

D29422: Modify kcm fontconfig to get independent subpixel and hintstyle options

kurmikon created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kurmikon requested review of this revision. REVISION SUMMARY Now kcm fontconfig has **subpixel rendering** and **hintstyle** options depending on **antialiasing**. This means if I disable an

D28487: Redesign of system monitor plasmoids

ngraham added inline comments. INLINE COMMENTS > ConfigAppearance.qml:24 > +import QtQuick.Layouts 1.2 > +import QtQuick.Controls 2.2 as Controls > + `as QQC2` > ConfigSensors.qml:24 > +import QtQuick.Layouts 1.2 > +import QtQuick.Controls 2.2 as Controls > +import QtQml.Models 2.12 `as QQC2`

D28922: Port Sensor Face loading from plasmoid

ngraham added inline comments. INLINE COMMENTS > ConfigAppearance.qml:24 > +import QtQuick.Layouts 1.2 > +import QtQuick.Controls 2.2 as Controls > + `as QQC2` > ConfigAppearance.qml:69 > +delegate: Kirigami.SwipeListItem { > +contentItem: Controls.Label { > +

D28922: Port Sensor Face loading from plasmoid

mart added inline comments. INLINE COMMENTS > ahiemstra wrote in SensorFaceController.h:47 > I think it would be a good idea to make this a list of ids as well. My > current use case would be the "used/total" version of the pie chart that is > used in KSysGuardQML, which would need two "total"

D28154: Add users KCM

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Various bugs I've complained about are still not fixed. 1. The KCM does not display the two-column view when opened in System Settings' default window size until you resize

D29394: Add photographic user avatars

filipf added a comment. In D29394#663012 , @ngraham wrote: > Great, that works. I suppose there's no point in fixing that bug since this KCM is being re-done anyway in D28154 . Once this lands, @cblack can gra

D29155: [Fonts KCM] Remove redundant nearestExistingFont()

bport added a comment. I don't think we will have same behavior, we don't only check name but also size, type... If we are ok to fallback in all case to the same font that can work. From your test plan, something look strange you don't end with a monospaced font for fixed font as fallb

D29366: [Wallpaper Configuration] Remove obsolete inline message concerning widget locking

filipf updated this revision to Diff 81911. filipf added a comment. restore the inline message but change its text to note that layout changes have been restricted by the sysadmin REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29366?vs=81756&id=8191

D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout

filipf updated this revision to Diff 81910. filipf marked an inline comment as done. filipf added a comment. Replace PropertyAnimation with NumberAnimation REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29351?vs=81709&id=81910 BRANCH no-logo-lea

D29395: Refactor MediaController

broulik added a comment. Generally +1 Nice idea with this `Media` singleton INLINE COMMENTS > ExpandedRepresentation.qml:65 > +} > +Media.lockPositionUpdate= false > +} Coding style, space > ExpandedRepresentation.qml:99 > seekSlider.value

D28487: Redesign of system monitor plasmoids

alexde added a comment. Not sure, if this is part of the scope of this work, but do you also plan to add some meaningful labels and ticks to the axis? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28487 To: mart, #plasma Cc: alexde, ngraham, ksmanis, davi

D29315: [applets/batterymonitor] Port inhibition message to Layouts and match notifications applet

broulik added inline comments. INLINE COMMENTS > PowerManagementItem.qml:62 > +Layout.fillWidth: true > +Layout.leftMargin: units.gridUnit + units.smallSpacing // width of > checkbox and spacer > spacing: units.smallSpacing Try if this works with right-to-left layout, o

D29315: [applets/batterymonitor] Port inhibition message to Layouts and match notifications applet

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d62fd2dd58c8: [applets/batterymonitor] Port inhibition message to Layouts and match… (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D29075: [wallpapers/image] Port to BasicListItem+subtitle

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:71f1ff8e50b0: [wallpapers/image] Port to BasicListItem+subtitle (authored by ngraham). CHANGED PRIOR TO COMMIT https

D29401: [KRunner] Fix watched config file path

ksmanis closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29401 To: ksmanis, #plasma, ngraham Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliez

D28141: Add KSysGuard::Sensors library

ngraham added a comment. +1, excellent work. INLINE COMMENTS > Sensor.cpp:2 > +/* > +Copyright (C) 2019 Vlad Zagorodniy > +Copyright (C) 2020 Arjen Hiemstra Update name > Sensor.cpp:219 > + > +if(parent() && parent()->metaObject()->indexOfSignal("enabledChanged()") > != -1) {

D28487: Redesign of system monitor plasmoids

ngraham added a comment. Looks fantastic! However I've applied the dependent patches, but this doesn't compile for me: In member function ‘virtual void SystemMonitor::init()’: /home/nate/kde/src/plasma-workspace/applets/systemmonitor/systemmonitor/systemmonitor.cpp:63:78: err

D29411: [KRunner] Watch config with KConfigWatcher

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6db69ae09524: [KRunner] Watch config with KConfigWatcher (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29411?vs=81896&id=81904#toc REPOSITORY R120 Plasma Workspace C

D29386: [systemtray] Fix SNI icon not rendering

kmaterka updated this revision to Diff 81903. kmaterka added a comment. Additional check for real JavaScript null - to avoid conversion errors in native method. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29386?vs=81803&id=81903 BRANCH Plasm

D29410: [Runners KCM] Notify history deletion

This revision was automatically updated to reflect the committed changes. Closed by commit R119:8fe03502660c: [Runners KCM] Notify history deletion (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29410?vs=81895&id=81901 REVISION D

D29411: [KRunner] Watch config with KConfigWatcher

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yeah, much nicer! Thanks. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29411 To: broulik, #plasma, ngraham, ksmanis Cc: plasma-devel, Orage, LeGast00

D29379: Unassign activity from vault on activity deletion

ivan closed this revision. REVISION DETAIL https://phabricator.kde.org/D29379 To: ivan, ngraham, davidedmundson, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abe

D29386: [systemtray] Fix SNI icon not rendering

kmaterka added a comment. In D29386#662960 , @ngraham wrote: > Great catch. The logic seems sane to me. Note that if you plan to land this on the stable branch, there will be merge conflicts that you'll need to resolve carefully, since it looks

D29411: [KRunner] Watch config with KConfigWatcher

broulik created this revision. broulik added reviewers: Plasma, ngraham, ksmanis. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Rather than using a `KDirWatch` that points to the wrong place. TEST PLAN 5.18

D29410: [Runners KCM] Notify history deletion

broulik created this revision. broulik added reviewers: Plasma, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY So KRunner can catch that in a `KConfigWatcher` REPOSITORY R119 Plasma Desktop REVISIO

D29394: Add photographic user avatars

ngraham added a subscriber: cblack. ngraham added a comment. Great, that works. I suppose there's no point in fixing that bug since this KCM is being re-done anyway in D28154 . Once this lands, @cblack can grab these and add them to that patch. However

D29401: [KRunner] Fix watched config file path

ngraham added a comment. Maybe we can do that on master and land this on the stable branch? REPOSITORY R120 Plasma Workspace BRANCH krunner-fix-watched-config-path (branched from master) REVISION DETAIL https://phabricator.kde.org/D29401 To: ksmanis, #plasma, ngraham Cc: ngraham, brou

D29401: [KRunner] Fix watched config file path

broulik added a comment. Ideally, we'd change the KCM to write the key with `KConfig::Notify` and then use `KConfigWatcher` here REPOSITORY R120 Plasma Workspace BRANCH krunner-fix-watched-config-path (branched from master) REVISION DETAIL https://phabricator.kde.org/D29401 To: ksman

D29401: [KRunner] Fix watched config file path

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Good catch! Seems worthy of landing on the stable branch? What do you think, @broulik? REPOSITORY R120 Plasma Workspace BRANCH krunner-fix-watched-config-path (branched from master)

D28922: Port Sensor Face loading from plasmoid

ahiemstra added inline comments. INLINE COMMENTS > mart wrote in SensorFaceController.cpp:247 > perhaps line chart? I was more thinking something along the lines of a new face that's either completely empty or displays a "not configured" message. REPOSITORY R111 KSysguard Library REVISION D

D28888: Fix navigation regressions

This revision was automatically updated to reflect the committed changes. Closed by commit R1014:f98e5d33f46b: Fix navigation regressions (authored by cblack). REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2?vs=81713&id=81889 REVISION DETAIL

D29106: Introduce RouterWindow control

This revision was automatically updated to reflect the committed changes. Closed by commit R169:d2060bf4a12a: Introduce RouterWindow control (authored by cblack). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29106?vs=80922&id=81888 REVISION DETAIL https:

D28740: [Notifications] Don't show do not disturb end date beyond 100 days

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. All right let's do that on the stable branch to fix the bug and then change the string in master to be consistent. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricato

D29386: [systemtray] Fix SNI icon not rendering

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Great catch. The logic seems sane to me. Note that if you plan to land this on the stable branch, there will be merge conflicts that you'll need to resolve carefully, since it looks like

D29307: Implement smallFont in Kirigami plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R858:5b8868783c01: Implement smallFont in Kirigami plugin (authored by cblack). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29307?vs=81642&

D28922: Port Sensor Face loading from plasmoid

mart added inline comments. INLINE COMMENTS > ahiemstra wrote in SensorFaceController.cpp:77 > Similar to above, does it still make sense to use "Plasma/Applet" here? it kinda has to, as the original idea is to be able to use any preset as it was a standalone applet, so creating a preset means

D28922: Port Sensor Face loading from plasmoid

mart updated this revision to Diff 81882. mart marked 7 inline comments as done. mart added a comment. - start to port other faces - port faces to new api - add missing file - adapt to api changes - adress a part of comments REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDAT

D29394: Add photographic user avatars

filipf added a comment. In D29394#662776 , @ognarb wrote: > Photo using the Unsplash license can't be included in our repositories. The license is not considered open-source :( We should contact the artists if they are willing to license their p

D28333: Add a new daemon for stats monitoring

davidedmundson updated this revision to Diff 81871. davidedmundson marked an inline comment as done. davidedmundson added a comment. Clear up plugin loading REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28333?vs=81087&id=81871 BRANCH master REVISION

D29312: Change microphoneindicator for reporting audio monitors

kurmikon added a comment. Pulseaudio is an abstraction layer over alsa. You, as a developer, can record sources in many ways, but since it's an abstraction layer, you can't be really sure whether the source is a microphone or not. There's a discussion on github where a user was asking on

D29046: ColorUtils: Use const ref for QColor/QJSValue, fix code style

This revision was automatically updated to reflect the committed changes. Closed by commit R169:a6bf4a67f099: ColorUtils: Use const ref for QColor/QJSValue, fix code style (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29046?vs=80747&

Monday meeting notes for 4/5/2020

Nico: Kirigami: * Bundle some missing icons for Android https://phabricator.kde.org/D29276 Diff 29276 "Bundle icons for inline messages" [Closed] https://phabricator.kde.org/D29276 * Fixed excessive padding in scrollable pages https://phabricator.kde.org/D29308 Diff 29308 "Fix excessive rig

D29344: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added

kmaterka added a comment. Separate Bug 420993 created for Media Player icon not rendering correctly. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29344 To: kmaterka, #plasma_workspaces, #plasma, ngraham, brou

D29401: [KRunner] Fix watched config file path

ksmanis added a comment. Nope, different bugs, similar solutions. I can still reproduce the other bug (I never noticed it before btw). I am not sure if this patch fixes any other regressions other than the Clear History button in the KCM. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D29324: [Network Monitor] Show correct bitrate

ksmanis added a comment. Yeah, unfortunately I took notice after submitting the revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29324 To: ksmanis, #plasma Cc: mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampa

D29401: [KRunner] Fix watched config file path

broulik added a comment. That's not the bug I tried to solve in D26444 , was it? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29401 To: ksmanis, #plasma Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cb

D29402: KCM Fonts .fonts.conf was not updated and enforce consistency through UI

crossi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29402 AFFECTED FILES kcms/fonts/fontsaasettings.cpp kcms/fonts/font

D29401: [KRunner] Fix watched config file path

ksmanis created this revision. ksmanis added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ksmanis requested review of this revision. REVISION SUMMARY The "Clear History" button in the KCM is currently broken, since we are not watching the actual

D29394: Add photographic user avatars

ognarb added a comment. Photo using the Unsplash licence can't be included in our repositories. The license is not consired open source :( REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D29394 To: filipf, #vdg, ngraham Cc: ognarb, plasma-devel, Orage, LeGast00n

Re: repo freeze tomorrow

Hi Jonathan, Thank you, will do! Aleix On Fri, May 1, 2020 at 5:27 PM Jonathan Riddell wrote: > > So modules to be released are same as last time plus kwayland-server. The > cmake setup of the repo looks good to me. > > Let me know if you need any help releasing plasma-wayland-protocols > > Jo

D29312: Change microphoneindicator for reporting audio monitors

kurmikon added a comment. In D29312#662773 , @mart wrote: > i think i would prefer a somewhat inaccurate message, rather than an obscuretecnicism which is technically accurate ( I don't agree, but what do you suggest considering that now

D29312: Change microphoneindicator for reporting audio monitors

mart added a comment. i think i would prefer a somewhat inaccurate message, rather than an obscuretecnicism which is technically accurate ( REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D29312 To: kurmikon, #vdg, #plasma, drosca, broulik Cc: mart

D29324: [Network Monitor] Show correct bitrate

mart added a comment. note that there is a whole rewrite pending for all systemmonitor applets in D28487 (and several related diffs) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29324 To: ksmanis, #plasma Cc: mart, pl

D29344: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added

This revision was automatically updated to reflect the committed changes. Closed by commit R120:026a29174279: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kd

D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. unfortunately yeah, i had to port away from opacityanimator several places for this reason :( INLINE COMMENTS > Main.qml:449 > +// OpacityAnimator when starting from

D29366: [Wallpaper Configuration] Remove obsolete inline message concerning widget locking

mart added a comment. In D29366#661956 , @filipf wrote: > Ok, so the message can indeed still be turned on. > > Setting: > `~/.config/plasmarc [General] immutability=2 (or 4)` > > ... does not work, however the following does: > > `

D28740: [Notifications] Don't show do not disturb end date beyond 100 days

broulik added a comment. I find "for a year" odd. Also, this is a bug fix, so can we get this in or not. Changing strings can then be done in master, if we want to. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28740 To: broulik, #plasma Cc: ngraham, bpor

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon updated this revision to Diff 81847. kurmikon added a comment. The spinbox would be better a better solution. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29365?vs=81755&id=81847 REVISION DETAIL https://phabricator.kde.org/D29365 AFFEC

D29344: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added

kmaterka updated this revision to Diff 81842. kmaterka added a comment. Change warning message REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29344?vs=81724&id=81842 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29344 AFFECTED F

D29344: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added

kmaterka added a comment. In D29344#662586 , @ngraham wrote: > 5.19 hasn't branched yet, so code landed in master will still make it there. Maybe there was code freeze for frameworks? Or 5.18.5? Never mind :) > With this patch, I stil