ngraham added reviewers: bport, Plasma.
ngraham added a comment.

  How does subpixel hinting work without anti-aliasing?
  
  I don't know the reason behind limiting the font DPI spinbox to multiples of 
24, but that question should be asked elsewhere, not in the description section 
of a patch, which will become a commit message if this patch lands.

INLINE COMMENTS

> main.qml:219
>                  textRole: "display"
> -                enabled: antiAliasingCheckBox.checked
> +                enabled: true
>                  popup.height: popup.implicitHeight

`true` is the default value; no need to set this at all then

> main.qml:256
>                  textRole: "display"
> -                enabled: antiAliasingCheckBox.checked
> +                enabled: true
>                  popup.height: popup.implicitHeight

ditto

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29422

To: kurmikon, bport, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to