D29319: KCM Plasmasearch: Do not intialize runners in config module

alex created this revision. alex added reviewers: Plasma, davidedmundson, ngraham, meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY The runners are loaded from the plugin info list `Plasma::RunnerManager::li

Re: Information regarding upcoming Gitlab Migration: clarifications

On Fri, May 1, 2020 at 4:38 PM Nate Graham wrote: > > > > On 4/30/20 5:59 PM, Aleix Pol wrote: > > El jue., 30 de abr. de 2020 a la(s) 18:15, Albert Astals Cid > >> Am I the only person that just has all the repos on the same folder? I > >> thought it was the common thing to do :? > > > > I do to

Re: Information regarding upcoming Gitlab Migration

On Fri, May 1, 2020 at 2:46 AM Nate Graham wrote: > > If I'm understanding things, we have solutions to most or all of the > objections raised so far: > > - Projects will be allowed to live in--or at least appear in--multiple > top-level groups (e.g. plasma-framework could appear in both the > Fra

Re: Information regarding upcoming Gitlab Migration: clarifications

On 4/30/20 5:59 PM, Aleix Pol wrote: El jue., 30 de abr. de 2020 a la(s) 18:15, Albert Astals Cid Am I the only person that just has all the repos on the same folder? I thought it was the common thing to do :? I do too Same here. kdesrc-build's default settings do this, and download all

D27960: Make it possible to scroll through the padding

ngraham added a comment. I'm afraid that for me there is no change from last time. :( If a two-finger scroll event is initiated to the left or right of the application screenshots component, the scroll behavior is really jerky and weird. Do you need a video or something? REPOSITORY R169 K

D29307: Implement smallFont in Kirigami plugin

cblack updated this revision to Diff 81642. cblack added a comment. Add explanatory comment REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29307?vs=81609&id=81642 BRANCH cblack/smallfont (branched from master) REVISION DETAIL

Re: repo freeze tomorrow

On Thu, Apr 30, 2020 at 7:57 PM Rik Mills wrote: > > On 30/04/2020 18:33, Aleix Pol wrote: > > Yes, in practice. > > In practice? What other way is there? Now I check some more they seem > very non-optional. I mean that plasma-wayland-protocols is supposed to be released outside of Plasma (as it

D29312: Change microphoneindicator for reporting audio monitors

kurmikon added a comment. @nicolasfella if an application is recording directly from an input device (a simple microphone), your hint would be the solution: we should check and exclude sink source monitors. This way PulseEffects would be correctly excluded. But I was thinking a special

Re: Information regarding upcoming Gitlab Migration: clarifications

On Fri, May 1, 2020 at 1:08 AM Nicolás Alvarez wrote: > > El jue., 30 de abr. de 2020 a la(s) 18:15, Albert Astals Cid > (aa...@kde.org) escribió: > > > > El dijous, 30 d’abril de 2020, a les 21:31:02 CEST, Ben Cooksley va > > escriure: > > > On Fri, May 1, 2020 at 6:04 AM Ivan Čukić wrote: > >

D29294: Add support for layers to PagePoolAction.

masonm updated this revision to Diff 81640. masonm added a comment. Fix preventing layer from pushing itself REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29294?vs=81619&id=81640 BRANCH add-pagepool-layer-support (branched from master) REVISION DETAIL

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.14 - Build # 59 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.14/59/ Project: kf5-qt5 SUSEQt5.14 Date of build: Thu, 30 Apr 2020 22:03:20 + Build duration: 1 hr 39 min and counting JUnit Tests Name: (root) Failed: 0 tes

D28321: [WIP] [applets/devicenotifier] Port to ExpandableListItem

dfaure added inline comments. INLINE COMMENTS > broulik wrote in DeviceItem.qml:34 > This is all over the place for me. All the free space jobs in the dataengine > get the root size back. Not sure if a local issue or KIO? @dfaure Please give me a proper bug report in KIO terms :-) What class do

Re: Information regarding upcoming Gitlab Migration: clarifications

El jue., 30 de abr. de 2020 a la(s) 18:15, Albert Astals Cid (aa...@kde.org) escribió: > > El dijous, 30 d’abril de 2020, a les 21:31:02 CEST, Ben Cooksley va escriure: > > On Fri, May 1, 2020 at 6:04 AM Ivan Čukić wrote: > > > > > > > We have made a big fuss in the past about having different pro

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.14 - Build # 70 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.14/70/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 30 Apr 2020 22:03:22 + Build duration: 27 min and counting JUnit Tests Name: projectroot Failed:

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.14 - Build # 48 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.14/48/ Project: kf5-qt5 SUSEQt5.14 Date of build: Thu, 30 Apr 2020 22:03:18 + Build duration: 10 min and counting JUnit Tests Name: (root) Failed:

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.14 - Build # 61 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.14/61/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 30 Apr 2020 22:03:20 + Build duration: 2 min 41 sec and counting JUnit Tests Name: pro

KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.14 - Build # 8 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.14/8/ Project: kf5-qt5 SUSEQt5.14 Date of build: Thu, 30 Apr 2020 22:03:17 + Build duration: 2 min 4 sec and counting JUnit Tests Name: (root) Failed: 0

KDE CI: Plasma » powerdevil » kf5-qt5 FreeBSDQt5.14 - Build # 9 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20FreeBSDQt5.14/9/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 30 Apr 2020 22:03:18 + Build duration: 1 min 46 sec and counting

2 new repositories: plasma-wayland-protocols and kwayland-server

Hi everyone, After long discussions, we have broken kwayland into 3 pieces so we can work and improve kwin_wayland without having to extend our stable framework constantly. This of course comes together with an updated policy with regards to where things should be developed with the goal of only ad

Re: Information regarding upcoming Gitlab Migration: clarifications

El dijous, 30 d’abril de 2020, a les 21:31:02 CEST, Ben Cooksley va escriure: > On Fri, May 1, 2020 at 6:04 AM Ivan Čukić wrote: > > > > > We have made a big fuss in the past about having different projects > > > that do the same thing and now we'll have that but also we'll have > > > several proj

D26636: [Widget Explorer] Work around bad kerning

filipf abandoned this revision. filipf added a comment. Should be fixed upstream https://bugreports.qt.io/browse/QTBUG-49646 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26636 To: filipf, #plasma, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev

D26646: [Applet Configuration] Work around bad kerning in sidebar labels

filipf abandoned this revision. filipf added a comment. Should be fixed upstream https://bugreports.qt.io/browse/QTBUG-49646 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26646 To: filipf, #plasma, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev

D29315: [applets/batterymonitor] Port inhibition message to Layouts and match notifications applet

ngraham created this revision. ngraham added reviewers: VDG, Plasma, broulik, manueljlin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This makes it take up less vertical space in the header area and also mat

D29312: Change microphoneindicator for reporting audio monitors

kurmikon added a comment. In D29312#660704 , @nicolasfella wrote: > In D29312#660702 , @kurmikon wrote: > > > In D29312#660670 , @nicolasfella wrote: >

D29312: Change microphoneindicator for reporting audio monitors

nicolasfella added a comment. In D29312#660702 , @kurmikon wrote: > In D29312#660670 , @nicolasfella wrote: > > > > but due to a lack in qt libraries > > > > Can you elaborate on this? What is Qt

D29312: Change microphoneindicator for reporting audio monitors

kurmikon added a comment. In D29312#660670 , @nicolasfella wrote: > > but due to a lack in qt libraries > > Can you elaborate on this? What is Qt lacking? I'm not an expert, so I don't really know. Reading the bug report, there's no

Re: Information regarding upcoming Gitlab Migration: clarifications

On Fri, May 1, 2020 at 5:58 AM Nate Graham wrote: > > > > On 4/30/20 11:43 AM, Aleix Pol wrote: > > IMHO needing tools ad-hoc to KDE development can be a barrier of entrance. > > I feel like these things make us look distant, it's important that > > people's skills translate automatically when the

Re: Information regarding upcoming Gitlab Migration: clarifications

On Fri, May 1, 2020 at 6:04 AM Ivan Čukić wrote: > > > We have made a big fuss in the past about having different projects > > that do the same thing and now we'll have that but also we'll have > > several projects with the same name? > > It really feels off to me and I wonder if this is related t

Re: Information regarding upcoming Gitlab Migration: clarifications

On Fri, May 1, 2020 at 5:44 AM Aleix Pol wrote: > > On Wed, Apr 29, 2020 at 12:25 PM Bhushan Shah wrote: > > > > Good afternoon, > > > > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for > > replies] > > > > I want to clarify some bits for which we have gotten a questions about, >

D29308: Fix excessive right padding in scrollable page

This revision was automatically updated to reflect the committed changes. Closed by commit R169:e97ffaa7a6b3: Fix excessive right padding in scrollable page (authored by nicolasfella). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29308?vs=81611&id=81626 RE

D29312: Change microphoneindicator for reporting audio monitors

nicolasfella added a comment. > but due to a lack in qt libraries Can you elaborate on this? What is Qt lacking? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D29312 To: kurmikon, #vdg, #plasma, drosca, broulik Cc: nicolasfella, ngraham, plas

D29312: Change microphoneindicator for reporting audio monitors

ngraham added inline comments. INLINE COMMENTS > microphoneindicator.cpp:264 > { > -// If there are no microphones present, there's nothing to record > -if (m_sourceModel->rowCount() == 0) { I don't think this needs to be removed. If an app is "monitoring audio" but there 's no audio r

D29312: Change microphoneindicator for reporting audio monitors

ngraham added reviewers: VDG, Plasma, drosca, broulik. ngraham added a comment. This is more accurate given the technical constraints, yeah. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D29312 To: kurmikon, #vdg, #plasma, drosca, broulik Cc: ngra

D29312: Change microphoneindicator for reporting audio monitors

kurmikon created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kurmikon requested review of this revision. REVISION SUMMARY Microphone indicator was introduced to report applications using a microphone. That wasn't a bad idea, but due to a lack in q

D29311: Emit low battery notification immediately when plugging out AC

broulik planned changes to this revision. broulik added a comment. Hmm, odd, will have to do further testing then REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D29311 To: broulik, #plasma Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jra

D29294: Add support for layers to PagePoolAction.

masonm updated this revision to Diff 81619. masonm marked an inline comment as not done. masonm added a comment. Add _private QtObject back and comment why REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29294?vs=81610&id=81619 BRANCH add-pagepool-layer-

D29311: Emit low battery notification immediately when plugging out AC

ngraham added a comment. Yep I get the sound, and the display brightness falls immediately. It's just thew low battery notification that doesn't appear immediately. (nice catch, BTW) REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D29311 To: broulik, #plasma

D29294: Add support for layers to PagePoolAction.

masonm marked an inline comment as not done. masonm added inline comments. INLINE COMMENTS > cblack wrote in PagePoolAction.qml:161 > this isn't how you do private objects, drop `property QtObject _private` and > access by ID Actually I realized why I did this now: the Action type does not allo

D29311: Emit low battery notification immediately when plugging out AC

broulik added a comment. Do you get the sound that you unplugged? For me it sometimes took quite a while for it to actually recognize I unplugged REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D29311 To: broulik, #plasma Cc: ngraham, plasma-devel, Orage, LeGast00

D29311: Emit low battery notification immediately when plugging out AC

ngraham added a comment. Hmm, this isn't working for me, or else I'm not testing it correctly. I set the "low battery threshold" to 99% while my battery is only 93% charged and, unplug my cord. I should see a notification, right? But I don't. REPOSITORY R122 Powerdevil REVISION DETAIL

D29307: Implement smallFont in Kirigami plugin

ngraham added a comment. It would be good to explain why we need to use DBus for this, when it wasn't already implemented for the normal font size. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D29307 To: cblack, #kirigami Cc: ngraham, pl

KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.14 - Build # 7 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.14/7/ Project: kf5-qt5 SUSEQt5.14 Date of build: Thu, 30 Apr 2020 18:05:14 + Build duration: 1 min 39 sec and counting CONSOLE OUTPUT [...truncated 118

D29309: Make low battery notification critical

This revision was automatically updated to reflect the committed changes. Closed by commit R122:45dd7bbfe18b: Make low battery notification critical (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29309?vs=81615&id=81618#toc REPOSITORY R122 Powerdevil CHANGES SIN

KDE CI: Plasma » powerdevil » kf5-qt5 FreeBSDQt5.14 - Build # 8 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20FreeBSDQt5.14/8/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 30 Apr 2020 18:05:13 + Build duration: 20 sec and counting CONSOLE OUTPUT [...truncated 79 l

Re: Information regarding upcoming Gitlab Migration: clarifications

> We have made a big fuss in the past about having different projects > that do the same thing and now we'll have that but also we'll have > several projects with the same name? > It really feels off to me and I wonder if this is related to the move to > gitlab. +1 to both sentiments - that projec

D29311: Emit low battery notification immediately when plugging out AC

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When plugging out AC, emit a low battery notification immediately, so one is notified of the fact

D29309: Make low battery notification critical

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1 REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D29309 To: broulik, #plasma, #vdg, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cb

D29309: Make low battery notification critical

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This ensures you have to acknowledge it and be aware that the battery is running low. Other

D29308: Fix excessive right padding in scrollable page

nicolasfella added a comment. Mobile before: F8274015: Screenshot_20200430_195955.png Mobile after: F8274019: Screenshot_20200430_200111.png REPOSITORY R169 Kirigami REVISION DETAIL https://phabricato

Re: Information regarding upcoming Gitlab Migration: clarifications

On 4/30/20 11:43 AM, Aleix Pol wrote: IMHO needing tools ad-hoc to KDE development can be a barrier of entrance. I feel like these things make us look distant, it's important that people's skills translate automatically when they want to get started. True, but if you're a new contributor, pr

Re: repo freeze tomorrow

On 30/04/2020 18:33, Aleix Pol wrote: > Yes, in practice. In practice? What other way is there? Now I check some more they seem very non-optional.

D29308: Fix excessive right padding in scrollable page

ngraham added a comment. Probably a legacy of the now-removed overlay scrollbars on the desktop. Does this still work when overlay scrollbars are being used on mobile? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29308 To: nicolasfella, #kirigami, mart Cc: ngrah

D29308: Fix excessive right padding in scrollable page

nicolasfella created this revision. nicolasfella added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY In this example import QtQuick 2.5 import QtQuick.Layouts 1.1

D29301: [applets/mediacontroller] Elide text

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Much better, thanks. REPOSITORY R120 Plasma Workspace BRANCH cblack/layout-fixeroni (branched from master) REVISION DETAIL https://phabricator.kde.org/D29301 To: cblack, #vdg, bro

Re: Information regarding upcoming Gitlab Migration: clarifications

On Wed, Apr 29, 2020 at 12:25 PM Bhushan Shah wrote: > > Good afternoon, > > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for > replies] > > I want to clarify some bits for which we have gotten a questions about, > > - Non unique naming: There's some teams which prefer if we dropp

Re: repo freeze tomorrow

Yes, in practice. Aleix On Thu, Apr 30, 2020 at 6:19 PM Rik Mills wrote: > > On 29/04/2020 22:04, David Edmundson wrote: > > We have something announced that I'm not sure is on the list. > > > > Plasma will gain a new repo called kwayland-server. > > This is a split of half the code currently in

D29294: Add support for layers to PagePoolAction.

masonm updated this revision to Diff 81610. masonm added a comment. Code review changes 1 REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29294?vs=81606&id=81610 BRANCH add-pagepool-layer-support (branched from master) REVISION DETAIL https://phabrica

D29307: Implement smallFont in Kirigami plugin

cblack created this revision. cblack added a reviewer: Kirigami. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. TEST PLAN F8273961: image.png F8273893: font.qml

D29294: Add support for layers to PagePoolAction.

cblack added inline comments. INLINE COMMENTS > tst_layers.qml:19-25 > +function initTestCase() { > +mainWindow.show() > +} > + > +function cleanupTestCase() { > +mainWindow.close() > +} You want to use `when: windowShown` > tst_layers.qml:27 > + > +function

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.14 - Build # 60 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.14/60/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 30 Apr 2020 16:51:23 + Build duration: 1 min 17 sec and counting CONSOLE OUTPUT [...tru

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.14 - Build # 47 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.14/47/ Project: kf5-qt5 SUSEQt5.14 Date of build: Thu, 30 Apr 2020 16:51:23 + Build duration: 1 min 28 sec and counting CONSOLE OUTPUT [...truncated

D28744: Rewrite of the global shortcuts kcm

This revision was automatically updated to reflect the committed changes. Closed by commit R119:1ee6660ceb62: Rewrite of the global shortcuts kcm (authored by davidre). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28744?vs=81441&id=81607 REVISION DET

D29294: Add support for layers to PagePoolAction.

masonm updated this revision to Diff 81606. masonm added a comment. Handle checked status with exclusive groups REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29294?vs=81588&id=81606 BRANCH add-pagepool-layer-support (branched from master) REVISION DET

D29304: Introduce Theme::smallFont

This revision was automatically updated to reflect the committed changes. Closed by commit R169:9368dcc28f66: Introduce Theme::smallFont (authored by cblack). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29304?vs=81603&id=81604 REVISION DETAIL https://ph

D29304: Introduce Theme::smallFont

mart added inline comments. INLINE COMMENTS > basictheme.cpp:74 > +setDefaultFont(qApp->font()); > +setSmallFont([]() { > +auto smallFont = qApp->font(); you can just do a temp smallfont and then setFont with it without the lambda REPOSITORY R169 Kirigami REVISION

D29304: Introduce Theme::smallFont

cblack updated this revision to Diff 81603. cblack added a comment. Drop Rust-ism REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29304?vs=81601&id=81603 BRANCH cblack/smallFont (branched from master) REVISION DETAIL https://phabricator.kde.org/D29304

D29304: Introduce Theme::smallFont

cblack created this revision. cblack added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY Like defaultFont, but smaller. TEST PLAN F8273893: font.qml

Re: repo freeze tomorrow

On 29/04/2020 22:04, David Edmundson wrote: > We have something announced that I'm not sure is on the list. > > Plasma will gain a new repo called kwayland-server. > This is a split of half the code currently in framework. > > Aleix has things prepared, but we haven't done all the steps to making

D29301: [applets/mediacontroller] Elide text

cblack updated this revision to Diff 81598. cblack retitled this revision from "[applets/mediacontroller] Drop maximum height on songTitle" to "[applets/mediacontroller] Elide text". cblack edited the test plan for this revision. cblack added a comment. Elide text REPOSITORY R120 Plasma Wor

D29074: Make BasicListItem more useful by giving it a subtitle property

This revision was automatically updated to reflect the committed changes. Closed by commit R169:432b5d3d456c: Make BasicListItem more useful by giving it a subtitle property (authored by ngraham). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29074?vs=81592&

D29302: Use KSysGuard namespace for KSysGuard library targets

ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY Instead of using KF5 which is wrong since KSysGuard isn't part of frameworks. This ne

D28321: [WIP] [applets/devicenotifier] Port to ExpandableListItem

broulik added a subscriber: dfaure. broulik added inline comments. INLINE COMMENTS > DeviceItem.qml:32 > > -MouseArea { > +// TODO: fix expanding when a new device is connected; done in > devicenotifier.qml > +// TODO: clean up list item expanding code in devicenotifier.qml There's an `expand

D29301: [applets/mediacontroller] Drop maximum height on songTitle

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. That ain't gonna work F8273712: Screenshot_20200430_090409.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabrica

D29301: [applets/mediacontroller] Drop maximum height on songTitle

cblack created this revision. cblack added reviewers: VDG, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. TEST PLAN Before: F8273701: image.png After: F8273704: image.png

D29074: Make BasicListItem more useful by giving it a subtitle property

ngraham updated this revision to Diff 81592. ngraham marked 2 inline comments as done. ngraham added a comment. Address review comments REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29074?vs=80815&id=81592 BRANCH more-capable-BasicListItem (branched fr

D29074: Make BasicListItem more useful by giving it a subtitle property

cblack added inline comments. INLINE COMMENTS > BasicListItem.qml:31 > + * Optional; if not defined, the list item will only have a main label > + * @since 2.12 > + */ @since 5.70 @since org.kde.kirigami 2.12 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.or

D29074: Make BasicListItem more useful by giving it a subtitle property

mart added inline comments. INLINE COMMENTS > BasicListItem.qml:120 > +elide: Text.ElideRight > +font.pointSize: theme.smallestFont.pointSize > +opacity: 0.6 from plasma style, can't be used REPOSITORY R169 Kirigami REVISION DETAIL https://ph

Re: Information regarding upcoming Gitlab Migration

If I'm understanding things, we have solutions to most or all of the objections raised so far: - Projects will be allowed to live in--or at least appear in--multiple top-level groups (e.g. plasma-framework could appear in both the Frameworks top-level group and also the Plasma top-level group)

D28744: Rewrite of the global shortcuts kcm

ngraham accepted this revision. ngraham added a comment. My spacebar shortcut issue will be fixed with D29292 . I think this deserves to get into Plasma 5.19, and the sooner the better so there's no rush before the deadline. REPOSITORY R119 Plasma Deskto

D29294: Add support for layers to PagePoolAction.

masonm updated this revision to Diff 81588. masonm added a comment. Honor checkable state of Action REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29294?vs=81562&id=81588 BRANCH add-pagepool-layer-support (branched from master) REVISION DETAIL https:

Re: repo freeze tomorrow

Are there any specific steps needed? I tried to make it so the cmake variables on the /CMakeLists.txt are named like in Plasma. We will also need plasma-wayland-protocols released as kdesupport soon. Right now I'm trying to make sure all is well on the CI side. Aleix On Wed, Apr 29, 2020 at 11:0

D29297: [Notifications] Have checkIndex check if the index is valid

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Apparently by default it only considers "out of range" indices invalid but an invalid one as vali

D29279: Don't play volume feedback if max volume is reached

ngraham added a comment. In D29279#660153 , @broulik wrote: > If any, we should block repeated feedback sounds when pressing and holding the key without the volume changing but pressing the key once should always play the respective sound.

D29296: [KCMs/Notifications] Port placeholder message to Kirigami.PlaceholderMessage

ngraham created this revision. ngraham added reviewers: VDG, Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. TEST PLAN F8273471: Screenshot_20200430_071412.png REPOSITORY

D28141: Add KSysGuard::Sensors library

ahiemstra updated this revision to Diff 81577. ahiemstra added a comment. Don't eat the lib Arc REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28141?vs=81576&id=81577 BRANCH sensors_lib REVISION DETAIL https://phabricator.kde.org/D28141 AFF

D28141: Add KSysGuard::Sensors library

ahiemstra updated this revision to Diff 81576. ahiemstra added a comment. - Don't expose private SensorInfo in public interface of SensorQuery REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28141?vs=80758&id=81576 BRANCH sensors_lib REVISION D

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.14 - Build # 58 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.14/58/ Project: kf5-qt5 SUSEQt5.14 Date of build: Thu, 30 Apr 2020 11:28:47 + Build duration: 1 min 1 sec and counting CONSOLE OUTPUT [...truncated 117 lines.

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.14 - Build # 69 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.14/69/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 30 Apr 2020 10:56:33 + Build duration: 43 sec and counting CONSOLE OUTPUT [...truncated 78 lines.

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.14 - Build # 57 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.14/57/ Project: kf5-qt5 SUSEQt5.14 Date of build: Thu, 30 Apr 2020 10:56:33 + Build duration: 48 sec and counting CONSOLE OUTPUT [...truncated 117 lines...][2

D28922: Port Sensor Face loading from plasmoid

ahiemstra added inline comments. INLINE COMMENTS > SensorFaceController.h:42 > + > +class FACES_EXPORT SensorFaceController : public QObject > +{ Can you place this class (and related classes) in the KSysGuard namespace? Then it would match the rest of the libraries. REPOSITORY R111 KSysguar

D28922: Port Sensor Face loading from plasmoid

ahiemstra added inline comments. INLINE COMMENTS > CMakeLists.txt:52 > KF5::I18n > +KF5::Package > +KF5::ConfigCore This is no longer needed. > CMakeLists.txt:5 > > -target_link_libraries(SensorsPlugin Qt5::Qml KSysGuard::Sensors > KF5::ProcessCore) > +target_link_li

D29130: [Applet] Show in system tray iff at least one vault is open

ksmanis added a comment. It seems to me that this revision does not have the required momentum to move forward. I'll keep it open for another week in case someone else wants to chime in, but unless something changes I'll abandon it and maintain it off tree for personal use. REPOSITORY R84

D29285: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader()

This revision was automatically updated to reflect the committed changes. Closed by commit R119:9bbd2645626e: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader() (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde

D29285: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader()

broulik added a comment. shipit REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29285 To: crossi, #plasma, bport, broulik Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesj

D29285: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader()

crossi updated this revision to Diff 81567. crossi added a comment. consider Kai's comments REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29285?vs=81536&id=81567 REVISION DETAIL https://phabricator.kde.org/D29285 AFFECTED FILES kcms/icons/icon

D29285: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader()

crossi added a comment. In D29285#660158 , @broulik wrote: > Can this go into 5.18? Sure. INLINE COMMENTS > broulik wrote in main.cpp:307 > Isn't this redundant? i.e. doesn't `emitChange` emit do exactly this? This one sends a `notifyCh