D29140: Fix POTD in lock screen (partly)

guoyunhe updated this revision to Diff 81064. guoyunhe added a comment. Fix APOD and Flicker provider cache REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29140?vs=81043&id=81064 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29140

D29144: [applets/weather] Improve UX for selecting a weather station

broulik added a comment. > what happens if we have more Weather Providers won't the dialog box be cluttered? I wonder how many we actually offer? Maybe the old way but with a more obvious label could work. Dunno... REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.

D27669: [kstyle] Tools area

ndavis added a comment. I'm seeing a lot of this message in GDB when I switch from a different QStyle such as Fusion back to Breeze: QBackingStore::endPaint() called with active painter; did you forget to destroy it or call QPainter::end() on it? I also see this sometimes:

D29144: [applets/weather] Improve UX for selecting a weather station

spstarr added a comment. What happens if we have more Weather Providers won't the dialog box be cluttered? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D29144 To: ngraham, #vdg, #plasma, broulik Cc: spstarr, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D29110: [applet] Port to Kirigami.PlaceholderMessage

This revision was automatically updated to reflect the committed changes. Closed by commit R845:fbd32235c6ac: [applet] Port to Kirigami.PlaceholderMessage (authored by ngraham). REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29110?vs=80938&id=81059 REVIS

D29110: [applet] Port to Kirigami.PlaceholderMessage

ngraham added a comment. Thanks! REPOSITORY R845 Plasma Vault BRANCH port-to-PlaceholderMessage (branched from master) REVISION DETAIL https://phabricator.kde.org/D29110 To: ngraham, #vdg, #plasma, ivan, niccolove Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D29110: [applet] Port to Kirigami.PlaceholderMessage

ivan accepted this revision. ivan added a comment. This revision is now accepted and ready to land. Fair enough. REPOSITORY R845 Plasma Vault BRANCH port-to-PlaceholderMessage (branched from master) REVISION DETAIL https://phabricator.kde.org/D29110 To: ngraham, #vdg, #plasma, ivan, n

D29139: Remove .clang-format

This revision was automatically updated to reflect the committed changes. Closed by commit R161:50bde7c5ba33: Remove .clang-format (authored by ndavis). REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29139?vs=81042&id=81058 REVISION DETAIL

D29110: [applet] Port to Kirigami.PlaceholderMessage

ngraham added a comment. I know what you mean, but Kirigami is already a dependency of Plasma itself, which a user of Plasma Vaults presumably already has installed. :) When I created the ExpandableListItem, I put it in plasma-framework, but I almost put it in Kirigami, and for Plasma 6,

D29144: [applets/weather] Improve UX for selecting a weather station

kossebau resigned from this revision. kossebau added a comment. No time left over for Plasma currently, sorry, REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D29144 To: ngraham, #vdg, #plasma, broulik Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblac

D29130: [Applet] Show in system tray iff at least one vault is open

ivan added a comment. And I'l just be using my keyboard shortcut ;) REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D29130 To: ksmanis, #plasma, #vdg, ivan Cc: kmaterka, broulik, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

niccolove added a comment. Size should be an even number - For sizes from 36 to 40, I'm OK with it - At 42 and 44 the icons in the task manager become too big for the panel; their size should be reduced to same as the launcher button, then it's fine - At 46 and over it's fine REPOSIT

D29130: [Applet] Show in system tray iff at least one vault is open

ngraham added a comment. (If this patch lands, I'll set it to "Always visible" because I use my vault a lot) REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D29130 To: ksmanis, #plasma, #vdg, ivan Cc: kmaterka, broulik, ngraham, plasma-devel, Orage, LeGast00n,

D29143: [applets/mediacontroller] Make the right margin the same as the left margin

This revision was automatically updated to reflect the committed changes. Closed by commit R120:082aaaf7b56e: [applets/mediacontroller] Make the right margin the same as the left margin (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.

D29144: [applets/weather] Improve UX for selecting a weather station

ngraham updated this revision to Diff 81049. ngraham marked 2 inline comments as done. ngraham added a comment. Address review comments REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29144?vs=81048&id=81049 BRANCH better-weather-station-selection-u

D29130: [Applet] Show in system tray iff at least one vault is open

ivan added a comment. I'm not fond of this change, but I agree with Nate's comment about the possibility of setting 'always visible' for users that wish to keep the current behaviour, so I'm not going to give this a -1. I'd still like the current behaviour kept, maybe with a different ic

D29144: [applets/weather] Improve UX for selecting a weather station

broulik added a comment. +1 that hidden flag thing always bugged me INLINE COMMENTS > WeatherStationPicker.qml:66 > +ColumnLayout { > +Kirigami.FormData.label: i18n("Select weather providers:") > +Kirigami.FormData.buddyFor: children[1] // 0 is the Repeater Pe

D29144: [applets/weather] Improve UX for selecting a weather station

ngraham created this revision. ngraham added reviewers: VDG, Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch improves the UX of selecting a weather station by re-implementing it a co

D29110: [applet] Port to Kirigami.PlaceholderMessage

ivan added a comment. Not sure I like pulling in Kirigami just for this. Are there other places where Kirigami could improve the Vaults applet? REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D29110 To: ngraham, #vdg, #plasma, ivan, niccolove Cc: plasma-devel, O

D29143: [applets/mediacontroller] Make the right margin the same as the left margin

ngraham created this revision. ngraham added reviewers: cblack, VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Now the song text can't almost touch the right edge. TEST PLAN F8256425: Screenshot

D29142: Add footer support to systray

niccolove created this revision. niccolove added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D29142 AFF

D29137: Added plasmoidHeading to clipboard and ported to Page

This revision was automatically updated to reflect the committed changes. Closed by commit R120:0a7b99bb6ae1: Added plasmoidHeading to clipboard and ported to Page (authored by niccolove). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29137?vs=81038&

D29137: Added plasmoidHeading to clipboard and ported to Page

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yeah, my diff put everything in one new `FullRepresentation` file. This is fine though. Totally works. Shipit! REPOSITORY R120 Plasma Workspace BRANCH clipboard_page_heading (bra

D29140: Fix POTD in lock screen (partly)

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY POTD was cached in `~/.cache/`. But lock screen seems not a process of current user, so it won't find the cache in user's home di

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. Anyway color-wise, here's an example of using a darker tools area color to improve the at-a-glance detectability of the active window: F8256343: vokoscreenNG-2020-04-23_13-26-00.webm Thoughts? REPOSITORY R31 Breeze

D29139: Remove .clang-format

ndavis created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY It was an ignored file that was committed to the repo at some point. Because it's automatically generated and replaces the version c

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 81039. ngraham added a comment. Hopefully fix it REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=81027&id=81039 BRANCH tools-area-color-changes-v2 REVISION DETAIL https://phabricator.kde.org/D28317 AFFECTED

D29137: Added plasmoidHeading to clipboard and ported to Page

ngraham added a comment. Thanks! Implementation-wise, I would have re-arranged things a bit to have only one header for the `PC3.Page`, with the contents changing depending on the page in the stack, rather than your approach of giving each page in the stack its own header, but that works fin

D29137: Added plasmoidHeading to clipboard and ported to Page

niccolove updated this revision to Diff 81038. niccolove added a comment. Added margin REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29137?vs=81037&id=81038 BRANCH clipboard_page_heading (branched from master) REVISION DETAIL https://phabric

D29137: Added plasmoidHeading to clipboard and ported to Page

niccolove added a comment. In D29137#655936 , @ngraham wrote: > Thanks! Implementation-wise, I would have re-arranged things a bit to have only one header for the `PC3.Page`, with the contents changing depending on the page in the stack, rather

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. No wait, that would be half a gigabyte of stuff. Maybe not the best idea to zip it up. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, plas

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. In D28317#655922 , @ngraham wrote: > I mean, how to fix it with `arc`. :) I don't know what the branch looks like on your end. Maybe just zip up the whole repo and send it to me? REPOSITORY R31 Breeze REVISION

D29130: [Applet] Show in system tray iff at least one vault is open

kmaterka added a comment. IMO it is the best **not** to add new status in System Tray - it is already quite confusing with "Disabled" state, the 3 other (Always hidden, Shown when relevant and Always shown) are OK and self-explanatory. "Shown when relevant" might be tricky and we will never

D29130: [Applet] Show in system tray iff at least one vault is open

broulik added inline comments. INLINE COMMENTS > vaultsmodel.h:36 > Q_PROPERTY(bool hasError READ hasError NOTIFY hasErrorChanged) > +Q_PROPERTY(bool hasOpen READ hasOpen NOTIFY hasOpenChanged) > Q_PROPERTY(int count READ rowCount NOTIFY rowCountChanged) I think this should be `ope

D29137: Added plasmoidHeading to clipboard and ported to Page

niccolove updated this revision to Diff 81037. niccolove added a comment. Rebase and enabled REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29137?vs=81036&id=81037 BRANCH clipboard_page_heading (branched from master) REVISION DETAIL https://p

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. I mean, how to fix it with `arc`. :) REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zach

D29109: Port Clipboard and Notifications applets to Kirigami.PlaceholderMessage

ngraham added inline comments. INLINE COMMENTS > ngraham wrote in ClipboardPage.qml:81 > Can this be `enabled:` rather than `visible:`? That's what I did in D29132 > and I think it's nicer and more > consistent with the mockups. never mind, wrong patch REP

D29137: Added plasmoidHeading to clipboard and ported to Page

ngraham added inline comments. INLINE COMMENTS > ClipboardPage.qml:91 > +anchors.fill: parent > +visible: !emptyHint.visible > Can this be `enabled:` rather than `visible:`? That's what I did in D29132 and I think it's nicer and mor

D29109: Port Clipboard and Notifications applets to Kirigami.PlaceholderMessage

ngraham added inline comments. INLINE COMMENTS > ClipboardPage.qml:81 > Layout.fillWidth: true > -visible: !emptyHint.visible > +visible: clipboardMenu.model.count > 0 > Can this be `enabled:` rather than `visible:`? That's what I did in D29132

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. The event filter in `breezetoolsareamanager.cpp` already exists in the tools area patch and the other changes are incompatible with the current version of the tools area patch. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham,

D29137: Added plasmoidHeading to clipboard and ported to Page

niccolove added a comment. Heh, I just noticed :P REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29137 To: niccolove, #vdg, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, him

D29137: Added plasmoidHeading to clipboard and ported to Page

ngraham added a comment. This needs a rebase to apply against the clipboard patch I just landed REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29137 To: niccolove, #vdg, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D29137: Added plasmoidHeading to clipboard and ported to Page

niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH clipboard_page_heading (branched from master) REVISION DETAIL https://phabricator.kde.org/D29137 A

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. Definitely not sure. If you have an idea of what went wrong or how to fix it, I'm all ears. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. Never mind, I was wrong, I see it in arcpatch-D27669. However, just to see what would happen, I made my arcpatch-D27669 branch the upstream of arcpatch-D28317 and it said that arcpatch-D28317 was behind a commit. Are you sure you've rebased against the tools area patc

D29109: Port Clipboard and Notifications applets to Kirigami.PlaceholderMessage

This revision was automatically updated to reflect the committed changes. Closed by commit R120:f7687b01cade: Port Clipboard and Notifications applets to Kirigami.PlaceholderMessage (authored by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29109?vs=80937&id=81034#toc REPOSITO

D29130: [Applet] Show in system tray iff at least one vault is open

ksmanis added a comment. I gave it some thought and I would be reluctant to introduce one more fuzzy (as in ambiguous) state. More specifically, right now, we have four states: "Shown when relevant", "Always shown", "Always hidden", and "Disabled". Without having gone through the source

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. `kstyle/breezetoolsareamanager.cpp` is added in D27669 . Maybe the problem is that D27669 has three commits in it, so arc gets confused? REPOSITORY R31 Breeze REVISION DETAIL https://p

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. It's the change to `kstyle/breezetoolsareamanager.cpp` that causes this patch to fail to apply. That file doesn't exist anywhere. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis, niccolove, The-Feren-

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. How are you guys feeling about the colors here? The Tools Area color currently used in this patch and the mockups demos well, but I'm starting to wonder if we're regressing usability in the process. I'm starting to think that the color isn't dark enough to adequately

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 81027. ngraham added a comment. Oh lord REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=81026&id=81027 BRANCH tools-area-color-changes (branched from master) REVISION DETAIL https://phabricator.kde.org/D2831

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 81026. ngraham added a comment. Arc, you are the worst REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=81025&id=81026 BRANCH tools-area-color-changes (branched from master) REVISION DETAIL https://phabricato

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 81024. ngraham added a comment. Remove merge conflict REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=81023&id=81024 BRANCH tools-area-color-changes (branched from master) REVISION DETAIL https://phabricator

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 81025. ngraham added a comment. Change the patch base, again REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=81024&id=81025 BRANCH tools-area-color-changes (branched from master) REVISION DETAIL https://phab

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 81023. ngraham added a comment. Rebase against tools area patch REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=81022&id=81023 BRANCH tools-area-color-changes (branched from master) REVISION DETAIL https://p

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 81022. ngraham added a comment. Remove leftover CMake bit REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=81021&id=81022 BRANCH tools-area-color-changes (branched from master) REVISION DETAIL https://phabric

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 81021. ngraham added a comment. Rebase on e9d658fcb1f9751a39180e79ccc66aff3a18599d REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=80762&id=81021 BRANCH tools-area-color-changes (branched from master) REVISION

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. the cmake file in `colors/` also needs to be updated for the patch to build. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, plasma-devel, O

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. Ugh REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, Z

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. This time when I try to apply the patch, it fails. I have the most up to date version of D27669 too. ╭ …/src/kde/workspace/breeze   master  ╰ arc patch D28317 INFO Base commit is not in local repository; trying

D28487: Redesign of system monitor plasmoids

mart updated this revision to Diff 81020. mart added a comment. - use the new face library REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28487?vs=80403&id=81020 BRANCH mart/mewSystemMonitor REVISION DETAIL https://phabricator.kde.org/D28487

D28922: Port Sensor Face loading from plasmoid

mart updated this revision to Diff 81019. mart added a comment. - move all face-related stuff in own library - use the new face library REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28922?vs=80982&id=81019 BRANCH mart/sensor_face REVISION D

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6d12d2d62607: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D29135: PageRouter: find parents of items better

cblack updated this revision to Diff 81018. cblack added a comment. Remove stray qDebug REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29135?vs=81015&id=81018 BRANCH cblack/better-router-parent-finding (branched from master) REVISION DETAIL https://p

D28744: Rewrite of the global shortcuts kcm

davidre updated this revision to Diff 81016. davidre added a comment. - Don't drop installing scheme files REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28744?vs=80767&id=81016 BRANCH kcmkeys2 (branched from master) REVISION DETAIL https://pha

D29135: PageRouter: find parents of items better

cblack created this revision. cblack added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY The PageRouterAttached is now able to locate a parent PageRouter by travelling up the visual par

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

crossi updated this revision to Diff 81014. crossi added a comment. clear the nitpicks REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27188?vs=81009&id=81014 REVISION DETAIL https://phabricator.kde.org/D27188 AFFECTED FILES kcms/notifications/k

D29058: Set a component display name for the action collection of ksmserver

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9056449edc89: Set a component display name for the action collection of ksmserver (authored by davidre). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D290

D29052: Set component display name for touchboard and keyboard kcm action collections

This revision was automatically updated to reflect the committed changes. Closed by commit R119:e64a3cb2af23: Set component display name for touchboard and keyboard kcm action collections (authored by davidre). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

broulik accepted this revision. broulik added a comment. Clean up those minor comments and then ship it, thanks! INLINE COMMENTS > kcm.cpp:256 > +} > +return m_behaviorSettingsList[index.row()]; > +} `.value(index.row())` > kcm.cpp:269 > +QString groupName; > +QModel

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

crossi updated this revision to Diff 81009. crossi added a comment. This revision is now accepted and ready to land. Consider Kai's comments REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27188?vs=80894&id=81009 REVISION DETAIL https://phabricator

D29132: [applet] Show toolbar unless Bluetooth hardware is absent

This revision was automatically updated to reflect the committed changes. Closed by commit R97:5b0b2a74bc98: [applet] Show toolbar unless Bluetooth hardware is absent (authored by ngraham). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29132?vs=80999&id=8100

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Looks good and it works for me, tested with Chromium. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D28884

D29130: [Applet] Show in system tray iff at least one vault is open

ngraham added a comment. Yeah. Thinking about it more, your proposal makes some sense because people like you can currently not get what you want at all, while if we integrate this change, people like me can just change the visibility setting to "Always visible". So I'm leaning in the direct

D29132: [applet] Show toolbar unless Bluetooth hardware is absent

manueljlin accepted this revision. manueljlin added a comment. This revision is now accepted and ready to land. Much better REPOSITORY R97 Bluedevil BRANCH almost-always-show-applet-toolbar (branched from master) REVISION DETAIL https://phabricator.kde.org/D29132 To: ngraham, #vdg, ni

D27513: Kill Runner: Remove duplicate function calls and refactor

alex updated this revision to Diff 81006. alex added a comment. Fix small issue from splitting up patch REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27513?vs=76149&id=81006 BRANCH arcpatch-D27513 REVISION DETAIL https://phabricator.kde.org/

D28988: Port hotplug from KRun::runCommand to CommandLauncherJob.

dfaure closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28988 To: dfaure, davidedmundson, sitter, broulik Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himc

D29064: Support module commandline paramenter

broulik added a comment. Note you can pass multiple arguments to `kcmshell5` to open a dedicated save window with random KCMs inside, e.g. done by battery monitor: kcmshell5 powerdevilprofilesconfig powerdevilactivitiesconfig powerdevilglobalconfig Not sure how this could be trans

D29130: [Applet] Show in system tray iff at least one vault is open

ksmanis added a comment. Accurate analysis. If I might add, as an infrequent user of Plasma Vaults, I am stuck between an (almost) always visible applet (whether I select "Always shown" or "Shown when relevant") and an always hidden applet. A "currently active" relevance would cater for both

D29064: Support module commandline paramenter

ngraham added a comment. In D29064#655349 , @mart wrote: > the *really* annoying thing is that every single kcm has a line like > > Exec=kcmshell5 kcm_lookandfeel > > > in its desktop file. Which would call something along the lines

D29132: [applet] Show toolbar unless Bluetooth hardware is absent

broulik added a comment. +1 REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D29132 To: ngraham, #vdg, niccolove, manueljlin Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, l

D29116: [applets/batterymonitor] Put the toolbar in the header area

This revision was automatically updated to reflect the committed changes. Closed by commit R120:eca2ea2c859d: [applets/batterymonitor] Put the toolbar in the header area (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29116?vs=80

D29133: [Icon Applet] Port jump list actions to KServiceAction

broulik created this revision. broulik added reviewers: Plasma, dfaure. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN - Get browser actions on browser icon still - Launching them works and gives proper startup feed

D29130: [Applet] Show in system tray iff at least one vault is open

ngraham added a reviewer: ivan. ngraham added a comment. With this change, a person who creates a Vault they will be regularly using and wants the system tray icon to be always visible now has to go out of their way to use the "always visible" setting in the system tray settings; the "Shown

D29132: [applet] Show toolbar unless Bluetooth hardware is absent

ngraham created this revision. ngraham added reviewers: VDG, niccolove, manueljlin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY While testing other bluedevil patches, I was finding that the toolbar showing

D29111: [applet] Port to Kirigami.PlaceholderMessage

This revision was automatically updated to reflect the committed changes. Closed by commit R97:b75f36807ab4: [applet] Port to Kirigami.PlaceholderMessage (authored by ngraham). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29111?vs=80939&id=80997 REVISION D

D29117: [applet] Put the toolbar in the header area

This revision was automatically updated to reflect the committed changes. Closed by commit R116:0d732531346f: [applet] Put the toolbar in the header area (authored by ngraham). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29117?vs=80

D29130: [Applet] Show in system tray iff at least one vault is open

ksmanis created this revision. ksmanis added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ksmanis requested review of this revision. REVISION SUMMARY Currently, the "Shown when relevant" visibility option in the system tray shows an icon iff

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c55ffdca923a: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch (authored by alex). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

crossi planned changes to this revision. crossi added inline comments. INLINE COMMENTS > broulik wrote in ApplicationConfiguration.qml:45 > I've seen duplicate apps in this list, e.g. snap vs properly installed, so I > don't think you can rely on this. I guess I could use `rootIndex` instead, a

D28664: [OverlaySheet] Add bottom margin when sheet height is less than 3/4 of screen

mart added a comment. in the end, just centered vertically the sheet in 812238afdcb7 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28664 To: cblack, #kirigami Cc: mart, ngraham, plasma-de

D29117: [applet] Put the toolbar in the header area

manueljlin accepted this revision as: manueljlin. manueljlin added a comment. Looks good 👍 Should I accept as VDG or wait for @niccolove 's review? REPOSITORY R116 Plasma Network Management Applet BRANCH put-toolbar-in-header-area (branched from master) REVISION DETAIL https://phabrica

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

alex added a comment. Friendly Ping :-) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28439 To: alex, apol, broulik, davidedmundson Cc: bruns, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngra

D28509: [libnotificationmanager] introduce the WatchedNotificationsModel

bshah updated this revision to Diff 80990. bshah edited the test plan for this revision. bshah added a comment. - watch for notification expiry and closing REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28509?vs=80847&id=80990 BRANCH bshah/notif

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

davidedmundson added a comment. Generally +1 INLINE COMMENTS > waylandintegration.cpp:452 > +connect(m_registry, &KWayland::Client::Registry::screencastingAnnounced, > this, [this] (quint32 name, quint32 version) { > +qDebug() << "screen!"; > +m_screencasting = m_registry

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

apol updated this revision to Diff 80985. apol added a comment. Adopt kwayland changes, provide the right buffer size. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28884?vs=80797&id=80985 BRANCH master REVISION DETA

D28922: Port Sensor Face loading from plasmoid

mart updated this revision to Diff 80982. mart added a comment. - add missing file REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28922?vs=80401&id=80982 BRANCH mart/sensor_face REVISION DETAIL https://phabricator.kde.org/D28922 AFFECTED FI

D28922: Port Sensor Face loading from plasmoid

ahiemstra added inline comments. INLINE COMMENTS > SensorFaceController.cpp:21 > +#include "SensorFaceController.h" > +#include "SensorFaceController_p.h" > +#include "SensorFace_p.h" This file is missing. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D28922

D29127: Account for top and bottom margin in default card height

This revision was automatically updated to reflect the committed changes. Closed by commit R169:a9c8cb612992: Account for top and bottom margin in default card height (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29127?vs=80975&id=80

D29129: Remove implicitHeight from cards in main page

This revision was automatically updated to reflect the committed changes. Closed by commit R1014:40f6034f35c1: Remove implicitHeight from cards in main page (authored by ahiemstra). REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29129?vs=80978&id=809

  1   2   >