ngraham added a reviewer: ivan. ngraham added a comment.
With this change, a person who creates a Vault they will be regularly using and wants the system tray icon to be always visible now has to go out of their way to use the "always visible" setting in the system tray settings; the "Shown when relevant" setting will make the tray icon hidden when they want to go and access the vault. I guess it depends on whether your definition of "relevant" means "the user has created at least one vault" or "the user is actively using a Vault right now". The latter definition is more consistent with the visibility status of the Printers applet, which shows itself only when a printer is in use, not when a printer is simply connected. However it would be inconsistent with the Bluetooth applet, which currently behaves in the same way as the Vaults applet does (the tray icon is visible when Bluetooth is on, not only when a device is connected). And I worry that it will be a bit annoying for people who regularly use Vaults, as it means they will have to access the item in the System Tray's expanded pop-up or change the default settings. I use Vaults quite frequently; if this change lands, I would change the default visibility setting to "Always visible" Thoughts from #VDG <https://phabricator.kde.org/tag/vdg/> and #consistency <https://phabricator.kde.org/tag/goal_consistency/> people? REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D29130 To: ksmanis, #plasma, #vdg, ivan Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
