Fwd: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 FreeBSDQt5.14 - Build # 7 - Still Failing!

Hi all, Please see below - any ideas as to why KHelpCenter no longer successfully builds? It doesn't look like KHelpCenter has changed... Cheers, Ben -- Forwarded message - From: CI System Date: Sat, Apr 18, 2020 at 4:38 PM Subject: KDE CI: Administration » Dependency Build Pla

[plasmashell] [Bug 191394] add "minimize all" action to window list plasmoid

https://bugs.kde.org/show_bug.cgi?id=191394 --- Comment #17 from João Vidal da Silva --- It should also be an action assignable to the keyboard. -- You are receiving this mail because: You are the assignee for the bug.

[Powerdevil] [Bug 353463] RFE: Make use of iio-sensor-proxy

https://bugs.kde.org/show_bug.cgi?id=353463 Ulf Bartholomäus changed: What|Removed |Added CC||u...@gmx.net --- Comment #12 from Ulf Bartho

D28926: Signal player gone in "unload" not "beforeunload"

broulik created this revision. broulik added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY I don't recall if there was a particular reason for using *before* unload but this event is

D28305: WIP: Systemd Startup

davidedmundson added inline comments. INLINE COMMENTS > hchain wrote in plasma-core@.target:3 > can we make this `plasma-kwin@%i.service` ? can do, the _ is just to match the binary name REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28305 To: davidedmundson

D28305: WIP: Systemd Startup

hchain added inline comments. INLINE COMMENTS > plasma-core@.target:3 > +Description=KDE Plasma Workspace Core > +Wants=plasma-plasmashell.service plasma-kwin_%i.service > plasma-kcminit.service plasma-kded.service plasma-kcminit-phase1.service > +Requires=plasma-ksmserver.service can we make t

D28730: Couple of 'trivial' fixes for broken code

This revision was automatically updated to reflect the committed changes. Closed by commit R169:57c63e7ceeb9: Couple of 'trivial' fixes for broken code (authored by ouwerkerk). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28730?vs=79789&id=80413 REVISION D

D28730: Couple of 'trivial' fixes for broken code

cblack accepted this revision. cblack added a comment. This revision is now accepted and ready to land. LGTM. REPOSITORY R169 Kirigami BRANCH fixes-for-qt_quick_controls_mobile REVISION DETAIL https://phabricator.kde.org/D28730 To: ouwerkerk, #kirigami, cblack Cc: cblack, plasma-devel

D28305: WIP: Systemd Startup

davidedmundson updated this revision to Diff 80412. davidedmundson added a comment. support x11 and wayland ...ish we now call target plasma-workspace@x11 or plasma-workspace@wayland it then can call the right services but kwin_wayland is still currently spawned before the systemd stu

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

apol updated this revision to Diff 80408. apol added a comment. Renamed classes REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28884?vs=80340&id=80408 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28884

D28914: Include the Plasma Vault name in the mount dialog title

ngraham added a comment. Go ahead, although we're migrating patch review to GitLab in the coming weeks, so the benefit may be short-lived. :) REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D28914 To: ksmanis, #plasma, davidedmundson, ivan, #vdg Cc: ngraham, pla

D28658: [krdb] Drop GTK2 colour exporting

This revision was automatically updated to reflect the committed changes. Closed by commit R119:2fb0bf85fe63: [krdb] Drop GTK2 colour exporting (authored by cblack). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28658?vs=79579&id=80406 REVISION DETAIL

D28744: Rewrite of the global shortcuts kcm

davidre updated this revision to Diff 80405. davidre added a comment. - Use less DBus calls for loading REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28744?vs=80398&id=80405 BRANCH kcmkeys2 (branched from master) REVISION DETAIL https://phabri

D28744: Rewrite of the global shortcuts kcm

davidre added inline comments. INLINE COMMENTS > broulik wrote in shortcutsmodel.cpp:38 > Hmm... > how about > > QStringList actionId; > actionId.reserve(4); This actually crashes now REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28744 To: davidre, #vdg,

D28917: [Media Controller] Don't set album art on tooltip anymore

This revision was automatically updated to reflect the committed changes. Closed by commit R120:38c269dc486d: [Media Controller] Don't set album art on tooltip anymore (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28917?vs=8037

D28914: Include the Plasma Vault name in the mount dialog title

ksmanis added a comment. In D28914#650523 , @ngraham wrote: > Can you provide your email address in a comment here so that we can land the patch with the correct git authorship information? I'd like to give arcanist a spin, if possible :)

D28487: Redesign of system monitor plasmoids

mart updated this revision to Diff 80403. mart added a comment. - port to the new library REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28487?vs=79120&id=80403 BRANCH mart/mewSystemMonitor REVISION DETAIL https://phabricator.kde.org/D28487

D28922: Port Sensor Face loading from plasmoid

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY The plasmoid loginc has been ported in the SensorFaceController public class it's its responsibility to i

D28914: Include the Plasma Vault name in the mount dialog title

ngraham added a comment. Can you provide your email address in a comment here so that we can land the patch with the correct git authorship information? REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D28914 To: ksmanis, #plasma, davidedmundson, ivan, #vdg Cc: n

D28914: Include the Plasma Vault name in the mount dialog title

ngraham added reviewers: ivan, VDG. ngraham added inline comments. INLINE COMMENTS > mountdialog.cpp:34 > m_ui.setupUi(this); > +setWindowTitle(i18nc("%1 is the name of the Plasma Vault to open", "Open > %1 Plasma Vault", vault->name())); > Maybe put the vault name in single quotes?

D28744: Rewrite of the global shortcuts kcm

davidre updated this revision to Diff 80398. davidre added a comment. - Fix defaults REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28744?vs=80387&id=80398 BRANCH kcmkeys2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D2874

D28773: feat(kded): add getAutoRotate method and rename lockAutoRotate

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R104:67980bc2728d: feat(kded): add getAutoRotate method and rename lockAutoRotate (authored by z3ntu). REPOSITORY R104 KS

D28773: feat(kded): add getAutoRotate method and rename lockAutoRotate

z3ntu updated this revision to Diff 80393. z3ntu added a comment. - const auto REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28773?vs=79997&id=80393 BRANCH autorotate REVISION DETAIL https://phabricator.kde.org/D28773 AFFECTED FILES kded/config.cp

D28916: fix(kded): center action OSD on wayland

bport added inline comments. INLINE COMMENTS > davidedmundson wrote in OsdSelector.qml:34 > That was confusing, I'll rephrase. > > Is it so the property "x" remains unset when running under the x windowing > environment? Yes I wanted to ensure we don't change it on X Didn't found a way to do i

D28509: RFC: [libnotificationmanager] introduce the notification watcher

bshah added a comment. Great! Since phab ate my nice commit message here we go, I've re-worked previous revision of patch little bit differently, - Instead of originally planned Watcher class, now there is WatchedNotificationsModel - Most if not all of original NotificationsModel c

D28744: Rewrite of the global shortcuts kcm

ngraham added a comment. This is looking really good. Other than my previous comments (most of which have been resolved, yay) I have just nitpicks left, really. INLINE COMMENTS > ShortcutActionDelegate.qml:165 > +onClicked: > kcm.shortcutsModel.disableSho

D28916: fix(kded): center action OSD on wayland

davidedmundson added inline comments. INLINE COMMENTS > davidedmundson wrote in OsdSelector.qml:34 > Why are we going for this instead of a binding? > > Is it so X and Y remain unset on X? That was confusing, I'll rephrase. Is it so the property "x" remains unset when running under the x wind

D28916: fix(kded): center action OSD on wayland

davidedmundson added inline comments. INLINE COMMENTS > OsdSelector.qml:34 > + > +onScreenGeometryChanged: { > +root.x = screenGeometry.x + (screenGeometry.width - mainItem.width) > / 2 Why are we going for this instead of a binding? Is it so X and Y remain unset on X? REPOSITORY

D28509: RFC: [libnotificationmanager] introduce the notification watcher

bshah updated this revision to Diff 80391. bshah marked 3 inline comments as done. bshah added a comment. - kill separate watcher class - introduce AbstractNotificationsModel - introduce WatchedNotificationsModel REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabr

D28916: fix(kded): center action OSD on wayland

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Looks good to me. Also happy @davidedmundson ? INLINE COMMENTS > osd.cpp:33 > +#include > +#include > Correct lexicographical order on push. > osd.cpp:143 > if (auto *rootObjec

D28744: Rewrite of the global shortcuts kcm

davidre updated this revision to Diff 80387. davidre added a comment. - Remove components as good as the current kcm REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28744?vs=80224&id=80387 BRANCH kcmkeys2 (branched from master) REVISION DETAIL h

D28653: Set cursor size default to 24 to align with KCM default value

This revision was automatically updated to reflect the committed changes. Closed by commit R135:4a7786999d31: Set cursor size default to 24 to align with KCM default value (authored by bport). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabric

D28655: Set default cursor size as 24 to follow new default on KCM

This revision was automatically updated to reflect the committed changes. Closed by commit R120:7d19c5fc0fa7: Set default cursor size as 24 to follow new default on KCM (authored by bport). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28655?vs=79572

D28652: [Cursors] Remove Resolution Dependant option

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a68554d39c5c: [Cursors] Remove Resolution Dependant option (authored by bport). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28652?vs=79590&id=80379 REVIS

D28917: [Media Controller] Don't set album art on tooltip anymore

broulik updated this revision to Diff 80378. broulik added a comment. - Set default state (It's overridden by the `State` below for stopped, playing, paused, but doesn't hurt to have it as fallback with the other props I guess) REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDAT

D28917: [Media Controller] Don't set album art on tooltip anymore

ngraham added a comment. Hmm, `plasmoid.icon` should probably still be set so it has the right appearance in the tray; we just modified the other components to not show that same icon on the tooltip. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28917 To

D28917: [Media Controller] Don't set album art on tooltip anymore

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY We don't show icons on tooltips anymore. And the System Tray config doesn't show images. BU

D28916: fix(kded): center action OSD on wayland

bport created this revision. bport added reviewers: romangg, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REVISION SUMMARY Currently on wayland action OSD is not centered on the screen. On Wayland we will cent

D28914: Include the Plasma Vault name in the mount dialog title

ksmanis created this revision. ksmanis added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ksmanis requested review of this revision. REVISION SUMMARY Allows synergy with password managers that rely on the window title in order to supply the approp

D28907: [Services Runner] Fix mimeDataForMatch

This revision was automatically updated to reflect the committed changes. Closed by commit R120:08bafc3b44ab: [Services Runner] Fix mimeDataForMatch (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28907?vs=80358&id=80373 REVISIO

D28906: [libtaskmanager] Port KRun::runApplication to KIO::ApplicationLauncherJob

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6d25115e4627: [libtaskmanager] Port KRun::runApplication to KIO::ApplicationLauncherJob (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28906?vs=80357&id=80372#toc REPOSI

D28853: krunner: Prevent regression

This revision was automatically updated to reflect the committed changes. Closed by commit R120:a28e110cbb15: krunner: Prevent regression (authored by apol, committed by fvogt). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28853?vs=80192&id=80371 R

D28905: Fix variable assignment

This revision was automatically updated to reflect the committed changes. Closed by commit R120:70fa173d466a: Fix variable assignment (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28905?vs=80354&id=80370 REVISION DETAIL http

D28906: [libtaskmanager] Port KRun::runApplication to KIO::ApplicationLauncherJob

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. beautiful REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28906 To: broulik, #plasma, hein, davidedmundson Cc: davidedmundson, plasma-deve

D28908: Use the same icon mode calculation for comboboxes as for buttons

davidre added a comment. I don't understand. The palette doesn't change when a widget is selected, does it? The selected state is used by KIconLoader to decide which color to use for text color, or highlight state == KIconLoader::SelectedState ? pal.highlightedText().color().name() :

D28908: Use the same icon mode calculation for comboboxes as for buttons

broulik added a comment. Now that we can properly recolorize all the icons, maybe we should drop the `State_Selected` handling altogether? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28908 To: davidre, broulik, #breeze Cc: plasma-devel, Orage, LeGast00n, The-Feren

D28908: Use the same icon mode calculation for comboboxes as for buttons

davidre created this revision. davidre added reviewers: broulik, Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY When hovering a focused combobox the icon was in Selected state resulting in a wrong col

D28907: [Services Runner] Fix mimeDataForMatch

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Regression introduced in 6e660cf92d7c3fb0e20527866691eaff9f8bc207

D28906: [libtaskmanager] Port KRun::runApplication to KIO::ApplicationLauncherJob

broulik created this revision. broulik added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN - Launching pinned apps still works - Failure to launch results in a nice plasma notification now

D28830: Don't set a custom palette if we have the same palette as the currently active one

This revision was automatically updated to reflect the committed changes. Closed by commit R31:66d0b0b4e3e1: Don't set a custom palette if we have the same palette as the currently active… (authored by davidre). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28830?vs=80127&id=80356#toc R

D28905: Fix variable assignment

broulik created this revision. broulik added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Noticed this while refactoring something in the area. TEST PLAN 5.18, Not sure what the

D28904: Cleanup dependencies

anthonyfieroni added inline comments. INLINE COMMENTS > CMakeLists.txt:20 > > -find_package(Qt5 ${QT_MIN_VERSION} CONFIG REQUIRED COMPONENTS Widgets DBus > X11Extras) > -find_package(KF5 ${KF5_MIN_VERSION} REQUIRED COMPONENTS Activities Auth > IdleTime Config DBusAddons Solid I18n GlobalAccel

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

jgrulich added inline comments. INLINE COMMENTS > waylandintegration_p.h:126 > KWayland::Client::FakeInput *m_fakeInput = nullptr; > -KWayland::Client::RemoteAccessManager *m_remoteAccessManager = nullptr; > +KWayland::Client::VideoStreaming *m_remoteAccessManager = nullptr; > Sho

D28853: krunner: Prevent regression

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Proper fix with refactoring will take too long, let's take this for now. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D28853 To: apol, #p

D28904: Cleanup dependencies

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY That unused `EditPage::openUrl` pulled in `KIOWidgets` with all its dependencies. This includes

D28904: Cleanup dependencies

broulik updated this revision to Diff 80351. broulik edited the test plan for this revision. broulik added a comment. - Drop all `KComboBox` uses REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28904?vs=80350&id=80351 REVISION DETAIL https://phabricato

D28830: Don't set a custom palette if we have the same palette as the currently active one

broulik accepted this revision. broulik added a comment. Fixes the Dolphin toolbar icon color and KWrite save dialog button icon color. INLINE COMMENTS > breezehelper.cpp:1608 > +if (changePalette) { > +if(activePalette == QPalette()) { > +KIconLoader::glob