anthonyfieroni added inline comments.
INLINE COMMENTS
> CMakeLists.txt:20
>
> -find_package(Qt5 ${QT_MIN_VERSION} CONFIG REQUIRED COMPONENTS Widgets DBus
> X11Extras)
> -find_package(KF5 ${KF5_MIN_VERSION} REQUIRED COMPONENTS Activities Auth
> IdleTime Config DBusAddons Solid I18n GlobalAccel KIO NotifyConfig Wayland
> DocTools Crash Notifications)
> +find_package(Qt5 ${QT_MIN_VERSION} CONFIG REQUIRED COMPONENTS Widgets DBus
> Network X11Extras)
> +find_package(KF5 ${KF5_MIN_VERSION} REQUIRED COMPONENTS Activities Auth
> IdleTime Config DBusAddons Service Solid I18n GlobalAccel NotifyConfig
> Wayland DocTools Crash Notifications WidgetsAddons XmlGui)
That's not right at least. It should be optional when KF5NetworkManagerQt is
found. It looks weird to present at all.
REPOSITORY
R122 Powerdevil
REVISION DETAIL
https://phabricator.kde.org/D28904
To: broulik, #plasma
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
