D28034: [Applet] Port to ExpandableListItem

2020-04-05 Thread Jan Grulich
jgrulich added a comment. Seems to work with all functionality working as before, well done!! Just few details: 1. I noticed that expanding an active connection makes it to switch the expanded "tab view" to the second tab with details information, it first expands showing the traffic m

D28517: Send notification when screencasting fails

2020-04-05 Thread Jan Grulich
jgrulich added inline comments. INLINE COMMENTS > screencaststream.cpp:376 > +notification->setIconName(QStringLiteral("dialog-error")); > +notification->setUrgency(KNotification::NormalUrgency); > +notification->sendEvent(); Does it need to be specified if you have Urgen

D28517: Send notification when screencasting fails

2020-04-05 Thread Jan Grulich
jgrulich added inline comments. INLINE COMMENTS > xdp_kde.notifyrc:3 > +IconName=start-here-kde-plasma > +Comment=Friendly Name of app > +Name=KDE Portal Integration I don't know if the comments are used in the Notifications KCM, but even if not, I would use a different one, maybe something lik

D28066: Remove the STATIC_LIBRARY option to fix static builds

2020-04-05 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R169:989cd3098ced: Remove the STATIC_LIBRARY option to fix static builds (authored by bartoc, committed by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28066?v

D28066: Remove the STATIC_LIBRARY option to fix static builds

2020-04-05 Thread Charles Barto
bartoc updated this revision to Diff 79439. bartoc added a comment. rebased on master CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28066?vs=78262&id=79439 REVISION DETAIL https://phabricator.kde.org/D28066 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt To: bartoc, #kirig

D28035: [Applet] Port to ExpandableListItem

2020-04-05 Thread Nathaniel Graham
ngraham updated this revision to Diff 79437. ngraham added a comment. Update required Frameworks version REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28035?vs=77966&id=79437 BRANCH port-to-ExpandableListItem (branched from master) REVISION DETAIL

D28526: [notifications] Hide close/configure buttons on mobile

2020-04-05 Thread Nicolas Fella
nicolasfella added a comment. In D28526#640431 , @broulik wrote: > I think we also want to stop the animation/circle thing, too? Maybe shove all of it in a loader? Isn't that done automatically since the circle thing is a child of the clo

D28575: Make headings of systray and applet merge

2020-04-05 Thread Manuel Jesús de la Fuente
manueljlin added a comment. Some mockups: F8216924: image.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28575 To: niccolove, #plasma, #vdg Cc: manueljlin, ognarb, ngraham, plasma-devel, Orage, LeGast00n, The-Fere

D28575: Make headings of systray and applet merge

2020-04-05 Thread Carl Schwan
ognarb added a comment. > I'd like to solve that by removing the sidebar and adding a back button, but that would be for another patch in the future. -1 from me to remove the sidebar. I really liked how the sidebar looked in the final mockup in T10470