jgrulich added inline comments.

INLINE COMMENTS

> screencaststream.cpp:376
> +        notification->setIconName(QStringLiteral("dialog-error"));
> +        notification->setUrgency(KNotification::NormalUrgency);
> +        notification->sendEvent();

Does it need to be specified if you have Urgency=Normal set in the notifyrc 
file? I believe if you don't specify it, it will use the default urgency, which 
will be taken from the notifyrc file.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28517

To: cblack, #plasma, #vdg, ngraham, apol, jgrulich
Cc: broulik, apol, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

Reply via email to