Re: 2 kirigami fixes for a point release

Hi, > We have to ask: what causes buggy releases? People rushing things in at the last minute, even better if unreviewed. Plasma 5.18 was a prime example of this. Every single time there's drama on Beta tagging day for some last minute change that should go in. To remedy this I wanted Beta fe

Re: 2 kirigami fixes for a point release

On Thu, Feb 13, 2020 at 10:00 AM Nate Graham wrote: > > [+ frameworks and plasma mailing lists] > > > On 2020-02-12 11:31, Albert Astals Cid wrote: > > El dimecres, 12 de febrer de 2020, a les 15:37:09 CET, Nate Graham va > > escriure: > >> Personally I think it would be nice to have > >> 86f9884

Re: 2 kirigami fixes for a point release

Hello, Since I'm not on release-team I'm discovering this just now. On Wednesday, 12 February 2020 21:59:32 CET Nate Graham wrote: > [+ frameworks and plasma mailing lists] > > On 2020-02-12 11:31, Albert Astals Cid wrote: > > El dimecres, 12 de febrer de 2020, a les 15:37:09 CET, Nate Graham va

Re: 2 kirigami fixes for a point release

[+ frameworks and plasma mailing lists] On 2020-02-12 11:31, Albert Astals Cid wrote: El dimecres, 12 de febrer de 2020, a les 15:37:09 CET, Nate Graham va escriure: Personally I think it would be nice to have 86f988434cd657e77cc9429e78f7290ce6b5713d since otherwise LTS Plasma users will be hi

D27199: [Applet]Update layout based on T10470

ngraham added a comment. Hmm, now I see my currently connected network twice: F8100139: Screenshot_20200212_131124.png REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27199 To: gvgeo, #plasma, #vdg

D27093: Provide better name for GTK Settings Sync service

This revision was automatically updated to reflect the committed changes. Closed by commit R99:ddc9187adbc5: Provide better name for GTK Settings Sync service (authored by gikari). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27093?vs=75569

D26861: [Applet/Task Manager] Move audio indicator to the corner

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a35d2b9adf40: [Applet/Task Manager] Move audio indicator to the corner (authored by gvgeo, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.o

D26861: [Applet/Task Manager] Move audio indicator to the corner

ngraham added a comment. Landing on master to be safe, but if Plasma people take a look later and like what they see, we can backport this to the stable branch. REPOSITORY R119 Plasma Desktop BRANCH pos2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26861 To: gv

D27090: Replace config.h with target_compile_definitions

gikari abandoned this revision. gikari added a comment. Fair point. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D27090 To: gikari Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen,

D27093: Provide better name for GTK Settings Sync service

gikari updated this revision to Diff 75569. gikari added a comment. Remove "Appearance" part, since settings applied by kded module is not only about appearance (e.g. scrollbar behavior) REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2709

D27093: Provide better name for GTK Settings Sync service

gikari updated this revision to Diff 75568. gikari added a comment. Capitalize GNOME and remove `KDE/Qt` part REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27093?vs=74843&id=75568 BRANCH good-service-name REVISION DETAIL https://pha

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham added a comment. Hmm, in this case it doesn't seem appropriate to me. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25447 To: ngraham, #vdg, #plasma, #baloo, bruns, davidedmundson Cc: mmustac, davidedmundson, astippich, plasma-devel, hurikhan77, lots

D27346: emojier: Improve resizing performance

Zren added a comment. Not sure. Backwards compatibility? Firefox renders a couple of them fine, while the TaskManager widget doesn't. Could it be the "Noto" font? The facepalm ones not working are 3 glyphs merged together (facepalm+skincolor+sex). It's rendering (facepalm+skincolor) fine

D26111: Runner: make recentdocument use KActivityStats data

meven added a comment. ping @broulik REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26111 To: meven, #plasma, ivan, ngraham, broulik Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenB

D26726: [Breeze Cursors] Add some more cursor names

guilhermesilva added a comment. Hello, I'm the person the reported this issue to the Chromium team. The fix they made will probably land only on Chromium 81 or later, but a lot of Electron apps will still rely on older vers

D26861: [Applet/Task Manager] Move audio indicator to the corner

ngraham added a comment. No response, assuming that means it's good. :) REPOSITORY R119 Plasma Desktop BRANCH pos2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26861 To: gvgeo, #vdg, #plasma, hein, ngraham Cc: broulik, Fuchs, ndavis, filipf, cblack, plasma-devel

D27346: emojier: Improve resizing performance

apol added a comment. uh right, didn't see that. Actually, do you know what's up with those? we should just be showing them as 1 glyph... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27346 To: apol, #plasma Cc: Zren, plasma-devel, Orage, LeGast00n, The-Fer

Plasma 5.19 Kickoff Meeting

Time to start the 5.19 developer cycle If you want to chat about what would be good to work on in 5.19 tick the schedule here for when you're free https://doodle.com/poll/dzgqdxpxzqpksvhs Jonathan

D27346: emojier: Improve resizing performance

Zren added a comment. FixedSize 25pt does help, but "2 glyph emojis" will overlap each other. F8099880: 2020-02-12___11-38-36.png F8099891: screen-2020-02-12_11.34.09.mp4 Rectangle { width: pare

D27344: [Notifications] Only let details label grow, never shrink

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Ah, this was mildly annoying me recently. Nice fix. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27344 To: broulik, #plasma, ngraham Cc: ngraham, pla

D27057: Solid-device-automounter/kcm: Enable/Disable columns automount onLogin/onAttached depending on corresponding checkbox

This revision was automatically updated to reflect the committed changes. Closed by commit R119:37e9bd06774b: Solid-device-automounter/kcm: Enable/Disable columns automount… (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27057?vs=74

D27353: Allow Activity Switcher to move/add windows to activities by drag and drop from the taskbar

wstephenson created this revision. wstephenson added reviewers: Plasma, ivan, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. wstephenson requested review of this revision. REVISION SUMMARY In the same way that the Activity Pager should (see https://phab

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcm.cpp:277 > +if (!m_currentBehavior) { > +setBehaviorSettingsToLoad(m_behaviorSettingsList.begin().key()); > +} What about m_behaviorSettingsL

D27348: Port to use level 1 Heading instead of Title

ngraham created this revision. ngraham added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY `PlasmaExtras.Title` is literally identical to a level 1 Heading. Let's port to that so we have

D27198: [RFC] Reduce size of Level 1 headings and increase left padding on page titles

ngraham added a comment. Thanks! Companion changes: plasma-framework: a9ea008b8d6fab00fdeee029e685a9fc3b4061c8 kwidgetsaddons: 2157e258721be0c81477b2e305e6d697cafb597d

D27198: [RFC] Reduce size of Level 1 headings and increase left padding on page titles

This revision was automatically updated to reflect the committed changes. Closed by commit R169:fc8c0fc8cd50: [RFC] Reduce size of Level 1 headings and increase left padding on page titles (authored by ngraham). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

Plasma Sprint 2020 in Augsburg, Germany

Hi everyone, I'm happy to announce that we have some dates for our annual Plasma sprint! This year it's kindly being hosted by our friends at TUXEDO Computers in Augsburg, Germany from Saturday 2020-04-18 till Sunday 2020-04-26. There'll be network, power, snacks, and drinks, as well as a can

D27347: Only link to Qt5WebChannel if Qt5WebEngineWidgets available

fvogt created this revision. fvogt added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. fvogt requested review of this revision. REVISION SUMMARY QWebChannel is only used if HAVE_QTWEBENGINEWIDGETS is set. WIP as I'm not show how to express HAVE

D27337: [Emojier] Optimize performance

apol added a comment. Here's an alternative https://phabricator.kde.org/D27346 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27337 To: Zren, apol, #plasma Cc: broulik, davidedmundson, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jralei

D27346: emojier: Improve resizing performance

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Don't calculate the most fitting size, adopt a reasonable size and go with it. BUG: 417454 TEST PLAN

D27345: Don't emit palette changes if the palette didn't change

apol created this revision. apol added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Should keep us from repainting objects that depend on it. TEST PLAN Detected it with KObjectTracker,

D27337: [Emojier] Optimize performance

apol added inline comments. INLINE COMMENTS > broulik wrote in CategoryPage.qml:71 > > but there was a bit of an empty space on the right. > > If `Label` resizing is the problem. Would keeping the `Label` square and > using a padding `Item` around it fix the performance issue? Yes, or just not

D27337: [Emojier] Optimize performance

broulik added inline comments. INLINE COMMENTS > apol wrote in CategoryPage.qml:71 > This was added so that the columns adapt to the width of the view, otherwise > it was very fast (as fast as without your Loader) but there was a bit of an > empty space on the right. > but there was a bit of a

D27337: [Emojier] Optimize performance

apol added inline comments. INLINE COMMENTS > CategoryPage.qml:71 > > -cellWidth: width/columnsToHave > +cellWidth: desiredSize > cellHeight: desiredSize This was added so that the columns adapt to the width of the view, otherwise it was very fast (as fast as without

D27337: [Emojier] Optimize performance

apol added a comment. Right, maybe we can find a better way of doing this. Or just delaying resizing of the Label since it's indeed the slow part. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27337 To: Zren, apol, #plasma Cc: broulik, davidedmundson, ngrah

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > DeviceAutomounterKCM.cpp:57 > > +m_settings = new AutomounterSettings(); > +addConfig(m_settings, this); Missing this as parent, this is leaked. Also

D27344: [Notifications] Only let details label grow, never shrink

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Avoids repeatedly resizing the dialog when copying many files. It will still resize when the spe

D27024: Solid-device-automounter/kcm: show disconnected known device when disconnecting it

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > DeviceModel.cpp:101 > // is no longer available when the device is gone > +// Unless we have some settings for the device > +if (Automou

D27116: KCM/Component email: simplify code

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. Tiny code style breakage INLINE COMMENTS > componentchooseremail.cpp:85 > +setCurrentIndex(count() -1); > +m_currentIndex = count() -1; > } The spaces should b

D27052: Solid-device-automounter/kcm: Convert some foreach

ervin accepted this revision. ervin added a comment. This revision is now accepted and ready to land. Just a nitpick, your call if you want to tackle it or not. INLINE COMMENTS > DeviceAutomounter.cpp:73 > +const QList volumes = > Solid::Device::listFromType(Solid::DeviceInterface::Stora

D27325: improve some previously recycled strings

This revision was automatically updated to reflect the committed changes. Closed by commit R102:e0268dc8032c: improve some previously recycled strings (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27325?vs=75478&id=75545#toc REPOSITORY R102 KInfoCenter CHANGES S

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > fonts.cpp:136 > +for (KXftConfig::Hint::Style s : {KXftConfig::Hint::None, > KXftConfig::Hint::Slight, KXftConfig::Hint::Medium, KXftConfig::Hint::Full}) {

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

bport updated this revision to Diff 75541. bport added a comment. Fix reset and default button for Anti Aliasing area (states were ok, but UI values were not updated after clicking them) depends on https://phabricator.kde.org/D27342 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UP

D27337: [Emojier] Optimize performance

Zren added a comment. I used `Loader` as I didn't want loading glyphs to block scrollbar responsiveness. `GridView` reuses delegates, but I don't think it's the `MouseArea` + `Label` constructor that's slow. I think it's the "rendering the emoji glyph" in the GUI draw that is the root cause.

D27199: [Applet]Update layout based on T10470

jgrulich added a comment. I like it. I didn't go through the code changes yet, I'll wait until you finish it completely. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27199 To: gvgeo, #plasma, #vdg, jgrulich, manueljlin Cc: ngraham, plasma

D27337: [Emojier] Optimize performance

broulik added a comment. I suspect `DelegateRecycler` doesn't do grid, otherwise this could have been an option? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27337 To: Zren, apol, #plasma Cc: broulik, davidedmundson, ngraham, plasma-devel, Orage, LeGast00n

D27337: [Emojier] Optimize performance

davidedmundson added a comment. What the original code was trying to do was distribute the whitespace among cells, right now if you resize to be 5.8 columns wide we want to spread that out, not have a gap on the white. You're right on the fonts resizing though. This is also a fix: